* [PATCH BlueZ] client: Fix advertise broadcast
@ 2021-05-14 23:58 Luiz Augusto von Dentz
2021-05-15 1:40 ` [BlueZ] " bluez.test.bot
0 siblings, 1 reply; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2021-05-14 23:58 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
When advertising with type broadcast it cannot be discoverable as that
would require setting flags which is not allowed by the spec.
---
client/advertising.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/client/advertising.c b/client/advertising.c
index 3bf12fe87..e40086c98 100644
--- a/client/advertising.c
+++ b/client/advertising.c
@@ -512,6 +512,9 @@ void ad_register(DBusConnection *conn, GDBusProxy *manager, const char *type)
g_free(ad.type);
ad.type = g_strdup(type);
+ if (!strcasecmp(ad.type, "Broadcast"))
+ ad.discoverable = false;
+
if (g_dbus_register_interface(conn, AD_PATH, AD_IFACE, ad_methods,
NULL, ad_props, NULL, NULL) == FALSE) {
bt_shell_printf("Failed to register advertising object\n");
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [BlueZ] client: Fix advertise broadcast
2021-05-14 23:58 [PATCH BlueZ] client: Fix advertise broadcast Luiz Augusto von Dentz
@ 2021-05-15 1:40 ` bluez.test.bot
2021-05-17 21:53 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 3+ messages in thread
From: bluez.test.bot @ 2021-05-15 1:40 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=482855
---Test result---
Test Summary:
CheckPatch PASS 0.69 seconds
GitLint PASS 0.18 seconds
Prep - Setup ELL PASS 49.72 seconds
Build - Prep PASS 0.12 seconds
Build - Configure PASS 8.58 seconds
Build - Make PASS 210.40 seconds
Make Check PASS 9.74 seconds
Make Distcheck PASS 246.39 seconds
Build w/ext ELL - Configure PASS 8.87 seconds
Build w/ext ELL - Make PASS 201.20 seconds
Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BlueZ] client: Fix advertise broadcast
2021-05-15 1:40 ` [BlueZ] " bluez.test.bot
@ 2021-05-17 21:53 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2021-05-17 21:53 UTC (permalink / raw)
To: linux-bluetooth
Hi,
On Fri, May 14, 2021 at 6:40 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=482855
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 0.69 seconds
> GitLint PASS 0.18 seconds
> Prep - Setup ELL PASS 49.72 seconds
> Build - Prep PASS 0.12 seconds
> Build - Configure PASS 8.58 seconds
> Build - Make PASS 210.40 seconds
> Make Check PASS 9.74 seconds
> Make Distcheck PASS 246.39 seconds
> Build w/ext ELL - Configure PASS 8.87 seconds
> Build w/ext ELL - Make PASS 201.20 seconds
>
> Details
> ##############################
> Test: CheckPatch - PASS
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
>
> ##############################
> Test: GitLint - PASS
> Desc: Run gitlint with rule in .gitlint
>
> ##############################
> Test: Prep - Setup ELL - PASS
> Desc: Clone, build, and install ELL
>
> ##############################
> Test: Build - Prep - PASS
> Desc: Prepare environment for build
>
> ##############################
> Test: Build - Configure - PASS
> Desc: Configure the BlueZ source tree
>
> ##############################
> Test: Build - Make - PASS
> Desc: Build the BlueZ source tree
>
> ##############################
> Test: Make Check - PASS
> Desc: Run 'make check'
>
> ##############################
> Test: Make Distcheck - PASS
> Desc: Run distcheck to check the distribution
>
> ##############################
> Test: Build w/ext ELL - Configure - PASS
> Desc: Configure BlueZ source with '--enable-external-ell' configuration
>
> ##############################
> Test: Build w/ext ELL - Make - PASS
> Desc: Build BlueZ source with '--enable-external-ell' configuration
>
>
>
> ---
> Regards,
> Linux Bluetooth
Pushed.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-17 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 23:58 [PATCH BlueZ] client: Fix advertise broadcast Luiz Augusto von Dentz
2021-05-15 1:40 ` [BlueZ] " bluez.test.bot
2021-05-17 21:53 ` Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.