From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Maxime Ripard <maxime@cerno.tech>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)
Date: Sat, 15 May 2021 13:34:47 +0300 [thread overview]
Message-ID: <202105150754.JlFEHPkM-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 25a1298726e97b9d25379986f5d54d9e62ad6e93
commit: dec92020671c48da231189eb06a5f755f492f87f drm: Use the state pointer directly in planes atomic_check
config: arm-randconfig-m031-20210514 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)
vim +/state +124 drivers/gpu/drm/armada/armada_plane.c
d40af7b1ae23da Russell King 2018-07-30 108 int armada_drm_plane_atomic_check(struct drm_plane *plane,
7c11b99a8e58c0 Maxime Ripard 2021-02-19 109 struct drm_atomic_state *state)
d40af7b1ae23da Russell King 2018-07-30 110 {
7c11b99a8e58c0 Maxime Ripard 2021-02-19 @111 struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
^^^^^
Dereferenced inside the function.
7c11b99a8e58c0 Maxime Ripard 2021-02-19 112 plane);
ba5c1649465d40 Maxime Ripard 2021-02-19 113 struct armada_plane_state *st = to_armada_plane_state(new_plane_state);
ba5c1649465d40 Maxime Ripard 2021-02-19 114 struct drm_crtc *crtc = new_plane_state->crtc;
d40af7b1ae23da Russell King 2018-07-30 115 struct drm_crtc_state *crtc_state;
1d1547ec12bc7d Russell King 2019-01-25 116 bool interlace;
1d1547ec12bc7d Russell King 2019-01-25 117 int ret;
1d1547ec12bc7d Russell King 2019-01-25 118
ba5c1649465d40 Maxime Ripard 2021-02-19 119 if (!new_plane_state->fb || WARN_ON(!new_plane_state->crtc)) {
ba5c1649465d40 Maxime Ripard 2021-02-19 120 new_plane_state->visible = false;
1d1547ec12bc7d Russell King 2019-01-25 121 return 0;
1d1547ec12bc7d Russell King 2019-01-25 122 }
d40af7b1ae23da Russell King 2018-07-30 123
dec92020671c48 Maxime Ripard 2021-02-19 @124 if (state)
^^^^^
Checked too late.
dec92020671c48 Maxime Ripard 2021-02-19 125 crtc_state = drm_atomic_get_existing_crtc_state(state,
ba5c1649465d40 Maxime Ripard 2021-02-19 126 crtc);
d40af7b1ae23da Russell King 2018-07-30 127 else
d40af7b1ae23da Russell King 2018-07-30 128 crtc_state = crtc->state;
1d1547ec12bc7d Russell King 2019-01-25 129
ba5c1649465d40 Maxime Ripard 2021-02-19 130 ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state,
ba5c1649465d40 Maxime Ripard 2021-02-19 131 0,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)
Date: Sat, 15 May 2021 07:53:03 +0800 [thread overview]
Message-ID: <202105150754.JlFEHPkM-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5372 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Maxime Ripard <maxime@cerno.tech>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 25a1298726e97b9d25379986f5d54d9e62ad6e93
commit: dec92020671c48da231189eb06a5f755f492f87f drm: Use the state pointer directly in planes atomic_check
date: 3 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 3 months ago
config: arm-randconfig-m031-20210514 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)
vim +/state +124 drivers/gpu/drm/armada/armada_plane.c
d40af7b1ae23da Russell King 2018-07-30 107
d40af7b1ae23da Russell King 2018-07-30 108 int armada_drm_plane_atomic_check(struct drm_plane *plane,
7c11b99a8e58c0 Maxime Ripard 2021-02-19 109 struct drm_atomic_state *state)
d40af7b1ae23da Russell King 2018-07-30 110 {
7c11b99a8e58c0 Maxime Ripard 2021-02-19 @111 struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
7c11b99a8e58c0 Maxime Ripard 2021-02-19 112 plane);
ba5c1649465d40 Maxime Ripard 2021-02-19 113 struct armada_plane_state *st = to_armada_plane_state(new_plane_state);
ba5c1649465d40 Maxime Ripard 2021-02-19 114 struct drm_crtc *crtc = new_plane_state->crtc;
d40af7b1ae23da Russell King 2018-07-30 115 struct drm_crtc_state *crtc_state;
1d1547ec12bc7d Russell King 2019-01-25 116 bool interlace;
1d1547ec12bc7d Russell King 2019-01-25 117 int ret;
1d1547ec12bc7d Russell King 2019-01-25 118
ba5c1649465d40 Maxime Ripard 2021-02-19 119 if (!new_plane_state->fb || WARN_ON(!new_plane_state->crtc)) {
ba5c1649465d40 Maxime Ripard 2021-02-19 120 new_plane_state->visible = false;
1d1547ec12bc7d Russell King 2019-01-25 121 return 0;
1d1547ec12bc7d Russell King 2019-01-25 122 }
d40af7b1ae23da Russell King 2018-07-30 123
dec92020671c48 Maxime Ripard 2021-02-19 @124 if (state)
dec92020671c48 Maxime Ripard 2021-02-19 125 crtc_state = drm_atomic_get_existing_crtc_state(state,
ba5c1649465d40 Maxime Ripard 2021-02-19 126 crtc);
d40af7b1ae23da Russell King 2018-07-30 127 else
d40af7b1ae23da Russell King 2018-07-30 128 crtc_state = crtc->state;
1d1547ec12bc7d Russell King 2019-01-25 129
ba5c1649465d40 Maxime Ripard 2021-02-19 130 ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state,
ba5c1649465d40 Maxime Ripard 2021-02-19 131 0,
1d1547ec12bc7d Russell King 2019-01-25 132 INT_MAX, true, false);
1d1547ec12bc7d Russell King 2019-01-25 133 if (ret)
1d1547ec12bc7d Russell King 2019-01-25 134 return ret;
1d1547ec12bc7d Russell King 2019-01-25 135
1d1547ec12bc7d Russell King 2019-01-25 136 interlace = crtc_state->adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE;
1d1547ec12bc7d Russell King 2019-01-25 137 if (interlace) {
ba5c1649465d40 Maxime Ripard 2021-02-19 138 if ((new_plane_state->dst.y1 | new_plane_state->dst.y2) & 1)
1d1547ec12bc7d Russell King 2019-01-25 139 return -EINVAL;
ba5c1649465d40 Maxime Ripard 2021-02-19 140 st->src_hw = drm_rect_height(&new_plane_state->src) >> 17;
ba5c1649465d40 Maxime Ripard 2021-02-19 141 st->dst_yx = new_plane_state->dst.y1 >> 1;
ba5c1649465d40 Maxime Ripard 2021-02-19 142 st->dst_hw = drm_rect_height(&new_plane_state->dst) >> 1;
d40af7b1ae23da Russell King 2018-07-30 143 } else {
ba5c1649465d40 Maxime Ripard 2021-02-19 144 st->src_hw = drm_rect_height(&new_plane_state->src) >> 16;
ba5c1649465d40 Maxime Ripard 2021-02-19 145 st->dst_yx = new_plane_state->dst.y1;
ba5c1649465d40 Maxime Ripard 2021-02-19 146 st->dst_hw = drm_rect_height(&new_plane_state->dst);
d40af7b1ae23da Russell King 2018-07-30 147 }
1d1547ec12bc7d Russell King 2019-01-25 148
1d1547ec12bc7d Russell King 2019-01-25 149 st->src_hw <<= 16;
ba5c1649465d40 Maxime Ripard 2021-02-19 150 st->src_hw |= drm_rect_width(&new_plane_state->src) >> 16;
1d1547ec12bc7d Russell King 2019-01-25 151 st->dst_yx <<= 16;
ba5c1649465d40 Maxime Ripard 2021-02-19 152 st->dst_yx |= new_plane_state->dst.x1 & 0x0000ffff;
1d1547ec12bc7d Russell King 2019-01-25 153 st->dst_hw <<= 16;
ba5c1649465d40 Maxime Ripard 2021-02-19 154 st->dst_hw |= drm_rect_width(&new_plane_state->dst) & 0x0000ffff;
1d1547ec12bc7d Russell King 2019-01-25 155
ba5c1649465d40 Maxime Ripard 2021-02-19 156 armada_drm_plane_calc(new_plane_state, st->addrs, st->pitches,
ba5c1649465d40 Maxime Ripard 2021-02-19 157 interlace);
7d62237da6ec07 Russell King 2019-01-25 158 st->interlace = interlace;
7d62237da6ec07 Russell King 2019-01-25 159
d40af7b1ae23da Russell King 2018-07-30 160 return 0;
d40af7b1ae23da Russell King 2018-07-30 161 }
d40af7b1ae23da Russell King 2018-07-30 162
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26263 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)
Date: Sat, 15 May 2021 13:34:47 +0300 [thread overview]
Message-ID: <202105150754.JlFEHPkM-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2924 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 25a1298726e97b9d25379986f5d54d9e62ad6e93
commit: dec92020671c48da231189eb06a5f755f492f87f drm: Use the state pointer directly in planes atomic_check
config: arm-randconfig-m031-20210514 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)
vim +/state +124 drivers/gpu/drm/armada/armada_plane.c
d40af7b1ae23da Russell King 2018-07-30 108 int armada_drm_plane_atomic_check(struct drm_plane *plane,
7c11b99a8e58c0 Maxime Ripard 2021-02-19 109 struct drm_atomic_state *state)
d40af7b1ae23da Russell King 2018-07-30 110 {
7c11b99a8e58c0 Maxime Ripard 2021-02-19 @111 struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
^^^^^
Dereferenced inside the function.
7c11b99a8e58c0 Maxime Ripard 2021-02-19 112 plane);
ba5c1649465d40 Maxime Ripard 2021-02-19 113 struct armada_plane_state *st = to_armada_plane_state(new_plane_state);
ba5c1649465d40 Maxime Ripard 2021-02-19 114 struct drm_crtc *crtc = new_plane_state->crtc;
d40af7b1ae23da Russell King 2018-07-30 115 struct drm_crtc_state *crtc_state;
1d1547ec12bc7d Russell King 2019-01-25 116 bool interlace;
1d1547ec12bc7d Russell King 2019-01-25 117 int ret;
1d1547ec12bc7d Russell King 2019-01-25 118
ba5c1649465d40 Maxime Ripard 2021-02-19 119 if (!new_plane_state->fb || WARN_ON(!new_plane_state->crtc)) {
ba5c1649465d40 Maxime Ripard 2021-02-19 120 new_plane_state->visible = false;
1d1547ec12bc7d Russell King 2019-01-25 121 return 0;
1d1547ec12bc7d Russell King 2019-01-25 122 }
d40af7b1ae23da Russell King 2018-07-30 123
dec92020671c48 Maxime Ripard 2021-02-19 @124 if (state)
^^^^^
Checked too late.
dec92020671c48 Maxime Ripard 2021-02-19 125 crtc_state = drm_atomic_get_existing_crtc_state(state,
ba5c1649465d40 Maxime Ripard 2021-02-19 126 crtc);
d40af7b1ae23da Russell King 2018-07-30 127 else
d40af7b1ae23da Russell King 2018-07-30 128 crtc_state = crtc->state;
1d1547ec12bc7d Russell King 2019-01-25 129
ba5c1649465d40 Maxime Ripard 2021-02-19 130 ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state,
ba5c1649465d40 Maxime Ripard 2021-02-19 131 0,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2021-05-15 10:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 23:53 kernel test robot [this message]
2021-05-15 10:34 ` drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111) Dan Carpenter
2021-05-15 10:34 ` Dan Carpenter
2022-01-18 15:18 Dan Carpenter
2022-01-16 23:46 ` kernel test robot
2022-01-18 15:18 ` Dan Carpenter
2022-02-21 12:37 Dan Carpenter
2022-02-20 21:22 ` kernel test robot
2022-02-21 12:37 ` Dan Carpenter
2022-02-21 15:00 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105150754.JlFEHPkM-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maxime@cerno.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.