From: "hch@lst.de" <hch@lst.de>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>, "hch@lst.de" <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix a possible use of uninitialized variable in remap_io_sg()
Date: Mon, 17 May 2021 14:24:41 +0200 [thread overview]
Message-ID: <20210517122441.GB15150@lst.de> (raw)
In-Reply-To: <ab936e8bb197068f658cb68a5dc1796a7ee73405.camel@intel.com>
On Sat, May 15, 2021 at 12:23:04AM +0000, Souza, Jose wrote:
> On Fri, 2021-05-14 at 07:49 +0200, Christoph Hellwig wrote:
> > On Thu, May 13, 2021 at 04:28:41PM -0700, José Roberto de Souza wrote:
> > > If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first
> > > iteration, err is uninitialized causing a wrong call to zap_vma_ptes().
> >
> > But scatterlist must have at least one valid segment. So while the
> > patch looks ok, please clearly mark that this is a false positive from
> > the static checker in the commit log.
>
> No static checker mentioned but yes it was caught by one.
> Anyways better have this change and avoid possible reports from other static analyzers.
Please also add the information I provided above to put this into
context.
>
> Can I add your Reviewed-by?
With that:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-05-17 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 23:28 [Intel-gfx] [PATCH] drm/i915: Fix a possible use of uninitialized variable in remap_io_sg() José Roberto de Souza
2021-05-14 0:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-05-14 2:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-05-14 5:49 ` [Intel-gfx] [PATCH] " Christoph Hellwig
2021-05-15 0:23 ` Souza, Jose
2021-05-17 12:24 ` hch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517122441.GB15150@lst.de \
--to=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.