drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:2356 esw_offloads_steering_init() warn: missing error code 'err'

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:2356 esw_offloads_steering_init() warn: missing error code 'err'

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5542 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vlad Buslov <vladbu@nvidia.com>
CC: Saeed Mahameed <saeedm@nvidia.com>
CC: Dmytro Linkin <dlinkin@nvidia.com>
CC: Roi Dayan <roid@nvidia.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d07f6ca923ea0927a1024dfccafc5b53b61cfecc
commit: 34ca65352ddf2aaa094f4016369103c4c7b98958 net/mlx5: E-Switch, Indirect table infrastructure
date:   3 months ago
:::::: branch date: 10 hours ago
:::::: commit date: 3 months ago
config: i386-randconfig-m021-20210517 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:2356 esw_offloads_steering_init() warn: missing error code 'err'

Old smatch warnings:
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:1944 esw_offloads_init_reps() warn: potentially one past the end of array 'esw->offloads.vport_reps[vport_index]'
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:1944 esw_offloads_init_reps() warn: potentially one past the end of array 'esw->offloads.vport_reps[vport_index]'
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:2750 mlx5_devlink_eswitch_inline_mode_set() warn: missing error code 'err'

vim +/err +2356 drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c

184867373d8c6bc Eli Britstein 2019-03-04  2343  
062f4bf4aab5c6b Bodong Wang   2019-06-28  2344  static int esw_offloads_steering_init(struct mlx5_eswitch *esw)
6ed1803abe401ec Mark Bloch    2017-08-09  2345  {
34ca65352ddf2aa Vlad Buslov   2021-01-24  2346  	struct mlx5_esw_indir_table *indir;
6ed1803abe401ec Mark Bloch    2017-08-09  2347  	int err;
6ed1803abe401ec Mark Bloch    2017-08-09  2348  
5c1d260ed10cf08 Roi Dayan     2019-03-21  2349  	memset(&esw->fdb_table.offloads, 0, sizeof(struct offloads_fdb));
f8d1eddaf94abdc Parav Pandit  2020-04-21  2350  	mutex_init(&esw->fdb_table.offloads.vports.lock);
f8d1eddaf94abdc Parav Pandit  2020-04-21  2351  	hash_init(esw->fdb_table.offloads.vports.table);
e52c28024008313 Paul Blakey   2018-07-03  2352  
34ca65352ddf2aa Vlad Buslov   2021-01-24  2353  	indir = mlx5_esw_indir_table_init();
34ca65352ddf2aa Vlad Buslov   2021-01-24  2354  	if (IS_ERR(indir)) {
34ca65352ddf2aa Vlad Buslov   2021-01-24  2355  		err = PTR_ERR(indir);
34ca65352ddf2aa Vlad Buslov   2021-01-24 @2356  		goto create_indir_err;
34ca65352ddf2aa Vlad Buslov   2021-01-24  2357  	}
34ca65352ddf2aa Vlad Buslov   2021-01-24  2358  	esw->fdb_table.offloads.indir = indir;
34ca65352ddf2aa Vlad Buslov   2021-01-24  2359  
748da30b376e034 Vu Pham       2019-10-28  2360  	err = esw_create_uplink_offloads_acl_tables(esw);
184867373d8c6bc Eli Britstein 2019-03-04  2361  	if (err)
f8d1eddaf94abdc Parav Pandit  2020-04-21  2362  		goto create_acl_err;
184867373d8c6bc Eli Britstein 2019-03-04  2363  
8d6bd3c339a723f Parav Pandit  2020-07-20  2364  	err = esw_create_offloads_table(esw);
c930a3ad7453615 Or Gerlitz    2016-07-01  2365  	if (err)
11b717d61526996 Paul Blakey   2020-02-16  2366  		goto create_offloads_err;
c930a3ad7453615 Or Gerlitz    2016-07-01  2367  
11b717d61526996 Paul Blakey   2020-02-16  2368  	err = esw_create_restore_table(esw);
11b717d61526996 Paul Blakey   2020-02-16  2369  	if (err)
11b717d61526996 Paul Blakey   2020-02-16  2370  		goto create_restore_err;
11b717d61526996 Paul Blakey   2020-02-16  2371  
0da3c12dd6fc08e Parav Pandit  2020-07-20  2372  	err = esw_create_offloads_fdb_tables(esw);
c930a3ad7453615 Or Gerlitz    2016-07-01  2373  	if (err)
11b717d61526996 Paul Blakey   2020-02-16  2374  		goto create_fdb_err;
c930a3ad7453615 Or Gerlitz    2016-07-01  2375  
8d6bd3c339a723f Parav Pandit  2020-07-20  2376  	err = esw_create_vport_rx_group(esw);
c930a3ad7453615 Or Gerlitz    2016-07-01  2377  	if (err)
c930a3ad7453615 Or Gerlitz    2016-07-01  2378  		goto create_fg_err;
c930a3ad7453615 Or Gerlitz    2016-07-01  2379  
c930a3ad7453615 Or Gerlitz    2016-07-01  2380  	return 0;
c930a3ad7453615 Or Gerlitz    2016-07-01  2381  
c930a3ad7453615 Or Gerlitz    2016-07-01  2382  create_fg_err:
1967ce6ea5c8a03 Or Gerlitz    2017-02-15  2383  	esw_destroy_offloads_fdb_tables(esw);
7445cfb1169cebf Jianbo Liu    2019-06-25  2384  create_fdb_err:
11b717d61526996 Paul Blakey   2020-02-16  2385  	esw_destroy_restore_table(esw);
11b717d61526996 Paul Blakey   2020-02-16  2386  create_restore_err:
11b717d61526996 Paul Blakey   2020-02-16  2387  	esw_destroy_offloads_table(esw);
11b717d61526996 Paul Blakey   2020-02-16  2388  create_offloads_err:
748da30b376e034 Vu Pham       2019-10-28  2389  	esw_destroy_uplink_offloads_acl_tables(esw);
f8d1eddaf94abdc Parav Pandit  2020-04-21  2390  create_acl_err:
34ca65352ddf2aa Vlad Buslov   2021-01-24  2391  	mlx5_esw_indir_table_destroy(esw->fdb_table.offloads.indir);
34ca65352ddf2aa Vlad Buslov   2021-01-24  2392  create_indir_err:
f8d1eddaf94abdc Parav Pandit  2020-04-21  2393  	mutex_destroy(&esw->fdb_table.offloads.vports.lock);
c930a3ad7453615 Or Gerlitz    2016-07-01  2394  	return err;
c930a3ad7453615 Or Gerlitz    2016-07-01  2395  }
c930a3ad7453615 Or Gerlitz    2016-07-01  2396  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32591 bytes --]