From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 3/3] pc-bios/s390-ccw: Add a proper prototype for main()
Date: Mon, 17 May 2021 18:22:32 +0200 [thread overview]
Message-ID: <20210517182232.5ac23867.cohuck@redhat.com> (raw)
In-Reply-To: <20210512171550.476130-4-thuth@redhat.com>
On Wed, 12 May 2021 19:15:50 +0200
Thomas Huth <thuth@redhat.com> wrote:
> Older versions of Clang complain if there is no prototype for main().
> Add one, and while we're at it, make sure that we use the same type
> for main.c and netmain.c - since the return value does not matter,
> declare the return type of main() as "void".
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/main.c | 3 +--
> pc-bios/s390-ccw/s390-ccw.h | 1 +
> 2 files changed, 2 insertions(+), 2 deletions(-)
It's probably not strictly needed for both to have the same prototype,
but this looks sane to me.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2021-05-17 16:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 17:15 [PATCH 0/3] Fix Travis-CI / compiling with older versions of Clang Thomas Huth
2021-05-12 17:15 ` [PATCH 1/3] pc-bios/s390-ccw: Fix inline assembly for " Thomas Huth
2021-05-12 19:52 ` Philippe Mathieu-Daudé
2021-05-17 16:14 ` Cornelia Huck
2021-05-17 16:49 ` Philippe Mathieu-Daudé
2021-05-12 17:15 ` [PATCH 2/3] pc-bios/s390-ccw/Makefile: Check more compiler flags for Clang Thomas Huth
2021-05-12 19:58 ` Philippe Mathieu-Daudé
2021-05-12 17:15 ` [PATCH 3/3] pc-bios/s390-ccw: Add a proper prototype for main() Thomas Huth
2021-05-12 19:54 ` Philippe Mathieu-Daudé
2021-05-14 10:09 ` Thomas Huth
2021-05-17 16:48 ` Philippe Mathieu-Daudé
2021-05-17 16:22 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517182232.5ac23867.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.