From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] pc-bios/s390-ccw/Makefile: Check more compiler flags for Clang
Date: Wed, 12 May 2021 21:58:47 +0200 [thread overview]
Message-ID: <4f82847f-83cc-dea0-e455-b45f69848be2@redhat.com> (raw)
In-Reply-To: <20210512171550.476130-3-thuth@redhat.com>
+Richard
On 5/12/21 7:15 PM, Thomas Huth wrote:
> Older versions of Clang do not like -fno-delete-null-pointer-checks
> or -msoft-float. So let's add a proper check for those.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/Makefile | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> index cee9d2c63b..97008d94c9 100644
> --- a/pc-bios/s390-ccw/Makefile
> +++ b/pc-bios/s390-ccw/Makefile
> @@ -31,10 +31,11 @@ OBJECTS = start.o main.o bootmap.o jump2ipl.o sclp.o menu.o \
>
> QEMU_CFLAGS := -Wall $(filter -W%, $(QEMU_CFLAGS))
> QEMU_CFLAGS += $(call cc-option,-Werror $(QEMU_CFLAGS),-Wno-stringop-overflow)
> -QEMU_CFLAGS += -ffreestanding -fno-delete-null-pointer-checks -fno-common -fPIE
> +QEMU_CFLAGS += -ffreestanding -fno-common -fPIE
OK
> QEMU_CFLAGS += -fwrapv -fno-strict-aliasing -fno-asynchronous-unwind-tables
> -QEMU_CFLAGS += $(call cc-option, $(QEMU_CFLAGS), -fno-stack-protector)
> -QEMU_CFLAGS += -msoft-float
> +QEMU_CFLAGS += $(call cc-option,-Werror $(QEMU_CFLAGS),-fno-delete-null-pointer-checks)
> +QEMU_CFLAGS += $(call cc-option,-Werror $(QEMU_CFLAGS),-fno-stack-protector)
OK
> +QEMU_CFLAGS += $(call cc-option,-Werror $(QEMU_CFLAGS),-msoft-float)
For this one I don't understand clang... How to enforce no floating
point code generation?
> QEMU_CFLAGS += $(call cc-option, $(QEMU_CFLAGS),-march=z900,-march=z10)
> QEMU_CFLAGS += -std=gnu99
> LDFLAGS += -Wl,-pie -nostdlib
>
next prev parent reply other threads:[~2021-05-12 20:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 17:15 [PATCH 0/3] Fix Travis-CI / compiling with older versions of Clang Thomas Huth
2021-05-12 17:15 ` [PATCH 1/3] pc-bios/s390-ccw: Fix inline assembly for " Thomas Huth
2021-05-12 19:52 ` Philippe Mathieu-Daudé
2021-05-17 16:14 ` Cornelia Huck
2021-05-17 16:49 ` Philippe Mathieu-Daudé
2021-05-12 17:15 ` [PATCH 2/3] pc-bios/s390-ccw/Makefile: Check more compiler flags for Clang Thomas Huth
2021-05-12 19:58 ` Philippe Mathieu-Daudé [this message]
2021-05-12 17:15 ` [PATCH 3/3] pc-bios/s390-ccw: Add a proper prototype for main() Thomas Huth
2021-05-12 19:54 ` Philippe Mathieu-Daudé
2021-05-14 10:09 ` Thomas Huth
2021-05-17 16:48 ` Philippe Mathieu-Daudé
2021-05-17 16:22 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f82847f-83cc-dea0-e455-b45f69848be2@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.