All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bnx2fc: Return failure from bnx2fc_eh_abort() since io_req is already in abts processing
@ 2021-05-18 11:19 Javed Hasan
  2021-05-18 15:59 ` Himanshu Madhani
  0 siblings, 1 reply; 4+ messages in thread
From: Javed Hasan @ 2021-05-18 11:19 UTC (permalink / raw)
  To: martin.petersen; +Cc: linux-scsi, GR-QLogic-Storage-Upstream, jhasan


diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
index 1a0dc18d6915..ed300a279a38 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_io.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
@@ -1220,6 +1220,7 @@ int bnx2fc_eh_abort(struct scsi_cmnd *sc_cmd)
 		   was a result from the ABTS request rather than the CLEANUP
 		   request */
 		set_bit(BNX2FC_FLAG_IO_CLEANUP,	&io_req->req_flags);
+		rc = FAILED;
 		goto done;
 	}
 
-- 
2.18.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] bnx2fc: Return failure from bnx2fc_eh_abort() since io_req is already in abts processing
  2021-05-18 11:19 [PATCH] bnx2fc: Return failure from bnx2fc_eh_abort() since io_req is already in abts processing Javed Hasan
@ 2021-05-18 15:59 ` Himanshu Madhani
  0 siblings, 0 replies; 4+ messages in thread
From: Himanshu Madhani @ 2021-05-18 15:59 UTC (permalink / raw)
  To: Javed Hasan, martin.petersen; +Cc: linux-scsi, GR-QLogic-Storage-Upstream



On 5/18/21 6:19 AM, Javed Hasan wrote:
> 
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
> index 1a0dc18d6915..ed300a279a38 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
> @@ -1220,6 +1220,7 @@ int bnx2fc_eh_abort(struct scsi_cmnd *sc_cmd)
>   		   was a result from the ABTS request rather than the CLEANUP
>   		   request */
>   		set_bit(BNX2FC_FLAG_IO_CLEANUP,	&io_req->req_flags);
> +		rc = FAILED;
>   		goto done;
>   	}
>   
> 

Please resend as a git-formatted patch.

-- 
Himanshu Madhani                                Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] bnx2fc: Return failure from bnx2fc_eh_abort() since io_req is already in abts processing
  2021-05-19  6:14 Javed Hasan
@ 2021-05-22  4:40 ` Martin K. Petersen
  0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-05-22  4:40 UTC (permalink / raw)
  To: Javed Hasan; +Cc: Martin K . Petersen, linux-scsi, GR-QLogic-Storage-Upstream

On Tue, 18 May 2021 23:14:16 -0700, Javed Hasan wrote:

>  -Return failure as abts is already in processing.

Applied to 5.13/scsi-fixes, thanks!

[1/1] bnx2fc: Return failure from bnx2fc_eh_abort() since io_req is already in abts processing
      https://git.kernel.org/mkp/scsi/c/122c81c563b0

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] bnx2fc: Return failure from bnx2fc_eh_abort() since io_req is already in abts processing
@ 2021-05-19  6:14 Javed Hasan
  2021-05-22  4:40 ` Martin K. Petersen
  0 siblings, 1 reply; 4+ messages in thread
From: Javed Hasan @ 2021-05-19  6:14 UTC (permalink / raw)
  To: martin.petersen; +Cc: linux-scsi, GR-QLogic-Storage-Upstream, jhasan

 -Return failure as abts is already in processing.

Signed-off-by: Javed Hasan <jhasan@marvell.com>
---
 drivers/scsi/bnx2fc/bnx2fc_io.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
index 1a0dc18d6915..ed300a279a38 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_io.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
@@ -1220,6 +1220,7 @@ int bnx2fc_eh_abort(struct scsi_cmnd *sc_cmd)
 		   was a result from the ABTS request rather than the CLEANUP
 		   request */
 		set_bit(BNX2FC_FLAG_IO_CLEANUP,	&io_req->req_flags);
+		rc = FAILED;
 		goto done;
 	}
 
-- 
2.18.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-22  4:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 11:19 [PATCH] bnx2fc: Return failure from bnx2fc_eh_abort() since io_req is already in abts processing Javed Hasan
2021-05-18 15:59 ` Himanshu Madhani
2021-05-19  6:14 Javed Hasan
2021-05-22  4:40 ` Martin K. Petersen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.