* [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
@ 2021-05-15 20:39 ` Marek Vasut
0 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2021-05-15 20:39 UTC (permalink / raw)
To: dri-devel
Cc: ch, Marek Vasut, Laurent Pinchart, Rob Herring, Sam Ravnborg, devicetree
Add missing spaces to make the diagrams readable, no functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org
To: dri-devel@lists.freedesktop.org
---
.../devicetree/bindings/display/panel/lvds.yaml | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
index 31164608ba1d..06d7ca692d0d 100644
--- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
+++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
@@ -52,9 +52,9 @@ properties:
[VESA] specifications. Data are transferred as follows on 3 LVDS lanes.
Slot 0 1 2 3 4 5 6
- ________________ _________________
+ ________________ _________________
Clock \_______________________/
- ______ ______ ______ ______ ______ ______ ______
+ ______ ______ ______ ______ ______ ______ ______
DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
@@ -63,9 +63,9 @@ properties:
specifications. Data are transferred as follows on 4 LVDS lanes.
Slot 0 1 2 3 4 5 6
- ________________ _________________
+ ________________ _________________
Clock \_______________________/
- ______ ______ ______ ______ ______ ______ ______
+ ______ ______ ______ ______ ______ ______ ______
DATA0 ><__G2__><__R7__><__R6__><__R5__><__R4__><__R3__><__R2__><
DATA1 ><__B3__><__B2__><__G7__><__G6__><__G5__><__G4__><__G3__><
DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B7__><__B6__><__B5__><__B4__><
@@ -75,9 +75,9 @@ properties:
Data are transferred as follows on 4 LVDS lanes.
Slot 0 1 2 3 4 5 6
- ________________ _________________
+ ________________ _________________
Clock \_______________________/
- ______ ______ ______ ______ ______ ______ ______
+ ______ ______ ______ ______ ______ ______ ______
DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
@ 2021-05-15 20:39 ` Marek Vasut
0 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2021-05-15 20:39 UTC (permalink / raw)
To: dri-devel
Cc: Marek Vasut, devicetree, ch, Rob Herring, Laurent Pinchart, Sam Ravnborg
Add missing spaces to make the diagrams readable, no functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org
To: dri-devel@lists.freedesktop.org
---
.../devicetree/bindings/display/panel/lvds.yaml | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
index 31164608ba1d..06d7ca692d0d 100644
--- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
+++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
@@ -52,9 +52,9 @@ properties:
[VESA] specifications. Data are transferred as follows on 3 LVDS lanes.
Slot 0 1 2 3 4 5 6
- ________________ _________________
+ ________________ _________________
Clock \_______________________/
- ______ ______ ______ ______ ______ ______ ______
+ ______ ______ ______ ______ ______ ______ ______
DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
@@ -63,9 +63,9 @@ properties:
specifications. Data are transferred as follows on 4 LVDS lanes.
Slot 0 1 2 3 4 5 6
- ________________ _________________
+ ________________ _________________
Clock \_______________________/
- ______ ______ ______ ______ ______ ______ ______
+ ______ ______ ______ ______ ______ ______ ______
DATA0 ><__G2__><__R7__><__R6__><__R5__><__R4__><__R3__><__R2__><
DATA1 ><__B3__><__B2__><__G7__><__G6__><__G5__><__G4__><__G3__><
DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B7__><__B6__><__B5__><__B4__><
@@ -75,9 +75,9 @@ properties:
Data are transferred as follows on 4 LVDS lanes.
Slot 0 1 2 3 4 5 6
- ________________ _________________
+ ________________ _________________
Clock \_______________________/
- ______ ______ ______ ______ ______ ______ ______
+ ______ ______ ______ ______ ______ ______ ______
DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
2021-05-15 20:39 ` Marek Vasut
@ 2021-05-15 21:48 ` Laurent Pinchart
-1 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2021-05-15 21:48 UTC (permalink / raw)
To: Marek Vasut; +Cc: dri-devel, ch, Rob Herring, Sam Ravnborg, devicetree
Hi Marek,
Thank you for the patch.
On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
> Add missing spaces to make the diagrams readable, no functional change.
Looks better indeed. The patch view looks bad though, because of the
tabs. Maybe you could replace them with spaces, while at it ?
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> .../devicetree/bindings/display/panel/lvds.yaml | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> index 31164608ba1d..06d7ca692d0d 100644
> --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> @@ -52,9 +52,9 @@ properties:
> [VESA] specifications. Data are transferred as follows on 3 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
> DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
> @@ -63,9 +63,9 @@ properties:
> specifications. Data are transferred as follows on 4 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G2__><__R7__><__R6__><__R5__><__R4__><__R3__><__R2__><
> DATA1 ><__B3__><__B2__><__G7__><__G6__><__G5__><__G4__><__G3__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B7__><__B6__><__B5__><__B4__><
> @@ -75,9 +75,9 @@ properties:
> Data are transferred as follows on 4 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
> DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
@ 2021-05-15 21:48 ` Laurent Pinchart
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2021-05-15 21:48 UTC (permalink / raw)
To: Marek Vasut; +Cc: devicetree, Rob Herring, Sam Ravnborg, ch, dri-devel
Hi Marek,
Thank you for the patch.
On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
> Add missing spaces to make the diagrams readable, no functional change.
Looks better indeed. The patch view looks bad though, because of the
tabs. Maybe you could replace them with spaces, while at it ?
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> .../devicetree/bindings/display/panel/lvds.yaml | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> index 31164608ba1d..06d7ca692d0d 100644
> --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> @@ -52,9 +52,9 @@ properties:
> [VESA] specifications. Data are transferred as follows on 3 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
> DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
> @@ -63,9 +63,9 @@ properties:
> specifications. Data are transferred as follows on 4 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G2__><__R7__><__R6__><__R5__><__R4__><__R3__><__R2__><
> DATA1 ><__B3__><__B2__><__G7__><__G6__><__G5__><__G4__><__G3__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B7__><__B6__><__B5__><__B4__><
> @@ -75,9 +75,9 @@ properties:
> Data are transferred as follows on 4 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
> DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
2021-05-15 21:48 ` Laurent Pinchart
@ 2021-05-15 23:49 ` Marek Vasut
-1 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2021-05-15 23:49 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: dri-devel, ch, Rob Herring, Sam Ravnborg, devicetree
On 5/15/21 11:48 PM, Laurent Pinchart wrote:
> Hi Marek,
Hi,
> Thank you for the patch.
>
> On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
>> Add missing spaces to make the diagrams readable, no functional change.
>
> Looks better indeed. The patch view looks bad though, because of the
> tabs. Maybe you could replace them with spaces, while at it ?
It is all spaces, where do you see tabs ?
[...]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
@ 2021-05-15 23:49 ` Marek Vasut
0 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2021-05-15 23:49 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: devicetree, Rob Herring, Sam Ravnborg, ch, dri-devel
On 5/15/21 11:48 PM, Laurent Pinchart wrote:
> Hi Marek,
Hi,
> Thank you for the patch.
>
> On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
>> Add missing spaces to make the diagrams readable, no functional change.
>
> Looks better indeed. The patch view looks bad though, because of the
> tabs. Maybe you could replace them with spaces, while at it ?
It is all spaces, where do you see tabs ?
[...]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
2021-05-15 23:49 ` Marek Vasut
@ 2021-05-16 0:46 ` Laurent Pinchart
-1 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2021-05-16 0:46 UTC (permalink / raw)
To: Marek Vasut; +Cc: dri-devel, ch, Rob Herring, Sam Ravnborg, devicetree
Hi Marek,
On Sun, May 16, 2021 at 01:49:11AM +0200, Marek Vasut wrote:
> On 5/15/21 11:48 PM, Laurent Pinchart wrote:
> > Hi Marek,
>
> Hi,
>
> > Thank you for the patch.
> >
> > On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
> >> Add missing spaces to make the diagrams readable, no functional change.
> >
> > Looks better indeed. The patch view looks bad though, because of the
> > tabs. Maybe you could replace them with spaces, while at it ?
>
> It is all spaces, where do you see tabs ?
Right after "Slot", "Clock" and "DATA[0123]". You're not touching those
lines, but having tabs there messes up the formatting of the patch
itself (the resulting bindings file looks good).
By the way, the subject line doesn't match the patch, you're modifying
panel/lvds.yaml, not bridge/lvds-codec.yaml.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
@ 2021-05-16 0:46 ` Laurent Pinchart
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2021-05-16 0:46 UTC (permalink / raw)
To: Marek Vasut; +Cc: devicetree, Rob Herring, Sam Ravnborg, ch, dri-devel
Hi Marek,
On Sun, May 16, 2021 at 01:49:11AM +0200, Marek Vasut wrote:
> On 5/15/21 11:48 PM, Laurent Pinchart wrote:
> > Hi Marek,
>
> Hi,
>
> > Thank you for the patch.
> >
> > On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
> >> Add missing spaces to make the diagrams readable, no functional change.
> >
> > Looks better indeed. The patch view looks bad though, because of the
> > tabs. Maybe you could replace them with spaces, while at it ?
>
> It is all spaces, where do you see tabs ?
Right after "Slot", "Clock" and "DATA[0123]". You're not touching those
lines, but having tabs there messes up the formatting of the patch
itself (the resulting bindings file looks good).
By the way, the subject line doesn't match the patch, you're modifying
panel/lvds.yaml, not bridge/lvds-codec.yaml.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
2021-05-15 21:48 ` Laurent Pinchart
@ 2021-05-18 12:59 ` Rob Herring
-1 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2021-05-18 12:59 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Marek Vasut, dri-devel, ch, Sam Ravnborg, devicetree
On Sun, May 16, 2021 at 12:48:05AM +0300, Laurent Pinchart wrote:
> Hi Marek,
>
> Thank you for the patch.
>
> On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
> > Add missing spaces to make the diagrams readable, no functional change.
>
> Looks better indeed. The patch view looks bad though, because of the
> tabs. Maybe you could replace them with spaces, while at it ?
It's best to not have tabs in yaml. And if we ever generate any
documentation out of the schema, the tabs would probably cause issues.
Rob
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
@ 2021-05-18 12:59 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2021-05-18 12:59 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Marek Vasut, devicetree, Sam Ravnborg, ch, dri-devel
On Sun, May 16, 2021 at 12:48:05AM +0300, Laurent Pinchart wrote:
> Hi Marek,
>
> Thank you for the patch.
>
> On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
> > Add missing spaces to make the diagrams readable, no functional change.
>
> Looks better indeed. The patch view looks bad though, because of the
> tabs. Maybe you could replace them with spaces, while at it ?
It's best to not have tabs in yaml. And if we ever generate any
documentation out of the schema, the tabs would probably cause issues.
Rob
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-05-18 12:59 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-15 20:39 [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing Marek Vasut
2021-05-15 20:39 ` Marek Vasut
2021-05-15 21:48 ` Laurent Pinchart
2021-05-15 21:48 ` Laurent Pinchart
2021-05-15 23:49 ` Marek Vasut
2021-05-15 23:49 ` Marek Vasut
2021-05-16 0:46 ` Laurent Pinchart
2021-05-16 0:46 ` Laurent Pinchart
2021-05-18 12:59 ` Rob Herring
2021-05-18 12:59 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.