All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH] hmp-commands: expand type of icount to "l" in replay commands
@ 2021-05-18 14:08 Alex Bennée
  2021-05-18 16:28 ` Pavel Dovgalyuk
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Bennée @ 2021-05-18 14:08 UTC (permalink / raw)
  To: qemu-devel; +Cc: Pavel Dovgalyuk, Alex Bennée, Dr. David Alan Gilbert

This is not a 32 bit number, it can (and most likely will) be quite a
big one.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
---
 hmp-commands.hx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 435c591a1c..5ee9cfd520 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1667,7 +1667,7 @@ ERST
 
     {
         .name       = "replay_break",
-        .args_type  = "icount:i",
+        .args_type  = "icount:l",
         .params     = "icount",
         .help       = "set breakpoint at the specified instruction count",
         .cmd        = hmp_replay_break,
@@ -1699,7 +1699,7 @@ ERST
 
     {
         .name       = "replay_seek",
-        .args_type  = "icount:i",
+        .args_type  = "icount:l",
         .params     = "icount",
         .help       = "replay execution to the specified instruction count",
         .cmd        = hmp_replay_seek,
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC PATCH] hmp-commands: expand type of icount to "l" in replay commands
  2021-05-18 14:08 [RFC PATCH] hmp-commands: expand type of icount to "l" in replay commands Alex Bennée
@ 2021-05-18 16:28 ` Pavel Dovgalyuk
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Dovgalyuk @ 2021-05-18 16:28 UTC (permalink / raw)
  To: Alex Bennée, qemu-devel; +Cc: Dr. David Alan Gilbert

On 18.05.2021 17:08, Alex Bennée wrote:
> This is not a 32 bit number, it can (and most likely will) be quite a
> big one.

Thanks, I forgot about it.

> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>

Reviewed-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>

> ---
>   hmp-commands.hx | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 435c591a1c..5ee9cfd520 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1667,7 +1667,7 @@ ERST
>   
>       {
>           .name       = "replay_break",
> -        .args_type  = "icount:i",
> +        .args_type  = "icount:l",
>           .params     = "icount",
>           .help       = "set breakpoint at the specified instruction count",
>           .cmd        = hmp_replay_break,
> @@ -1699,7 +1699,7 @@ ERST
>   
>       {
>           .name       = "replay_seek",
> -        .args_type  = "icount:i",
> +        .args_type  = "icount:l",
>           .params     = "icount",
>           .help       = "replay execution to the specified instruction count",
>           .cmd        = hmp_replay_seek,
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-18 16:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 14:08 [RFC PATCH] hmp-commands: expand type of icount to "l" in replay commands Alex Bennée
2021-05-18 16:28 ` Pavel Dovgalyuk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.