* [PATCH] tools/xenstored: Remove unused parameter in check_domains()
@ 2021-05-18 15:21 Julien Grall
2021-05-18 15:35 ` Juergen Gross
2021-05-18 16:12 ` Luca Fancellu
0 siblings, 2 replies; 5+ messages in thread
From: Julien Grall @ 2021-05-18 15:21 UTC (permalink / raw)
To: xen-devel; +Cc: raphning, Julien Grall, Ian Jackson, Wei Liu, Juergen Gross
From: Julien Grall <jgrall@amazon.com>
The parameter of check_domains() is not used within the function. In fact,
this was a left over of the original implementation as the version merged
doesn't need to know whether we are restoring.
So remove it.
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
tools/xenstore/xenstored_control.c | 2 +-
tools/xenstore/xenstored_domain.c | 4 ++--
tools/xenstore/xenstored_domain.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c
index 8e470f2b2056..07458d7b48d0 100644
--- a/tools/xenstore/xenstored_control.c
+++ b/tools/xenstore/xenstored_control.c
@@ -589,7 +589,7 @@ void lu_read_state(void)
* have died while we were live-updating. So check all the domains are
* still alive.
*/
- check_domains(true);
+ check_domains();
}
static const char *lu_activate_binary(const void *ctx)
diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
index 3d4d0649a243..0e4bae9a9dd6 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -220,7 +220,7 @@ static bool get_domain_info(unsigned int domid, xc_dominfo_t *dominfo)
dominfo->domid == domid;
}
-void check_domains(bool restore)
+void check_domains(void)
{
xc_dominfo_t dominfo;
struct domain *domain;
@@ -277,7 +277,7 @@ void handle_event(void)
barf_perror("Failed to read from event fd");
if (port == virq_port)
- check_domains(false);
+ check_domains();
if (xenevtchn_unmask(xce_handle, port) == -1)
barf_perror("Failed to write to event fd");
diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h
index dc9759171317..cc5147d7e747 100644
--- a/tools/xenstore/xenstored_domain.h
+++ b/tools/xenstore/xenstored_domain.h
@@ -21,7 +21,7 @@
void handle_event(void);
-void check_domains(bool restore);
+void check_domains(void);
/* domid, mfn, eventchn, path */
int do_introduce(struct connection *conn, struct buffered_data *in);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] tools/xenstored: Remove unused parameter in check_domains()
2021-05-18 15:21 [PATCH] tools/xenstored: Remove unused parameter in check_domains() Julien Grall
@ 2021-05-18 15:35 ` Juergen Gross
2021-05-18 16:12 ` Luca Fancellu
1 sibling, 0 replies; 5+ messages in thread
From: Juergen Gross @ 2021-05-18 15:35 UTC (permalink / raw)
To: Julien Grall, xen-devel; +Cc: raphning, Julien Grall, Ian Jackson, Wei Liu
[-- Attachment #1.1.1: Type: text/plain, Size: 428 bytes --]
On 18.05.21 17:21, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The parameter of check_domains() is not used within the function. In fact,
> this was a left over of the original implementation as the version merged
> doesn't need to know whether we are restoring.
>
> So remove it.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 491 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools/xenstored: Remove unused parameter in check_domains()
2021-05-18 15:21 [PATCH] tools/xenstored: Remove unused parameter in check_domains() Julien Grall
2021-05-18 15:35 ` Juergen Gross
@ 2021-05-18 16:12 ` Luca Fancellu
1 sibling, 0 replies; 5+ messages in thread
From: Luca Fancellu @ 2021-05-18 16:12 UTC (permalink / raw)
To: Julien Grall
Cc: xen-devel, raphning, Julien Grall, Ian Jackson, Wei Liu, Juergen Gross
> On 18 May 2021, at 16:21, Julien Grall <julien@xen.org> wrote:
>
> From: Julien Grall <jgrall@amazon.com>
>
> The parameter of check_domains() is not used within the function. In fact,
> this was a left over of the original implementation as the version merged
> doesn't need to know whether we are restoring.
>
> So remove it.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
> tools/xenstore/xenstored_control.c | 2 +-
> tools/xenstore/xenstored_domain.c | 4 ++--
> tools/xenstore/xenstored_domain.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c
> index 8e470f2b2056..07458d7b48d0 100644
> --- a/tools/xenstore/xenstored_control.c
> +++ b/tools/xenstore/xenstored_control.c
> @@ -589,7 +589,7 @@ void lu_read_state(void)
> * have died while we were live-updating. So check all the domains are
> * still alive.
> */
> - check_domains(true);
> + check_domains();
> }
>
> static const char *lu_activate_binary(const void *ctx)
> diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
> index 3d4d0649a243..0e4bae9a9dd6 100644
> --- a/tools/xenstore/xenstored_domain.c
> +++ b/tools/xenstore/xenstored_domain.c
> @@ -220,7 +220,7 @@ static bool get_domain_info(unsigned int domid, xc_dominfo_t *dominfo)
> dominfo->domid == domid;
> }
>
> -void check_domains(bool restore)
> +void check_domains(void)
> {
> xc_dominfo_t dominfo;
> struct domain *domain;
> @@ -277,7 +277,7 @@ void handle_event(void)
> barf_perror("Failed to read from event fd");
>
> if (port == virq_port)
> - check_domains(false);
> + check_domains();
>
> if (xenevtchn_unmask(xce_handle, port) == -1)
> barf_perror("Failed to write to event fd");
> diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h
> index dc9759171317..cc5147d7e747 100644
> --- a/tools/xenstore/xenstored_domain.h
> +++ b/tools/xenstore/xenstored_domain.h
> @@ -21,7 +21,7 @@
>
> void handle_event(void);
>
> -void check_domains(bool restore);
> +void check_domains(void);
>
> /* domid, mfn, eventchn, path */
> int do_introduce(struct connection *conn, struct buffered_data *in);
> --
> 2.17.1
>
>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Cheers,
Luca
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] tools/xenstored: Remove unused parameter in check_domains()
@ 2021-05-18 15:21 Julien Grall
2021-05-18 15:22 ` Julien Grall
0 siblings, 1 reply; 5+ messages in thread
From: Julien Grall @ 2021-05-18 15:21 UTC (permalink / raw)
To: xen-devel; +Cc: raphning, Julien Grall
From: Julien Grall <jgrall@amazon.com>
The parameter of check_domains() is not used within the function. In fact,
this was a left over of the original implementation as the version merged
doesn't need to know whether we are restoring.
So remove it.
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
tools/xenstore/xenstored_control.c | 2 +-
tools/xenstore/xenstored_domain.c | 4 ++--
tools/xenstore/xenstored_domain.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c
index 8e470f2b2056..07458d7b48d0 100644
--- a/tools/xenstore/xenstored_control.c
+++ b/tools/xenstore/xenstored_control.c
@@ -589,7 +589,7 @@ void lu_read_state(void)
* have died while we were live-updating. So check all the domains are
* still alive.
*/
- check_domains(true);
+ check_domains();
}
static const char *lu_activate_binary(const void *ctx)
diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
index 3d4d0649a243..0e4bae9a9dd6 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -220,7 +220,7 @@ static bool get_domain_info(unsigned int domid, xc_dominfo_t *dominfo)
dominfo->domid == domid;
}
-void check_domains(bool restore)
+void check_domains(void)
{
xc_dominfo_t dominfo;
struct domain *domain;
@@ -277,7 +277,7 @@ void handle_event(void)
barf_perror("Failed to read from event fd");
if (port == virq_port)
- check_domains(false);
+ check_domains();
if (xenevtchn_unmask(xce_handle, port) == -1)
barf_perror("Failed to write to event fd");
diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h
index dc9759171317..cc5147d7e747 100644
--- a/tools/xenstore/xenstored_domain.h
+++ b/tools/xenstore/xenstored_domain.h
@@ -21,7 +21,7 @@
void handle_event(void);
-void check_domains(bool restore);
+void check_domains(void);
/* domid, mfn, eventchn, path */
int do_introduce(struct connection *conn, struct buffered_data *in);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] tools/xenstored: Remove unused parameter in check_domains()
2021-05-18 15:21 Julien Grall
@ 2021-05-18 15:22 ` Julien Grall
0 siblings, 0 replies; 5+ messages in thread
From: Julien Grall @ 2021-05-18 15:22 UTC (permalink / raw)
To: xen-devel; +Cc: raphning, Julien Grall
Hi,
Please ignore this patch. I forgot to CC the maintainers. I will resend it.
Sorry for the noise.
Cheers,
On 18/05/2021 16:21, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The parameter of check_domains() is not used within the function. In fact,
> this was a left over of the original implementation as the version merged
> doesn't need to know whether we are restoring.
>
> So remove it.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
> tools/xenstore/xenstored_control.c | 2 +-
> tools/xenstore/xenstored_domain.c | 4 ++--
> tools/xenstore/xenstored_domain.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c
> index 8e470f2b2056..07458d7b48d0 100644
> --- a/tools/xenstore/xenstored_control.c
> +++ b/tools/xenstore/xenstored_control.c
> @@ -589,7 +589,7 @@ void lu_read_state(void)
> * have died while we were live-updating. So check all the domains are
> * still alive.
> */
> - check_domains(true);
> + check_domains();
> }
>
> static const char *lu_activate_binary(const void *ctx)
> diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
> index 3d4d0649a243..0e4bae9a9dd6 100644
> --- a/tools/xenstore/xenstored_domain.c
> +++ b/tools/xenstore/xenstored_domain.c
> @@ -220,7 +220,7 @@ static bool get_domain_info(unsigned int domid, xc_dominfo_t *dominfo)
> dominfo->domid == domid;
> }
>
> -void check_domains(bool restore)
> +void check_domains(void)
> {
> xc_dominfo_t dominfo;
> struct domain *domain;
> @@ -277,7 +277,7 @@ void handle_event(void)
> barf_perror("Failed to read from event fd");
>
> if (port == virq_port)
> - check_domains(false);
> + check_domains();
>
> if (xenevtchn_unmask(xce_handle, port) == -1)
> barf_perror("Failed to write to event fd");
> diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h
> index dc9759171317..cc5147d7e747 100644
> --- a/tools/xenstore/xenstored_domain.h
> +++ b/tools/xenstore/xenstored_domain.h
> @@ -21,7 +21,7 @@
>
> void handle_event(void);
>
> -void check_domains(bool restore);
> +void check_domains(void);
>
> /* domid, mfn, eventchn, path */
> int do_introduce(struct connection *conn, struct buffered_data *in);
>
--
Julien Grall
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-18 16:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 15:21 [PATCH] tools/xenstored: Remove unused parameter in check_domains() Julien Grall
2021-05-18 15:35 ` Juergen Gross
2021-05-18 16:12 ` Luca Fancellu
-- strict thread matches above, loose matches on Subject: below --
2021-05-18 15:21 Julien Grall
2021-05-18 15:22 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.