* [PATCH] platform/x86: toshiba_haps: Fix missing newline in pr_debug call in toshiba_haps_notify
@ 2021-05-19 13:56 Hans de Goede
2021-05-19 13:57 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2021-05-19 13:56 UTC (permalink / raw)
To: Mark Gross, Andy Shevchenko
Cc: Hans de Goede, platform-driver-x86, Salvatore Bonaccorso
The pr_debug() call in toshiba_haps_notify() is missing a newline at the
end of the string, add this.
BugLink: https://bugs.debian.org/799193
Reported-by: Salvatore Bonaccorso <carnil@debian.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/platform/x86/toshiba_haps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_haps.c b/drivers/platform/x86/toshiba_haps.c
index b237bd6b1ee5..49e84095bb01 100644
--- a/drivers/platform/x86/toshiba_haps.c
+++ b/drivers/platform/x86/toshiba_haps.c
@@ -131,7 +131,7 @@ static const struct attribute_group haps_attr_group = {
*/
static void toshiba_haps_notify(struct acpi_device *device, u32 event)
{
- pr_debug("Received event: 0x%x", event);
+ pr_debug("Received event: 0x%x\n", event);
acpi_bus_generate_netlink_event(device->pnp.device_class,
dev_name(&device->dev),
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: toshiba_haps: Fix missing newline in pr_debug call in toshiba_haps_notify
2021-05-19 13:56 [PATCH] platform/x86: toshiba_haps: Fix missing newline in pr_debug call in toshiba_haps_notify Hans de Goede
@ 2021-05-19 13:57 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-05-19 13:57 UTC (permalink / raw)
To: Mark Gross, Andy Shevchenko; +Cc: platform-driver-x86, Salvatore Bonaccorso
Hi,
On 5/19/21 3:56 PM, Hans de Goede wrote:
> The pr_debug() call in toshiba_haps_notify() is missing a newline at the
> end of the string, add this.
>
> BugLink: https://bugs.debian.org/799193
> Reported-by: Salvatore Bonaccorso <carnil@debian.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Since this is trivial I've added it to my review-hans branch right away.
Regards,
Hans
> ---
> drivers/platform/x86/toshiba_haps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/toshiba_haps.c b/drivers/platform/x86/toshiba_haps.c
> index b237bd6b1ee5..49e84095bb01 100644
> --- a/drivers/platform/x86/toshiba_haps.c
> +++ b/drivers/platform/x86/toshiba_haps.c
> @@ -131,7 +131,7 @@ static const struct attribute_group haps_attr_group = {
> */
> static void toshiba_haps_notify(struct acpi_device *device, u32 event)
> {
> - pr_debug("Received event: 0x%x", event);
> + pr_debug("Received event: 0x%x\n", event);
>
> acpi_bus_generate_netlink_event(device->pnp.device_class,
> dev_name(&device->dev),
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-19 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 13:56 [PATCH] platform/x86: toshiba_haps: Fix missing newline in pr_debug call in toshiba_haps_notify Hans de Goede
2021-05-19 13:57 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.