* [Buildroot] [PATCH 1/1] package/flatcc: disable -Werror
@ 2021-05-19 19:41 Fabrice Fontaine
2021-05-19 20:58 ` Yann E. MORIN
2021-05-23 16:03 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-05-19 19:41 UTC (permalink / raw)
To: buildroot
Disable -Werror to fix the following build failure with gcc 11:
/data/buildroot-autobuilder/instance-0/output-1/build/host-flatcc-0.6.0/include/flatcc/reflection/flatbuffers_common_builder.h: In function 'flatbuffers_char_array_copy_from_pe':
/data/buildroot-autobuilder/instance-0/output-1/build/host-flatcc-0.6.0/include/flatcc/reflection/flatbuffers_common_builder.h:341:3: error: this 'for' clause does not guard... [-Werror=misleading-indentation]
341 | for (i = 0; i < n; ++i) N ## _copy_from_pe(&p[i], &p2[i]); return p; }\
| ^~~
An other option would have been to retrieve the following upstream
commit:
https://github.com/dvidelabs/flatcc/commit/f8c4140dd9dde61c86db751f6002def78754fced
but disabling -Werror is more future-proof
Fixes:
- http://autobuild.buildroot.org/results/4d5cdddbfeefdeb943234b76eb08b04376f3c36d
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/flatcc/flatcc.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/flatcc/flatcc.mk b/package/flatcc/flatcc.mk
index c27809b86a..fcace691c0 100644
--- a/package/flatcc/flatcc.mk
+++ b/package/flatcc/flatcc.mk
@@ -10,6 +10,8 @@ FLATCC_LICENSE = Apache-2.0
FLATCC_LICENSE_FILES = LICENSE
FLATCC_INSTALL_STAGING = YES
FLATCC_DEPENDENCIES = host-flatcc
+FLATCC_CONF_OPTS = -DFLATCC_ALLOW_WERROR=OFF
+HOST_FLATCC_CONF_OPTS = -DFLATCC_ALLOW_WERROR=OFF
# Disable build of tests and samples
FLATCC_CONF_OPTS += -DFLATCC_TEST=OFF
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/flatcc: disable -Werror
2021-05-19 19:41 [Buildroot] [PATCH 1/1] package/flatcc: disable -Werror Fabrice Fontaine
@ 2021-05-19 20:58 ` Yann E. MORIN
2021-05-23 16:03 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-05-19 20:58 UTC (permalink / raw)
To: buildroot
Fabrice, All,
On 2021-05-19 21:41 +0200, Fabrice Fontaine spake thusly:
> Disable -Werror to fix the following build failure with gcc 11:
>
> /data/buildroot-autobuilder/instance-0/output-1/build/host-flatcc-0.6.0/include/flatcc/reflection/flatbuffers_common_builder.h: In function 'flatbuffers_char_array_copy_from_pe':
> /data/buildroot-autobuilder/instance-0/output-1/build/host-flatcc-0.6.0/include/flatcc/reflection/flatbuffers_common_builder.h:341:3: error: this 'for' clause does not guard... [-Werror=misleading-indentation]
> 341 | for (i = 0; i < n; ++i) N ## _copy_from_pe(&p[i], &p2[i]); return p; }\
> | ^~~
>
> An other option would have been to retrieve the following upstream
> commit:
> https://github.com/dvidelabs/flatcc/commit/f8c4140dd9dde61c86db751f6002def78754fced
> but disabling -Werror is more future-proof
>
> Fixes:
> - http://autobuild.buildroot.org/results/4d5cdddbfeefdeb943234b76eb08b04376f3c36d
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/flatcc/flatcc.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/flatcc/flatcc.mk b/package/flatcc/flatcc.mk
> index c27809b86a..fcace691c0 100644
> --- a/package/flatcc/flatcc.mk
> +++ b/package/flatcc/flatcc.mk
> @@ -10,6 +10,8 @@ FLATCC_LICENSE = Apache-2.0
> FLATCC_LICENSE_FILES = LICENSE
> FLATCC_INSTALL_STAGING = YES
> FLATCC_DEPENDENCIES = host-flatcc
> +FLATCC_CONF_OPTS = -DFLATCC_ALLOW_WERROR=OFF
> +HOST_FLATCC_CONF_OPTS = -DFLATCC_ALLOW_WERROR=OFF
>
> # Disable build of tests and samples
> FLATCC_CONF_OPTS += -DFLATCC_TEST=OFF
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/flatcc: disable -Werror
2021-05-19 19:41 [Buildroot] [PATCH 1/1] package/flatcc: disable -Werror Fabrice Fontaine
2021-05-19 20:58 ` Yann E. MORIN
@ 2021-05-23 16:03 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-05-23 16:03 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Disable -Werror to fix the following build failure with gcc 11:
> /data/buildroot-autobuilder/instance-0/output-1/build/host-flatcc-0.6.0/include/flatcc/reflection/flatbuffers_common_builder.h: In function 'flatbuffers_char_array_copy_from_pe':
> /data/buildroot-autobuilder/instance-0/output-1/build/host-flatcc-0.6.0/include/flatcc/reflection/flatbuffers_common_builder.h:341:3: error: this 'for' clause does not guard... [-Werror=misleading-indentation]
> 341 | for (i = 0; i < n; ++i) N ## _copy_from_pe(&p[i], &p2[i]); return p; }\
> | ^~~
> An other option would have been to retrieve the following upstream
> commit:
> https://github.com/dvidelabs/flatcc/commit/f8c4140dd9dde61c86db751f6002def78754fced
> but disabling -Werror is more future-proof
> Fixes:
> - http://autobuild.buildroot.org/results/4d5cdddbfeefdeb943234b76eb08b04376f3c36d
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-23 16:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 19:41 [Buildroot] [PATCH 1/1] package/flatcc: disable -Werror Fabrice Fontaine
2021-05-19 20:58 ` Yann E. MORIN
2021-05-23 16:03 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.