[thomash:topic/ttm_branch_v3 14/14] drivers/gpu/drm/i915/gem/i915_gem_ttm.c:569:38: sparse: sparse: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static?

[thomash:topic/ttm_branch_v3 14/14] drivers/gpu/drm/i915/gem/i915_gem_ttm.c:569:38: sparse: sparse: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static?

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]

tree:   git://people.freedesktop.org/~thomash/linux topic/ttm_branch_v3
head:   ed0bde777934916c30fbecb2b351f549eb3a0d0f
commit: ed0bde777934916c30fbecb2b351f549eb3a0d0f [14/14] drm/i915: Use ttm mmap handling for ttm bo's.
config: i386-randconfig-s001-20210520 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        git remote add thomash git://people.freedesktop.org/~thomash/linux
        git fetch --no-tags thomash topic/ttm_branch_v3
        git checkout ed0bde777934916c30fbecb2b351f549eb3a0d0f
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
   drivers/gpu/drm/i915/gem/i915_gem_ttm.c:60:22: sparse: sparse: symbol 'i915_lmem0_placement' was not declared. Should it be static?
   drivers/gpu/drm/i915/gem/i915_gem_ttm.c:67:22: sparse: sparse: symbol 'i915_lmem0_sys_placement' was not declared. Should it be static?
   drivers/gpu/drm/i915/gem/i915_gem_ttm.c:74:22: sparse: sparse: symbol 'i915_sys_placement' was not declared. Should it be static?
>> drivers/gpu/drm/i915/gem/i915_gem_ttm.c:569:38: sparse: sparse: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35028 bytes --]

[RFC PATCH thomash] drm/i915: i915_gem_ttm_obj_ops can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

drivers/gpu/drm/i915/gem/i915_gem_ttm.c:569:38: warning: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static?

Fixes: ed0bde777934 ("drm/i915: Use ttm mmap handling for ttm bo's.")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 i915_gem_ttm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index a94ee2b62fa3a..68fe64401c67f 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -566,7 +566,7 @@ static const struct vm_operations_struct vm_ops_ttm = {
 	.close = i915_gem_mmap_vm_close,
 };
 
-const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = {
+static const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = {
 	.name = "i915_gem_object_ttm",
 	.flags = I915_GEM_OBJECT_HAS_IOMEM,