All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: cs35l33: fix an error code in probe()
@ 2021-05-20  5:08 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-05-20  5:08 UTC (permalink / raw)
  To: James Schulman
  Cc: David Rhodes, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Paul Handrigan, alsa-devel, patches,
	kernel-janitors

This error path returns zero (success) but it should return -EINVAL.

Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 sound/soc/codecs/cs35l33.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c
index 6f6b3c0c88b7..2a6f5e46d031 100644
--- a/sound/soc/codecs/cs35l33.c
+++ b/sound/soc/codecs/cs35l33.c
@@ -1202,6 +1202,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client,
 		dev_err(&i2c_client->dev,
 			"CS35L33 Device ID (%X). Expected ID %X\n",
 			devid, CS35L33_CHIP_ID);
+		ret = -EINVAL;
 		goto err_enable;
 	}
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ASoC: cs35l33: fix an error code in probe()
@ 2021-05-20  5:08 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-05-20  5:08 UTC (permalink / raw)
  To: James Schulman
  Cc: alsa-devel, Liam Girdwood, patches, kernel-janitors,
	Takashi Iwai, Paul Handrigan, Mark Brown, David Rhodes

This error path returns zero (success) but it should return -EINVAL.

Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 sound/soc/codecs/cs35l33.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c
index 6f6b3c0c88b7..2a6f5e46d031 100644
--- a/sound/soc/codecs/cs35l33.c
+++ b/sound/soc/codecs/cs35l33.c
@@ -1202,6 +1202,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client,
 		dev_err(&i2c_client->dev,
 			"CS35L33 Device ID (%X). Expected ID %X\n",
 			devid, CS35L33_CHIP_ID);
+		ret = -EINVAL;
 		goto err_enable;
 	}
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: cs35l33: fix an error code in probe()
  2021-05-20  5:08 ` Dan Carpenter
@ 2021-05-20  9:12   ` Charles Keepax
  -1 siblings, 0 replies; 6+ messages in thread
From: Charles Keepax @ 2021-05-20  9:12 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: James Schulman, David Rhodes, Liam Girdwood, Mark Brown,
	Jaroslav Kysela, Takashi Iwai, Paul Handrigan, alsa-devel,
	patches, kernel-janitors

On Thu, May 20, 2021 at 08:08:24AM +0300, Dan Carpenter wrote:
> This error path returns zero (success) but it should return -EINVAL.
> 
> Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---

Good spot dude, sorry I missed that one in my recent fix ups.

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: cs35l33: fix an error code in probe()
@ 2021-05-20  9:12   ` Charles Keepax
  0 siblings, 0 replies; 6+ messages in thread
From: Charles Keepax @ 2021-05-20  9:12 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: alsa-devel, Liam Girdwood, patches, kernel-janitors,
	Takashi Iwai, Paul Handrigan, Mark Brown, James Schulman,
	David Rhodes

On Thu, May 20, 2021 at 08:08:24AM +0300, Dan Carpenter wrote:
> This error path returns zero (success) but it should return -EINVAL.
> 
> Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---

Good spot dude, sorry I missed that one in my recent fix ups.

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: cs35l33: fix an error code in probe()
  2021-05-20  5:08 ` Dan Carpenter
@ 2021-05-20 21:08   ` Mark Brown
  -1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-05-20 21:08 UTC (permalink / raw)
  To: Dan Carpenter, James Schulman
  Cc: Mark Brown, Paul Handrigan, Liam Girdwood, Takashi Iwai,
	David Rhodes, alsa-devel, kernel-janitors, patches

On Thu, 20 May 2021 08:08:24 +0300, Dan Carpenter wrote:
> This error path returns zero (success) but it should return -EINVAL.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs35l33: fix an error code in probe()
      commit: 833bc4cf9754643acc69b3c6b65988ca78df4460

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: cs35l33: fix an error code in probe()
@ 2021-05-20 21:08   ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-05-20 21:08 UTC (permalink / raw)
  To: Dan Carpenter, James Schulman
  Cc: alsa-devel, patches, Takashi Iwai, kernel-janitors,
	Liam Girdwood, Paul Handrigan, David Rhodes, Mark Brown

On Thu, 20 May 2021 08:08:24 +0300, Dan Carpenter wrote:
> This error path returns zero (success) but it should return -EINVAL.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs35l33: fix an error code in probe()
      commit: 833bc4cf9754643acc69b3c6b65988ca78df4460

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-20 21:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20  5:08 [PATCH] ASoC: cs35l33: fix an error code in probe() Dan Carpenter
2021-05-20  5:08 ` Dan Carpenter
2021-05-20  9:12 ` Charles Keepax
2021-05-20  9:12   ` Charles Keepax
2021-05-20 21:08 ` Mark Brown
2021-05-20 21:08   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.