All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] include/linux/byteorder: fix cpu_to_be32_array()
@ 2021-05-20 15:36 Heinrich Schuchardt
  2021-05-23 19:40 ` Tom Rini
  2022-04-12 16:17 ` Tom Rini
  0 siblings, 2 replies; 5+ messages in thread
From: Heinrich Schuchardt @ 2021-05-20 15:36 UTC (permalink / raw)
  To: u-boot

In cpu_to_be32_array() and be32_to_cpu_array() we should not compare an int
counter to a size_t parameter. Correct the type of the counter.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 include/linux/byteorder/generic.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder/generic.h
index 8fae186d1a..bee0ff6033 100644
--- a/include/linux/byteorder/generic.h
+++ b/include/linux/byteorder/generic.h
@@ -190,7 +190,7 @@ static inline void be64_add_cpu(__be64 *var, u64 val)

 static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)
 {
-	int i;
+	size_t i;

 	for (i = 0; i < len; i++)
 		dst[i] = cpu_to_be32(src[i]);
@@ -198,7 +198,7 @@ static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)

 static inline void be32_to_cpu_array(u32 *dst, const __be32 *src, size_t len)
 {
-	int i;
+	size_t i;

 	for (i = 0; i < len; i++)
 		dst[i] = be32_to_cpu(src[i]);
--
2.31.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] include/linux/byteorder: fix cpu_to_be32_array()
  2021-05-20 15:36 [PATCH] include/linux/byteorder: fix cpu_to_be32_array() Heinrich Schuchardt
@ 2021-05-23 19:40 ` Tom Rini
  2021-05-23 19:54   ` Heinrich Schuchardt
  2022-04-12 16:17 ` Tom Rini
  1 sibling, 1 reply; 5+ messages in thread
From: Tom Rini @ 2021-05-23 19:40 UTC (permalink / raw)
  To: Heinrich Schuchardt; +Cc: u-boot

[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]

On Thu, May 20, 2021 at 05:36:03PM +0200, Heinrich Schuchardt wrote:

> In cpu_to_be32_array() and be32_to_cpu_array() we should not compare an int
> counter to a size_t parameter. Correct the type of the counter.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  include/linux/byteorder/generic.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder/generic.h
> index 8fae186d1a..bee0ff6033 100644
> --- a/include/linux/byteorder/generic.h
> +++ b/include/linux/byteorder/generic.h
> @@ -190,7 +190,7 @@ static inline void be64_add_cpu(__be64 *var, u64 val)
> 
>  static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)
>  {
> -	int i;
> +	size_t i;
> 
>  	for (i = 0; i < len; i++)
>  		dst[i] = cpu_to_be32(src[i]);
> @@ -198,7 +198,7 @@ static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)
> 
>  static inline void be32_to_cpu_array(u32 *dst, const __be32 *src, size_t len)
>  {
> -	int i;
> +	size_t i;
> 
>  	for (i = 0; i < len; i++)
>  		dst[i] = be32_to_cpu(src[i]);

This was fixed in what commit from Linux?  Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] include/linux/byteorder: fix cpu_to_be32_array()
  2021-05-23 19:40 ` Tom Rini
@ 2021-05-23 19:54   ` Heinrich Schuchardt
  2021-11-26 19:44     ` Heinrich Schuchardt
  0 siblings, 1 reply; 5+ messages in thread
From: Heinrich Schuchardt @ 2021-05-23 19:54 UTC (permalink / raw)
  To: Tom Rini; +Cc: u-boot

On 5/23/21 9:40 PM, Tom Rini wrote:
> On Thu, May 20, 2021 at 05:36:03PM +0200, Heinrich Schuchardt wrote:
>
>> In cpu_to_be32_array() and be32_to_cpu_array() we should not compare an int
>> counter to a size_t parameter. Correct the type of the counter.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>   include/linux/byteorder/generic.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder/generic.h
>> index 8fae186d1a..bee0ff6033 100644
>> --- a/include/linux/byteorder/generic.h
>> +++ b/include/linux/byteorder/generic.h
>> @@ -190,7 +190,7 @@ static inline void be64_add_cpu(__be64 *var, u64 val)
>>
>>   static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)
>>   {
>> -	int i;
>> +	size_t i;
>>
>>   	for (i = 0; i < len; i++)
>>   		dst[i] = cpu_to_be32(src[i]);
>> @@ -198,7 +198,7 @@ static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)
>>
>>   static inline void be32_to_cpu_array(u32 *dst, const __be32 *src, size_t len)
>>   {
>> -	int i;
>> +	size_t i;
>>
>>   	for (i = 0; i < len; i++)
>>   		dst[i] = be32_to_cpu(src[i]);
>
> This was fixed in what commit from Linux?  Thanks!
>

include/linux/byteorder/generic.h in Linux is equally broken. This
should not stop you from merging this patch.

I will create a patch for Linux.

Best regards

Heinrich


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] include/linux/byteorder: fix cpu_to_be32_array()
  2021-05-23 19:54   ` Heinrich Schuchardt
@ 2021-11-26 19:44     ` Heinrich Schuchardt
  0 siblings, 0 replies; 5+ messages in thread
From: Heinrich Schuchardt @ 2021-11-26 19:44 UTC (permalink / raw)
  To: Tom Rini; +Cc: u-boot

On 5/23/21 21:54, Heinrich Schuchardt wrote:
> On 5/23/21 9:40 PM, Tom Rini wrote:
<snip />
>>
>> This was fixed in what commit from Linux?  Thanks!
>>
>
> include/linux/byteorder/generic.h in Linux is equally broken. This
> should not stop you from merging this patch.
>
> I will create a patch for Linux.
>
> Best regards
>
> Heinrich
>

Greg Kroah-Hartman will push the correponding patch to Linux Next now:

[PATCH 1/1] include/linux/byteorder/generic.h: fix index variables
https://lore.kernel.org/all/20210523204958.64575-1-xypron.glpk@gmx.de/

Best regards

Heinrich


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] include/linux/byteorder: fix cpu_to_be32_array()
  2021-05-20 15:36 [PATCH] include/linux/byteorder: fix cpu_to_be32_array() Heinrich Schuchardt
  2021-05-23 19:40 ` Tom Rini
@ 2022-04-12 16:17 ` Tom Rini
  1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2022-04-12 16:17 UTC (permalink / raw)
  To: Heinrich Schuchardt; +Cc: u-boot

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

On Thu, May 20, 2021 at 05:36:03PM +0200, Heinrich Schuchardt wrote:

> In cpu_to_be32_array() and be32_to_cpu_array() we should not compare an int
> counter to a size_t parameter. Correct the type of the counter.  This
> exists in upstream as b4c80629c5c9 ("include/linux/byteorder/generic.h:
> fix index variables").
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-12 16:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 15:36 [PATCH] include/linux/byteorder: fix cpu_to_be32_array() Heinrich Schuchardt
2021-05-23 19:40 ` Tom Rini
2021-05-23 19:54   ` Heinrich Schuchardt
2021-11-26 19:44     ` Heinrich Schuchardt
2022-04-12 16:17 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.