[Buildroot] [PATCH 1/1] package/webkitgtk: select missing multimedia deps

[Buildroot] [PATCH 1/1] package/webkitgtk: select missing multimedia deps

[Adrian Perez de Castro]

Select a few missing multimedia related dependencies:

- BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUTODETECT is needed for
  "autoaudiosink"; not having this element can cause a crash as
  it is used unconditionally.
- BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA and
  BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX are needed for
  WebM video playback.

Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
 package/webkitgtk/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
index 4ea931fde1..2ba8d47660 100644
--- a/package/webkitgtk/Config.in
+++ b/package/webkitgtk/Config.in
@@ -98,8 +98,11 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
 	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE
 	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME
 	select BR2_PACKAGE_GST1_PLUGINS_GOOD
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUTODETECT
 	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ISOMP4
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA
 	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_RTSP
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
 	select BR2_PACKAGE_GST1_LIBAV
 	help
 	  This option pulls in all of the required dependencies
-- 
2.31.1

[Buildroot] [PATCH 1/1] package/webkitgtk: select missing multimedia deps

[Yann E. MORIN]

Adrian, All,

On 2021-05-20 00:38 +0300, Adrian Perez de Castro spake thusly:
> Select a few missing multimedia related dependencies:
> 
> - BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUTODETECT is needed for
>   "autoaudiosink"; not having this element can cause a crash as
>   it is used unconditionally.
> - BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA and
>   BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX are needed for
>   WebM video playback.
> 
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

Applied to master, thanks. As I mesed up too, I also accidentally
applied to next...

Regards,
Yann E. MORIN.

> ---
>  package/webkitgtk/Config.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
> index 4ea931fde1..2ba8d47660 100644
> --- a/package/webkitgtk/Config.in
> +++ b/package/webkitgtk/Config.in
> @@ -98,8 +98,11 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUTODETECT
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ISOMP4
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA
>  	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_RTSP
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
>  	select BR2_PACKAGE_GST1_LIBAV
>  	help
>  	  This option pulls in all of the required dependencies
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/webkitgtk: select missing multimedia deps

[Peter Korsgaard]

>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes:

 > Select a few missing multimedia related dependencies:
 > - BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUTODETECT is needed for
 >   "autoaudiosink"; not having this element can cause a crash as
 >   it is used unconditionally.
 > - BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA and
 >   BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX are needed for
 >   WebM video playback.

 > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

Committed to 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard