From: Peter Chen <peter.chen@kernel.org>
To: Sanket Parmar <sparmar@cadence.com>, pawell@cadence.com
Cc: a-govindraju@ti.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kurahul@cadence.com,
gregkh@linuxfoundation.org, kishon@ti.com
Subject: Re: [PATCH] usb: cdns3: Enable TDL_CHK only for OUT ep
Date: Sat, 22 May 2021 18:09:13 +0800 [thread overview]
Message-ID: <20210522100913.GB12415@b29397-desktop> (raw)
In-Reply-To: <1621263912-13175-1-git-send-email-sparmar@cadence.com>
On 21-05-17 17:05:12, Sanket Parmar wrote:
> ZLP gets stuck if TDL_CHK bit is set and TDL_FROM_TRB is used
> as TDL source for IN endpoints. To fix it, TDL_CHK is only
> enabled for OUT endpoints.
>
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> Reported-by: Aswath Govindraju <a-govindraju@ti.com>
> Signed-off-by: Sanket Parmar <sparmar@cadence.com>
> ---
> drivers/usb/cdns3/cdns3-gadget.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
> index 105855a..f3c0276 100644
> --- a/drivers/usb/cdns3/cdns3-gadget.c
> +++ b/drivers/usb/cdns3/cdns3-gadget.c
> @@ -2007,7 +2007,7 @@ static void cdns3_configure_dmult(struct cdns3_device *priv_dev,
> else
> mask = BIT(priv_ep->num);
>
> - if (priv_ep->type != USB_ENDPOINT_XFER_ISOC) {
> + if (priv_ep->type != USB_ENDPOINT_XFER_ISOC && !priv_ep->dir) {
> cdns3_set_register_bit(®s->tdl_from_trb, mask);
> cdns3_set_register_bit(®s->tdl_beh, mask);
> cdns3_set_register_bit(®s->tdl_beh2, mask);
> @@ -2046,15 +2046,13 @@ int cdns3_ep_config(struct cdns3_endpoint *priv_ep, bool enable)
> case USB_ENDPOINT_XFER_INT:
> ep_cfg = EP_CFG_EPTYPE(USB_ENDPOINT_XFER_INT);
>
> - if ((priv_dev->dev_ver == DEV_VER_V2 && !priv_ep->dir) ||
> - priv_dev->dev_ver > DEV_VER_V2)
> + if (priv_dev->dev_ver >= DEV_VER_V2 && !priv_ep->dir)
> ep_cfg |= EP_CFG_TDL_CHK;
> break;
> case USB_ENDPOINT_XFER_BULK:
> ep_cfg = EP_CFG_EPTYPE(USB_ENDPOINT_XFER_BULK);
>
> - if ((priv_dev->dev_ver == DEV_VER_V2 && !priv_ep->dir) ||
> - priv_dev->dev_ver > DEV_VER_V2)
> + if (priv_dev->dev_ver >= DEV_VER_V2 && !priv_ep->dir)
> ep_cfg |= EP_CFG_TDL_CHK;
> break;
> default:
> --
Sanket & Pawel, please confirm this behaviour could apply for DEV_VER_V3,
that is TDL_CHK can't be used for bulk in for DEV_VER_V3?
--
Thanks,
Peter Chen
next prev parent reply other threads:[~2021-05-22 10:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 15:05 [PATCH] usb: cdns3: Enable TDL_CHK only for OUT ep Sanket Parmar
2021-05-22 10:09 ` Peter Chen [this message]
2021-05-24 5:39 ` Sanket Parmar
2021-05-26 15:00 ` Aswath Govindraju
2021-05-27 1:23 ` Peter Chen
2021-06-25 15:20 Sanket Parmar
2021-06-25 15:27 Sanket Parmar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210522100913.GB12415@b29397-desktop \
--to=peter.chen@kernel.org \
--cc=a-govindraju@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=sparmar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.