* [PATCH] Fixed a coding style issue - missing a blank line after declarations
@ 2021-05-22 11:49 tco0427
2021-05-22 12:54 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: tco0427 @ 2021-05-22 11:49 UTC (permalink / raw)
To: gregkh; +Cc: devel, tco0427
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index e1a8f8b47edd..40d99644ddc7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1337,6 +1337,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
static void dynamic_chk_wk_hdl(struct adapter *padapter)
{
struct mlme_priv *pmlmepriv;
+
pmlmepriv = &(padapter->mlmepriv);
if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)
--
2.30.1 (Apple Git-130)
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixed a coding style issue - missing a blank line after declarations
2021-05-22 11:49 [PATCH] Fixed a coding style issue - missing a blank line after declarations tco0427
@ 2021-05-22 12:54 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2021-05-22 12:54 UTC (permalink / raw)
To: tco0427; +Cc: devel
On Sat, May 22, 2021 at 08:49:50PM +0900, tco0427 wrote:
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index e1a8f8b47edd..40d99644ddc7 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1337,6 +1337,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
> static void dynamic_chk_wk_hdl(struct adapter *padapter)
> {
> struct mlme_priv *pmlmepriv;
> +
> pmlmepriv = &(padapter->mlmepriv);
>
> if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)
> --
> 2.30.1 (Apple Git-130)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch does not have a Signed-off-by: line. Please read the
kernel file, Documentation/SubmittingPatches and resend it after
adding that line. Note, the line needs to be in the body of the
email, before the patch, not at the bottom of the patch or in the
email signature.
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file, Documentation/SubmittingPatches
for how to do this correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixed a coding style issue - missing a blank line after declarations
2021-05-23 1:21 Donggyu Kim
@ 2021-05-24 9:12 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-05-24 9:12 UTC (permalink / raw)
To: Donggyu Kim; +Cc: devel, gregkh
On Sun, May 23, 2021 at 10:21:51AM +0900, Donggyu Kim wrote:
> Signed-off-by:Donggyu Kim <a29661498@gmail.com>
The subject needs a subsystem prefix, the subject is too long, and there
is no commit message. Run scripts/checkpatch.pl on your patches.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Fixed a coding style issue - missing a blank line after declarations
@ 2021-05-23 1:21 Donggyu Kim
2021-05-24 9:12 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Donggyu Kim @ 2021-05-23 1:21 UTC (permalink / raw)
To: gregkh; +Cc: devel, Donggyu Kim
Signed-off-by:Donggyu Kim <a29661498@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index e1a8f8b47edd..40d99644ddc7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1337,6 +1337,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
static void dynamic_chk_wk_hdl(struct adapter *padapter)
{
struct mlme_priv *pmlmepriv;
+
pmlmepriv = &(padapter->mlmepriv);
if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)
--
2.30.1 (Apple Git-130)
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] Fixed a coding style issue - missing a blank line after declarations
@ 2021-05-23 1:08 tco0427
0 siblings, 0 replies; 5+ messages in thread
From: tco0427 @ 2021-05-23 1:08 UTC (permalink / raw)
To: gregkh; +Cc: devel, Donggyu Kim
From: Donggyu Kim <a29661498@gmail.com>
Signed-off-by: Donggyu Kim <a29661498@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index e1a8f8b47edd..40d99644ddc7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1337,6 +1337,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
static void dynamic_chk_wk_hdl(struct adapter *padapter)
{
struct mlme_priv *pmlmepriv;
+
pmlmepriv = &(padapter->mlmepriv);
if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)
--
2.30.1 (Apple Git-130)
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-24 9:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22 11:49 [PATCH] Fixed a coding style issue - missing a blank line after declarations tco0427
2021-05-22 12:54 ` Greg KH
2021-05-23 1:08 tco0427
2021-05-23 1:21 Donggyu Kim
2021-05-24 9:12 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.