* [PATCH] ipac: ipoctal: fix kernel-doc syntax and remove filename from file headers
@ 2021-05-22 12:19 ` Aditya Srivastava
0 siblings, 0 replies; 6+ messages in thread
From: Aditya Srivastava @ 2021-05-22 12:19 UTC (permalink / raw)
To: siglesias
Cc: yashsri421, lukas.bulwahn, rdunlap, linux-kernel-mentees,
linux-doc, linux-kernel, jens.taprogge, gregkh,
industrypack-devel
The opening comment mark '/**' is used for highlighting the beginning of
kernel-doc comments.
The header for drivers/ipack/devices/ipoctal follows this syntax, but the
content inside does not comply with kernel-doc.
This line was probably not meant for kernel-doc parsing, but is parsed
due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
causes unexpected warning from kernel-doc.
For e.g., running scripts/kernel-doc -none on
drivers/ipack/devices/ipoctal.h emits:
warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* ipoctal.h
Provide a simple fix by replacing this occurrence with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Also remove the redundant file name from the comment headers.
Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
---
drivers/ipack/devices/ipoctal.c | 4 +---
drivers/ipack/devices/ipoctal.h | 6 ++----
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c
index 3940714e4397..2a3a94f72dfb 100644
--- a/drivers/ipack/devices/ipoctal.c
+++ b/drivers/ipack/devices/ipoctal.c
@@ -1,7 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
-/**
- * ipoctal.c
- *
+/*
* driver for the GE IP-OCTAL boards
*
* Copyright (C) 2009-2012 CERN (www.cern.ch)
diff --git a/drivers/ipack/devices/ipoctal.h b/drivers/ipack/devices/ipoctal.h
index 75f83ba774a4..773dc41bd667 100644
--- a/drivers/ipack/devices/ipoctal.h
+++ b/drivers/ipack/devices/ipoctal.h
@@ -1,9 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-/**
- * ipoctal.h
- *
+/*
* driver for the IPOCTAL boards
-
+ *
* Copyright (C) 2009-2012 CERN (www.cern.ch)
* Author: Nicolas Serafini, EIC2 SA
* Author: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ipac: ipoctal: fix kernel-doc syntax and remove filename from file headers
@ 2021-05-22 12:19 ` Aditya Srivastava
0 siblings, 0 replies; 6+ messages in thread
From: Aditya Srivastava @ 2021-05-22 12:19 UTC (permalink / raw)
To: siglesias
Cc: linux-doc, rdunlap, jens.taprogge, linux-kernel, yashsri421,
industrypack-devel, linux-kernel-mentees
The opening comment mark '/**' is used for highlighting the beginning of
kernel-doc comments.
The header for drivers/ipack/devices/ipoctal follows this syntax, but the
content inside does not comply with kernel-doc.
This line was probably not meant for kernel-doc parsing, but is parsed
due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
causes unexpected warning from kernel-doc.
For e.g., running scripts/kernel-doc -none on
drivers/ipack/devices/ipoctal.h emits:
warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* ipoctal.h
Provide a simple fix by replacing this occurrence with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Also remove the redundant file name from the comment headers.
Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
---
drivers/ipack/devices/ipoctal.c | 4 +---
drivers/ipack/devices/ipoctal.h | 6 ++----
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c
index 3940714e4397..2a3a94f72dfb 100644
--- a/drivers/ipack/devices/ipoctal.c
+++ b/drivers/ipack/devices/ipoctal.c
@@ -1,7 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
-/**
- * ipoctal.c
- *
+/*
* driver for the GE IP-OCTAL boards
*
* Copyright (C) 2009-2012 CERN (www.cern.ch)
diff --git a/drivers/ipack/devices/ipoctal.h b/drivers/ipack/devices/ipoctal.h
index 75f83ba774a4..773dc41bd667 100644
--- a/drivers/ipack/devices/ipoctal.h
+++ b/drivers/ipack/devices/ipoctal.h
@@ -1,9 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-/**
- * ipoctal.h
- *
+/*
* driver for the IPOCTAL boards
-
+ *
* Copyright (C) 2009-2012 CERN (www.cern.ch)
* Author: Nicolas Serafini, EIC2 SA
* Author: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
--
2.17.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ipac: ipoctal: fix kernel-doc syntax and remove filename from file headers
2021-05-22 12:19 ` Aditya Srivastava
@ 2021-05-22 15:10 ` Randy Dunlap
-1 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-05-22 15:10 UTC (permalink / raw)
To: Aditya Srivastava, siglesias
Cc: lukas.bulwahn, linux-kernel-mentees, linux-doc, linux-kernel,
jens.taprogge, gregkh, industrypack-devel
On 5/22/21 5:19 AM, Aditya Srivastava wrote:
> The opening comment mark '/**' is used for highlighting the beginning of
> kernel-doc comments.
> The header for drivers/ipack/devices/ipoctal follows this syntax, but the
> content inside does not comply with kernel-doc.
>
> This line was probably not meant for kernel-doc parsing, but is parsed
> due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
> causes unexpected warning from kernel-doc.
>
> For e.g., running scripts/kernel-doc -none on
> drivers/ipack/devices/ipoctal.h emits:
> warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * ipoctal.h
>
> Provide a simple fix by replacing this occurrence with general comment
> format, i.e. '/*', to prevent kernel-doc from parsing it.
>
> Also remove the redundant file name from the comment headers.
>
> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/ipack/devices/ipoctal.c | 4 +---
> drivers/ipack/devices/ipoctal.h | 6 ++----
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c
> index 3940714e4397..2a3a94f72dfb 100644
> --- a/drivers/ipack/devices/ipoctal.c
> +++ b/drivers/ipack/devices/ipoctal.c
> @@ -1,7 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/**
> - * ipoctal.c
> - *
> +/*
> * driver for the GE IP-OCTAL boards
> *
> * Copyright (C) 2009-2012 CERN (www.cern.ch)
> diff --git a/drivers/ipack/devices/ipoctal.h b/drivers/ipack/devices/ipoctal.h
> index 75f83ba774a4..773dc41bd667 100644
> --- a/drivers/ipack/devices/ipoctal.h
> +++ b/drivers/ipack/devices/ipoctal.h
> @@ -1,9 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> -/**
> - * ipoctal.h
> - *
> +/*
> * driver for the IPOCTAL boards
> -
> + *
> * Copyright (C) 2009-2012 CERN (www.cern.ch)
> * Author: Nicolas Serafini, EIC2 SA
> * Author: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
>
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ipac: ipoctal: fix kernel-doc syntax and remove filename from file headers
@ 2021-05-22 15:10 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-05-22 15:10 UTC (permalink / raw)
To: Aditya Srivastava, siglesias
Cc: linux-doc, jens.taprogge, linux-kernel, industrypack-devel,
linux-kernel-mentees
On 5/22/21 5:19 AM, Aditya Srivastava wrote:
> The opening comment mark '/**' is used for highlighting the beginning of
> kernel-doc comments.
> The header for drivers/ipack/devices/ipoctal follows this syntax, but the
> content inside does not comply with kernel-doc.
>
> This line was probably not meant for kernel-doc parsing, but is parsed
> due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
> causes unexpected warning from kernel-doc.
>
> For e.g., running scripts/kernel-doc -none on
> drivers/ipack/devices/ipoctal.h emits:
> warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * ipoctal.h
>
> Provide a simple fix by replacing this occurrence with general comment
> format, i.e. '/*', to prevent kernel-doc from parsing it.
>
> Also remove the redundant file name from the comment headers.
>
> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/ipack/devices/ipoctal.c | 4 +---
> drivers/ipack/devices/ipoctal.h | 6 ++----
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c
> index 3940714e4397..2a3a94f72dfb 100644
> --- a/drivers/ipack/devices/ipoctal.c
> +++ b/drivers/ipack/devices/ipoctal.c
> @@ -1,7 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/**
> - * ipoctal.c
> - *
> +/*
> * driver for the GE IP-OCTAL boards
> *
> * Copyright (C) 2009-2012 CERN (www.cern.ch)
> diff --git a/drivers/ipack/devices/ipoctal.h b/drivers/ipack/devices/ipoctal.h
> index 75f83ba774a4..773dc41bd667 100644
> --- a/drivers/ipack/devices/ipoctal.h
> +++ b/drivers/ipack/devices/ipoctal.h
> @@ -1,9 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> -/**
> - * ipoctal.h
> - *
> +/*
> * driver for the IPOCTAL boards
> -
> + *
> * Copyright (C) 2009-2012 CERN (www.cern.ch)
> * Author: Nicolas Serafini, EIC2 SA
> * Author: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
>
--
~Randy
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ipac: ipoctal: fix kernel-doc syntax and remove filename from file headers
2021-05-22 12:19 ` Aditya Srivastava
@ 2021-05-26 10:05 ` Samuel Iglesias Gonsálvez
-1 siblings, 0 replies; 6+ messages in thread
From: Samuel Iglesias Gonsálvez @ 2021-05-26 10:05 UTC (permalink / raw)
To: Aditya Srivastava
Cc: lukas.bulwahn, rdunlap, linux-kernel-mentees, linux-doc,
linux-kernel, jens.taprogge, gregkh, industrypack-devel
[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]
Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Thanks,
Sam
On Sat, 2021-05-22 at 17:49 +0530, Aditya Srivastava wrote:
> The opening comment mark '/**' is used for highlighting the beginning
> of
> kernel-doc comments.
> The header for drivers/ipack/devices/ipoctal follows this syntax, but
> the
> content inside does not comply with kernel-doc.
>
> This line was probably not meant for kernel-doc parsing, but is
> parsed
> due to the presence of kernel-doc like comment syntax(i.e, '/**'),
> which
> causes unexpected warning from kernel-doc.
>
> For e.g., running scripts/kernel-doc -none on
> drivers/ipack/devices/ipoctal.h emits:
> warning: This comment starts with '/**', but isn't a kernel-doc
> comment. Refer Documentation/doc-guide/kernel-doc.rst
> * ipoctal.h
>
> Provide a simple fix by replacing this occurrence with general
> comment
> format, i.e. '/*', to prevent kernel-doc from parsing it.
>
> Also remove the redundant file name from the comment headers.
>
> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
> ---
> drivers/ipack/devices/ipoctal.c | 4 +---
> drivers/ipack/devices/ipoctal.h | 6 ++----
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/ipack/devices/ipoctal.c
> b/drivers/ipack/devices/ipoctal.c
> index 3940714e4397..2a3a94f72dfb 100644
> --- a/drivers/ipack/devices/ipoctal.c
> +++ b/drivers/ipack/devices/ipoctal.c
> @@ -1,7 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/**
> - * ipoctal.c
> - *
> +/*
> * driver for the GE IP-OCTAL boards
> *
> * Copyright (C) 2009-2012 CERN (www.cern.ch)
> diff --git a/drivers/ipack/devices/ipoctal.h
> b/drivers/ipack/devices/ipoctal.h
> index 75f83ba774a4..773dc41bd667 100644
> --- a/drivers/ipack/devices/ipoctal.h
> +++ b/drivers/ipack/devices/ipoctal.h
> @@ -1,9 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> -/**
> - * ipoctal.h
> - *
> +/*
> * driver for the IPOCTAL boards
> -
> + *
> * Copyright (C) 2009-2012 CERN (www.cern.ch)
> * Author: Nicolas Serafini, EIC2 SA
> * Author: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ipac: ipoctal: fix kernel-doc syntax and remove filename from file headers
@ 2021-05-26 10:05 ` Samuel Iglesias Gonsálvez
0 siblings, 0 replies; 6+ messages in thread
From: Samuel Iglesias Gonsálvez @ 2021-05-26 10:05 UTC (permalink / raw)
To: Aditya Srivastava
Cc: linux-doc, rdunlap, jens.taprogge, linux-kernel,
industrypack-devel, linux-kernel-mentees
[-- Attachment #1.1: Type: text/plain, Size: 2192 bytes --]
Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Thanks,
Sam
On Sat, 2021-05-22 at 17:49 +0530, Aditya Srivastava wrote:
> The opening comment mark '/**' is used for highlighting the beginning
> of
> kernel-doc comments.
> The header for drivers/ipack/devices/ipoctal follows this syntax, but
> the
> content inside does not comply with kernel-doc.
>
> This line was probably not meant for kernel-doc parsing, but is
> parsed
> due to the presence of kernel-doc like comment syntax(i.e, '/**'),
> which
> causes unexpected warning from kernel-doc.
>
> For e.g., running scripts/kernel-doc -none on
> drivers/ipack/devices/ipoctal.h emits:
> warning: This comment starts with '/**', but isn't a kernel-doc
> comment. Refer Documentation/doc-guide/kernel-doc.rst
> * ipoctal.h
>
> Provide a simple fix by replacing this occurrence with general
> comment
> format, i.e. '/*', to prevent kernel-doc from parsing it.
>
> Also remove the redundant file name from the comment headers.
>
> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
> ---
> drivers/ipack/devices/ipoctal.c | 4 +---
> drivers/ipack/devices/ipoctal.h | 6 ++----
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/ipack/devices/ipoctal.c
> b/drivers/ipack/devices/ipoctal.c
> index 3940714e4397..2a3a94f72dfb 100644
> --- a/drivers/ipack/devices/ipoctal.c
> +++ b/drivers/ipack/devices/ipoctal.c
> @@ -1,7 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/**
> - * ipoctal.c
> - *
> +/*
> * driver for the GE IP-OCTAL boards
> *
> * Copyright (C) 2009-2012 CERN (www.cern.ch)
> diff --git a/drivers/ipack/devices/ipoctal.h
> b/drivers/ipack/devices/ipoctal.h
> index 75f83ba774a4..773dc41bd667 100644
> --- a/drivers/ipack/devices/ipoctal.h
> +++ b/drivers/ipack/devices/ipoctal.h
> @@ -1,9 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> -/**
> - * ipoctal.h
> - *
> +/*
> * driver for the IPOCTAL boards
> -
> + *
> * Copyright (C) 2009-2012 CERN (www.cern.ch)
> * Author: Nicolas Serafini, EIC2 SA
> * Author: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-26 10:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22 12:19 [PATCH] ipac: ipoctal: fix kernel-doc syntax and remove filename from file headers Aditya Srivastava
2021-05-22 12:19 ` Aditya Srivastava
2021-05-22 15:10 ` Randy Dunlap
2021-05-22 15:10 ` Randy Dunlap
2021-05-26 10:05 ` Samuel Iglesias Gonsálvez
2021-05-26 10:05 ` Samuel Iglesias Gonsálvez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.