[PATCH RESEND 1/2] USB: serial: omninet: Adding Zyxel Omni 56K Plus

[PATCH RESEND 1/2] USB: serial: omninet: Adding Zyxel Omni 56K Plus

[Alexandre GRIVEAUX]

Adding Zyxel Omni 56K Plus modem, this modem include:

USB chip:
NetChip
NET2888

Main chip:
901041A
F721501APGF

Another modem using the same chips is the Zyxel Omni 56K DUO/NEO,
could be added with the right USB ID.

Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
---
 drivers/usb/serial/omninet.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
index 83c62f920c50..8be91f5a4dd7 100644
--- a/drivers/usb/serial/omninet.c
+++ b/drivers/usb/serial/omninet.c
@@ -26,6 +26,7 @@
 
 #define ZYXEL_VENDOR_ID		0x0586
 #define ZYXEL_OMNINET_ID	0x1000
+#define ZYXEL_OMNI_56K_PLUS_ID	0x1500
 /* This one seems to be a re-branded ZyXEL device */
 #define BT_IGNITIONPRO_ID	0x2000
 
@@ -41,6 +42,7 @@ static void omninet_port_remove(struct usb_serial_port *port);
 static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(ZYXEL_VENDOR_ID, ZYXEL_OMNINET_ID) },
 	{ USB_DEVICE(ZYXEL_VENDOR_ID, BT_IGNITIONPRO_ID) },
+	{ USB_DEVICE(ZYXEL_VENDOR_ID, ZYXEL_OMNI_56K_PLUS_ID) },
 	{ }						/* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, id_table);
-- 
2.20.1

[PATCH RESEND 2/2] USB: serial: omninet: Renaming driver to Zyxel omni.net

[Alexandre GRIVEAUX]

With the inclusion of Omni 56K Plus, this driver seem to be more common
among the family of Zyxel omni modem.

Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
---
 drivers/usb/serial/omninet.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
index 8be91f5a4dd7..79c0dab46ae8 100644
--- a/drivers/usb/serial/omninet.c
+++ b/drivers/usb/serial/omninet.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * USB ZyXEL omni.net LCD PLUS driver
+ * USB ZyXEL omni.net driver
  *
  * Copyright (C) 2013,2017 Johan Hovold <johan@kernel.org>
  *
@@ -22,7 +22,7 @@
 #include <linux/usb/serial.h>
 
 #define DRIVER_AUTHOR "Alessandro Zummo"
-#define DRIVER_DESC "USB ZyXEL omni.net LCD PLUS Driver"
+#define DRIVER_DESC "USB ZyXEL omni.net Driver"
 
 #define ZYXEL_VENDOR_ID		0x0586
 #define ZYXEL_OMNINET_ID	0x1000
@@ -52,7 +52,7 @@ static struct usb_serial_driver zyxel_omninet_device = {
 		.owner =	THIS_MODULE,
 		.name =		"omninet",
 	},
-	.description =		"ZyXEL - omni.net lcd plus usb",
+	.description =		"ZyXEL - omni.net usb",
 	.id_table =		id_table,
 	.num_bulk_out =		2,
 	.calc_num_ports =	omninet_calc_num_ports,
-- 
2.20.1

Re: [PATCH RESEND 1/2] USB: serial: omninet: Adding Zyxel Omni 56K Plus

[Johan Hovold]

On Sun, May 23, 2021 at 06:35:21PM +0200, Alexandre GRIVEAUX wrote:
> Adding Zyxel Omni 56K Plus modem, this modem include:

Nit: In the future, try to use imperative mood in your commit messages
(i.e. use "add" rather than "adding").

Also, why is there a RESEND prefix in the subject? This is the first
time I see this patch.

> USB chip:
> NetChip
> NET2888
> 
> Main chip:
> 901041A
> F721501APGF
> 
> Another modem using the same chips is the Zyxel Omni 56K DUO/NEO,
> could be added with the right USB ID.
> 
> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> ---
>  drivers/usb/serial/omninet.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
> index 83c62f920c50..8be91f5a4dd7 100644
> --- a/drivers/usb/serial/omninet.c
> +++ b/drivers/usb/serial/omninet.c
> @@ -26,6 +26,7 @@
>  
>  #define ZYXEL_VENDOR_ID		0x0586
>  #define ZYXEL_OMNINET_ID	0x1000
> +#define ZYXEL_OMNI_56K_PLUS_ID	0x1500
>  /* This one seems to be a re-branded ZyXEL device */
>  #define BT_IGNITIONPRO_ID	0x2000
>  
> @@ -41,6 +42,7 @@ static void omninet_port_remove(struct usb_serial_port *port);
>  static const struct usb_device_id id_table[] = {
>  	{ USB_DEVICE(ZYXEL_VENDOR_ID, ZYXEL_OMNINET_ID) },
>  	{ USB_DEVICE(ZYXEL_VENDOR_ID, BT_IGNITIONPRO_ID) },
> +	{ USB_DEVICE(ZYXEL_VENDOR_ID, ZYXEL_OMNI_56K_PLUS_ID) },
>  	{ }						/* Terminating entry */
>  };
>  MODULE_DEVICE_TABLE(usb, id_table);

Now applied with a slightly modified commit message. Thanks.

Johan

Re: [PATCH RESEND 2/2] USB: serial: omninet: Renaming driver to Zyxel omni.net

[Johan Hovold]

On Sun, May 23, 2021 at 06:35:22PM +0200, Alexandre GRIVEAUX wrote:
> With the inclusion of Omni 56K Plus, this driver seem to be more common
> among the family of Zyxel omni modem.

I amended the commit message to make it more clear that you're updating
the driver and module descriptions and not really renaming the driver.

> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> ---
>  drivers/usb/serial/omninet.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
> index 8be91f5a4dd7..79c0dab46ae8 100644
> --- a/drivers/usb/serial/omninet.c
> +++ b/drivers/usb/serial/omninet.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * USB ZyXEL omni.net LCD PLUS driver
> + * USB ZyXEL omni.net driver
>   *
>   * Copyright (C) 2013,2017 Johan Hovold <johan@kernel.org>
>   *
> @@ -22,7 +22,7 @@
>  #include <linux/usb/serial.h>
>  
>  #define DRIVER_AUTHOR "Alessandro Zummo"
> -#define DRIVER_DESC "USB ZyXEL omni.net LCD PLUS Driver"
> +#define DRIVER_DESC "USB ZyXEL omni.net Driver"
>  
>  #define ZYXEL_VENDOR_ID		0x0586
>  #define ZYXEL_OMNINET_ID	0x1000
> @@ -52,7 +52,7 @@ static struct usb_serial_driver zyxel_omninet_device = {
>  		.owner =	THIS_MODULE,
>  		.name =		"omninet",
>  	},
> -	.description =		"ZyXEL - omni.net lcd plus usb",
> +	.description =		"ZyXEL - omni.net usb",
>  	.id_table =		id_table,
>  	.num_bulk_out =		2,
>  	.calc_num_ports =	omninet_calc_num_ports,

Now applied.

Johan

Re: [PATCH RESEND 1/2] USB: serial: omninet: Adding Zyxel Omni 56K Plus

[Alexandre GRIVEAUX]

On Tue, May 25, 2021 at 09:01:44AM +0200, Johan Hovold wrote:
> On Sun, May 23, 2021 at 06:35:21PM +0200, Alexandre GRIVEAUX wrote:
> > Adding Zyxel Omni 56K Plus modem, this modem include:
> 
> Nit: In the future, try to use imperative mood in your commit messages
> (i.e. use "add" rather than "adding").
> 
Hello,

Ok.

> Also, why is there a RESEND prefix in the subject? This is the first
> time I see this patch.

For the RESEND, I have a residual mailname file with
"localhost.localdomain" inside, i've checked log, some address received
messages, so i've changed the subject prefix to "resend". sorry for
that.

Thanks.

> 
> > USB chip:
> > NetChip
> > NET2888
> > 
> > Main chip:
> > 901041A
> > F721501APGF
> > 
> > Another modem using the same chips is the Zyxel Omni 56K DUO/NEO,
> > could be added with the right USB ID.
> > 
> > Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> > ---
> >  drivers/usb/serial/omninet.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
> > index 83c62f920c50..8be91f5a4dd7 100644
> > --- a/drivers/usb/serial/omninet.c
> > +++ b/drivers/usb/serial/omninet.c
> > @@ -26,6 +26,7 @@
> >  
> >  #define ZYXEL_VENDOR_ID		0x0586
> >  #define ZYXEL_OMNINET_ID	0x1000
> > +#define ZYXEL_OMNI_56K_PLUS_ID	0x1500
> >  /* This one seems to be a re-branded ZyXEL device */
> >  #define BT_IGNITIONPRO_ID	0x2000
> >  
> > @@ -41,6 +42,7 @@ static void omninet_port_remove(struct usb_serial_port *port);
> >  static const struct usb_device_id id_table[] = {
> >  	{ USB_DEVICE(ZYXEL_VENDOR_ID, ZYXEL_OMNINET_ID) },
> >  	{ USB_DEVICE(ZYXEL_VENDOR_ID, BT_IGNITIONPRO_ID) },
> > +	{ USB_DEVICE(ZYXEL_VENDOR_ID, ZYXEL_OMNI_56K_PLUS_ID) },
> >  	{ }						/* Terminating entry */
> >  };
> >  MODULE_DEVICE_TABLE(usb, id_table);
> 
> Now applied with a slightly modified commit message. Thanks.
> 
> Johan

Re: [PATCH RESEND 1/2] USB: serial: omninet: Adding Zyxel Omni 56K Plus

[Johan Hovold]

On Tue, May 25, 2021 at 11:25:34AM +0200, Alexandre GRIVEAUX wrote:
> On Tue, May 25, 2021 at 09:01:44AM +0200, Johan Hovold wrote:
> > On Sun, May 23, 2021 at 06:35:21PM +0200, Alexandre GRIVEAUX wrote:
> > > Adding Zyxel Omni 56K Plus modem, this modem include:

> > Also, why is there a RESEND prefix in the subject? This is the first
> > time I see this patch.
> 
> For the RESEND, I have a residual mailname file with
> "localhost.localdomain" inside, i've checked log, some address received
> messages, so i've changed the subject prefix to "resend". sorry for
> that.

Ah, ok, no worries at all. Just thought I may had missed the first
submission.

Johan