* [virtio-comment] [PATCH v6 1/2] virtio-vsock: use C style defines for constants
2021-05-24 18:32 [virtio-comment] [PATCH v6 0/2] virtio-vsock: introduce SOCK_SEQPACKET description Arseny Krasnov
@ 2021-05-24 18:33 ` Arseny Krasnov
2021-06-18 14:47 ` [virtio-comment] " Stefano Garzarella
2021-05-24 18:34 ` [virtio-comment] [PATCH v6 2/2] virtio-vsock: SOCK_SEQPACKET description Arseny Krasnov
2021-05-27 13:15 ` Stefano Garzarella
2 siblings, 1 reply; 10+ messages in thread
From: Arseny Krasnov @ 2021-05-24 18:33 UTC (permalink / raw)
To: cohuck, virtio-comment, Stefan Hajnoczi, Stefano Garzarella,
Michael S. Tsirkin, Jason Wang, David S. Miller, Jakub Kicinski,
Arseny Krasnov, Jorgen Hansen, Norbert Slusarek, Colin Ian King,
Andra Paraschiv
Cc: virtualization, oxffffaa
This:
1) Replaces enums with C style "defines", because
use of enums is not documented, while "defines"
are widely used in spec.
2) Adds defines for some constants.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
---
virtio-vsock.tex | 54 +++++++++++++++++++++++++-----------------------
1 file changed, 28 insertions(+), 26 deletions(-)
diff --git a/virtio-vsock.tex b/virtio-vsock.tex
index da7e641..ad57f9d 100644
--- a/virtio-vsock.tex
+++ b/virtio-vsock.tex
@@ -86,23 +86,18 @@ \subsection{Device Operation}\label{sec:Device Types / Socket Device / Device Op
operation constants:
\begin{lstlisting}
-enum {
- VIRTIO_VSOCK_OP_INVALID = 0,
-
- /* Connect operations */
- VIRTIO_VSOCK_OP_REQUEST = 1,
- VIRTIO_VSOCK_OP_RESPONSE = 2,
- VIRTIO_VSOCK_OP_RST = 3,
- VIRTIO_VSOCK_OP_SHUTDOWN = 4,
-
- /* To send payload */
- VIRTIO_VSOCK_OP_RW = 5,
-
- /* Tell the peer our credit info */
- VIRTIO_VSOCK_OP_CREDIT_UPDATE = 6,
- /* Request the peer to send the credit info to us */
- VIRTIO_VSOCK_OP_CREDIT_REQUEST = 7,
-};
+#define VIRTIO_VSOCK_OP_INVALID 0
+/* Connect operations */
+#define VIRTIO_VSOCK_OP_REQUEST 1
+#define VIRTIO_VSOCK_OP_RESPONSE 2
+#define VIRTIO_VSOCK_OP_RST 3
+#define VIRTIO_VSOCK_OP_SHUTDOWN 4
+/* To send payload */
+#define VIRTIO_VSOCK_OP_RW 5
+/* Tell the peer our credit info */
+#define VIRTIO_VSOCK_OP_CREDIT_UPDATE 6
+/* Request the peer to send the credit info to us */
+#define VIRTIO_VSOCK_OP_CREDIT_REQUEST 7
\end{lstlisting}
\subsubsection{Virtqueue Flow Control}\label{sec:Device Types / Socket Device / Device Operation / Virtqueue Flow Control}
@@ -140,8 +135,12 @@ \subsubsection{Addressing}\label{sec:Device Types / Socket Device / Device Opera
consists of a (cid, port number) tuple. The header fields used for this are
\field{src_cid}, \field{src_port}, \field{dst_cid}, and \field{dst_port}.
-Currently only stream sockets are supported. \field{type} is 1 for stream
-socket types.
+Currently only stream sockets are supported. \field{type} is 1 (VIRTIO_VSOCK_TYPE_STREAM)
+for stream socket types.
+
+\begin{lstlisting}
+#define VIRTIO_VSOCK_TYPE_STREAM 1
+\end{lstlisting}
Stream sockets provide in-order, guaranteed, connection-oriented delivery
without message boundaries.
@@ -222,10 +221,15 @@ \subsubsection{Stream Sockets}\label{sec:Device Types / Socket Device / Device O
insufficient resources to establish the connection.
When a connected socket receives VIRTIO_VSOCK_OP_SHUTDOWN the header
-\field{flags} field bit 0 indicates that the peer will not receive any more
-data and bit 1 indicates that the peer will not send any more data. These
-hints are permanent once sent and successive packets with bits clear do not
-reset them.
+\field{flags} field bit VIRTIO_VSOCK_SHUTDOWN_F_RECEIVE (bit 0) set indicates
+that the peer will not receive any more data and bit VIRTIO_VSOCK_SHUTDOWN_F_SEND
+(bit 1) set indicates that the peer will not send any more data. These hints are
+permanent once sent and successive packets with bits clear do not reset them.
+
+\begin{lstlisting}
+#define VIRTIO_VSOCK_SHUTDOWN_F_RECEIVE 0
+#define VIRTIO_VSOCK_SHUTDOWN_F_SEND 1
+\end{lstlisting}
The VIRTIO_VSOCK_OP_RST packet aborts the connection process or forcibly
disconnects a connected socket.
@@ -248,9 +252,7 @@ \subsubsection{Device Events}\label{sec:Device Types / Socket Device / Device Op
The event buffer is as follows:
\begin{lstlisting}
-enum virtio_vsock_event_id {
- VIRTIO_VSOCK_EVENT_TRANSPORT_RESET = 0,
-};
+#define VIRTIO_VSOCK_EVENT_TRANSPORT_RESET 0
struct virtio_vsock_event {
le32 id;
--
2.25.1
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v6 1/2] virtio-vsock: use C style defines for constants
2021-05-24 18:33 ` [virtio-comment] [PATCH v6 1/2] virtio-vsock: use C style defines for constants Arseny Krasnov
@ 2021-06-18 14:47 ` Stefano Garzarella
0 siblings, 0 replies; 10+ messages in thread
From: Stefano Garzarella @ 2021-06-18 14:47 UTC (permalink / raw)
To: Arseny Krasnov
Cc: Andra Paraschiv, Michael S. Tsirkin, cohuck, Colin Ian King,
oxffffaa, Norbert Slusarek, Stefan Hajnoczi, virtio-comment,
Jakub Kicinski, virtualization, David S. Miller, Jorgen Hansen
On Mon, May 24, 2021 at 09:33:50PM +0300, Arseny Krasnov wrote:
>This:
>1) Replaces enums with C style "defines", because
> use of enums is not documented, while "defines"
> are widely used in spec.
>2) Adds defines for some constants.
>
>Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
>---
> virtio-vsock.tex | 54 +++++++++++++++++++++++++-----------------------
> 1 file changed, 28 insertions(+), 26 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread
* [virtio-comment] Re: [PATCH v6 1/2] virtio-vsock: use C style defines for constants
@ 2021-06-18 14:47 ` Stefano Garzarella
0 siblings, 0 replies; 10+ messages in thread
From: Stefano Garzarella @ 2021-06-18 14:47 UTC (permalink / raw)
To: Arseny Krasnov
Cc: cohuck, virtio-comment, Stefan Hajnoczi, Michael S. Tsirkin,
Jason Wang, David S. Miller, Jakub Kicinski, Jorgen Hansen,
Norbert Slusarek, Colin Ian King, Andra Paraschiv,
virtualization, oxffffaa
On Mon, May 24, 2021 at 09:33:50PM +0300, Arseny Krasnov wrote:
>This:
>1) Replaces enums with C style "defines", because
> use of enums is not documented, while "defines"
> are widely used in spec.
>2) Adds defines for some constants.
>
>Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
>---
> virtio-vsock.tex | 54 +++++++++++++++++++++++++-----------------------
> 1 file changed, 28 insertions(+), 26 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
^ permalink raw reply [flat|nested] 10+ messages in thread
* [virtio-comment] [PATCH v6 2/2] virtio-vsock: SOCK_SEQPACKET description
2021-05-24 18:32 [virtio-comment] [PATCH v6 0/2] virtio-vsock: introduce SOCK_SEQPACKET description Arseny Krasnov
2021-05-24 18:33 ` [virtio-comment] [PATCH v6 1/2] virtio-vsock: use C style defines for constants Arseny Krasnov
@ 2021-05-24 18:34 ` Arseny Krasnov
2021-06-18 14:49 ` [virtio-comment] " Stefano Garzarella
2021-05-27 13:15 ` Stefano Garzarella
2 siblings, 1 reply; 10+ messages in thread
From: Arseny Krasnov @ 2021-05-24 18:34 UTC (permalink / raw)
To: cohuck, virtio-comment, Stefan Hajnoczi, Stefano Garzarella,
Michael S. Tsirkin, Jason Wang, David S. Miller, Jakub Kicinski,
Arseny Krasnov, Jorgen Hansen, Norbert Slusarek, Andra Paraschiv,
Colin Ian King
Cc: virtualization, oxffffaa
This adds description of SOCK_SEQPACKET socket type
support for virtio-vsock.
Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
---
virtio-vsock.tex | 26 +++++++++++++++++++++-----
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/virtio-vsock.tex b/virtio-vsock.tex
index ad57f9d..9ef2b0e 100644
--- a/virtio-vsock.tex
+++ b/virtio-vsock.tex
@@ -16,7 +16,10 @@ \subsection{Virtqueues}\label{sec:Device Types / Socket Device / Virtqueues}
\subsection{Feature bits}\label{sec:Device Types / Socket Device / Feature bits}
-There are currently no feature bits defined for this device.
+\begin{description}
+\item VIRTIO_VSOCK_F_SEQPACKET (1) SOCK_SEQPACKET socket type is
+ supported.
+\end{description}
\subsection{Device configuration layout}\label{sec:Device Types / Socket Device / Device configuration layout}
@@ -135,15 +138,17 @@ \subsubsection{Addressing}\label{sec:Device Types / Socket Device / Device Opera
consists of a (cid, port number) tuple. The header fields used for this are
\field{src_cid}, \field{src_port}, \field{dst_cid}, and \field{dst_port}.
-Currently only stream sockets are supported. \field{type} is 1 (VIRTIO_VSOCK_TYPE_STREAM)
-for stream socket types.
+Currently stream and seqpacket sockets are supported. \field{type} is 1 (VIRTIO_VSOCK_TYPE_STREAM)
+for stream socket types, and 2 (VIRTIO_VSOCK_TYPE_SEQPACKET) for seqpacket socket types.
\begin{lstlisting}
-#define VIRTIO_VSOCK_TYPE_STREAM 1
+#define VIRTIO_VSOCK_TYPE_STREAM 1
+#define VIRTIO_VSOCK_TYPE_SEQPACKET 2
\end{lstlisting}
Stream sockets provide in-order, guaranteed, connection-oriented delivery
-without message boundaries.
+without message boundaries. Seqpacket sockets provide in-order, guaranteed,
+connection-oriented delivery with message boundaries.
\subsubsection{Buffer Space Management}\label{sec:Device Types / Socket Device / Device Operation / Buffer Space Management}
\field{buf_alloc} and \field{fwd_cnt} are used for buffer space management of
@@ -244,6 +249,17 @@ \subsubsection{Stream Sockets}\label{sec:Device Types / Socket Device / Device O
destination) address tuple for a new connection while the other peer is still
processing the old connection.
+\subsubsection{Seqpacket Sockets}\label{sec:Device Types / Socket Device / Device Operation / Seqpacket Sockets}
+
+\paragraph{Message boundaries}\label{sec:Device Types / Socket Device / Device Operation / Seqpacket Sockets / Message boundaries}
+
+To provide message boundaries, last RW packet of each message has VIRTIO_VSOCK_SEQ_EOR
+bit (bit 0) set in the \field{flags} of packet's header.
+
+\begin{lstlisting}
+#define VIRTIO_VSOCK_SEQ_EOR 1
+\end{lstlisting}
+
\subsubsection{Device Events}\label{sec:Device Types / Socket Device / Device Operation / Device Events}
Certain events are communicated by the device to the driver using the event
--
2.25.1
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v6 2/2] virtio-vsock: SOCK_SEQPACKET description
2021-05-24 18:34 ` [virtio-comment] [PATCH v6 2/2] virtio-vsock: SOCK_SEQPACKET description Arseny Krasnov
@ 2021-06-18 14:49 ` Stefano Garzarella
0 siblings, 0 replies; 10+ messages in thread
From: Stefano Garzarella @ 2021-06-18 14:49 UTC (permalink / raw)
To: Arseny Krasnov
Cc: Andra Paraschiv, Michael S. Tsirkin, cohuck, Colin Ian King,
oxffffaa, Norbert Slusarek, Stefan Hajnoczi, virtio-comment,
Jakub Kicinski, virtualization, David S. Miller, Jorgen Hansen
On Mon, May 24, 2021 at 09:34:15PM +0300, Arseny Krasnov wrote:
>This adds description of SOCK_SEQPACKET socket type
>support for virtio-vsock.
>
>Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
>---
> virtio-vsock.tex | 26 +++++++++++++++++++++-----
> 1 file changed, 21 insertions(+), 5 deletions(-)
>
>diff --git a/virtio-vsock.tex b/virtio-vsock.tex
>index ad57f9d..9ef2b0e 100644
>--- a/virtio-vsock.tex
>+++ b/virtio-vsock.tex
>@@ -16,7 +16,10 @@ \subsection{Virtqueues}\label{sec:Device Types / Socket Device / Virtqueues}
>
> \subsection{Feature bits}\label{sec:Device Types / Socket Device / Feature bits}
>
>-There are currently no feature bits defined for this device.
>+\begin{description}
>+\item VIRTIO_VSOCK_F_SEQPACKET (1) SOCK_SEQPACKET socket type is
>+ supported.
>+\end{description}
The VIRTIO_VSOCK_F_STREAM is described in the datagram series by Jiang,
so this patch should be fine:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread
* [virtio-comment] Re: [PATCH v6 2/2] virtio-vsock: SOCK_SEQPACKET description
@ 2021-06-18 14:49 ` Stefano Garzarella
0 siblings, 0 replies; 10+ messages in thread
From: Stefano Garzarella @ 2021-06-18 14:49 UTC (permalink / raw)
To: Arseny Krasnov
Cc: cohuck, virtio-comment, Stefan Hajnoczi, Michael S. Tsirkin,
Jason Wang, David S. Miller, Jakub Kicinski, Jorgen Hansen,
Norbert Slusarek, Andra Paraschiv, Colin Ian King,
virtualization, oxffffaa
On Mon, May 24, 2021 at 09:34:15PM +0300, Arseny Krasnov wrote:
>This adds description of SOCK_SEQPACKET socket type
>support for virtio-vsock.
>
>Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
>---
> virtio-vsock.tex | 26 +++++++++++++++++++++-----
> 1 file changed, 21 insertions(+), 5 deletions(-)
>
>diff --git a/virtio-vsock.tex b/virtio-vsock.tex
>index ad57f9d..9ef2b0e 100644
>--- a/virtio-vsock.tex
>+++ b/virtio-vsock.tex
>@@ -16,7 +16,10 @@ \subsection{Virtqueues}\label{sec:Device Types / Socket Device / Virtqueues}
>
> \subsection{Feature bits}\label{sec:Device Types / Socket Device / Feature bits}
>
>-There are currently no feature bits defined for this device.
>+\begin{description}
>+\item VIRTIO_VSOCK_F_SEQPACKET (1) SOCK_SEQPACKET socket type is
>+ supported.
>+\end{description}
The VIRTIO_VSOCK_F_STREAM is described in the datagram series by Jiang,
so this patch should be fine:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [virtio-comment] [PATCH v6 0/2] virtio-vsock: introduce SOCK_SEQPACKET description
2021-05-24 18:32 [virtio-comment] [PATCH v6 0/2] virtio-vsock: introduce SOCK_SEQPACKET description Arseny Krasnov
@ 2021-05-27 13:15 ` Stefano Garzarella
2021-05-24 18:34 ` [virtio-comment] [PATCH v6 2/2] virtio-vsock: SOCK_SEQPACKET description Arseny Krasnov
2021-05-27 13:15 ` Stefano Garzarella
2 siblings, 0 replies; 10+ messages in thread
From: Stefano Garzarella @ 2021-05-27 13:15 UTC (permalink / raw)
To: Arseny Krasnov
Cc: Andra Paraschiv, Michael S. Tsirkin, cohuck, Colin Ian King,
oxffffaa, Norbert Slusarek, Stefan Hajnoczi, virtio-comment,
Jakub Kicinski, virtualization, David S. Miller, Jorgen Hansen
On Mon, May 24, 2021 at 09:32:29PM +0300, Arseny Krasnov wrote:
>This adds description of SOCK_SEQPACKET type for virtio-vsock.
>
>Here is latest RFC implementation for Linux, with more details:
>
>https://lkml.org/lkml/2021/5/20/2386
>
>Also this patchset has patch which replaces enums to defines in
>virtio-vsock part of spec. SOCK_SEQPACKET patch is based on it.
>
> Arseny Krasnov(2):
> virtio-vsock: use C style defines for constants
> virtio-vsock: SOCK_SEQPACKET description
>
> virtio-vsock.tex | 74 ++++++++++++++++++++++++++++------------------
> 1 file changed, 46 insertions(+), 28 deletions(-)
>
The series LGTM!
Let's wait for other comments.
I'll send a follow up patch next week about feature bit for stream
socket (bit 0).
Thanks,
Stefano
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [virtio-comment] [PATCH v6 0/2] virtio-vsock: introduce SOCK_SEQPACKET description
@ 2021-05-27 13:15 ` Stefano Garzarella
0 siblings, 0 replies; 10+ messages in thread
From: Stefano Garzarella @ 2021-05-27 13:15 UTC (permalink / raw)
To: Arseny Krasnov
Cc: cohuck, virtio-comment, Stefan Hajnoczi, Michael S. Tsirkin,
Jason Wang, David S. Miller, Jakub Kicinski, Jorgen Hansen,
Norbert Slusarek, Colin Ian King, Andra Paraschiv,
virtualization, oxffffaa
On Mon, May 24, 2021 at 09:32:29PM +0300, Arseny Krasnov wrote:
>This adds description of SOCK_SEQPACKET type for virtio-vsock.
>
>Here is latest RFC implementation for Linux, with more details:
>
>https://lkml.org/lkml/2021/5/20/2386
>
>Also this patchset has patch which replaces enums to defines in
>virtio-vsock part of spec. SOCK_SEQPACKET patch is based on it.
>
> Arseny Krasnov(2):
> virtio-vsock: use C style defines for constants
> virtio-vsock: SOCK_SEQPACKET description
>
> virtio-vsock.tex | 74 ++++++++++++++++++++++++++++------------------
> 1 file changed, 46 insertions(+), 28 deletions(-)
>
The series LGTM!
Let's wait for other comments.
I'll send a follow up patch next week about feature bit for stream
socket (bit 0).
Thanks,
Stefano
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [virtio-comment] [PATCH v6 0/2] virtio-vsock: introduce SOCK_SEQPACKET description
2021-05-27 13:15 ` Stefano Garzarella
(?)
@ 2021-06-15 3:59 ` Arseny Krasnov
-1 siblings, 0 replies; 10+ messages in thread
From: Arseny Krasnov @ 2021-06-15 3:59 UTC (permalink / raw)
To: Stefano Garzarella
Cc: cohuck, virtio-comment, Stefan Hajnoczi, Michael S. Tsirkin,
Jason Wang, David S. Miller, Jakub Kicinski, Jorgen Hansen,
Norbert Slusarek, Colin Ian King, Andra Paraschiv,
virtualization, oxffffaa
On 27.05.2021 16:15, Stefano Garzarella wrote:
> On Mon, May 24, 2021 at 09:32:29PM +0300, Arseny Krasnov wrote:
>> This adds description of SOCK_SEQPACKET type for virtio-vsock.
>>
>> Here is latest RFC implementation for Linux, with more details:
>>
>> https://lkml.org/lkml/2021/5/20/2386
>>
>> Also this patchset has patch which replaces enums to defines in
>> virtio-vsock part of spec. SOCK_SEQPACKET patch is based on it.
>>
>> Arseny Krasnov(2):
>> virtio-vsock: use C style defines for constants
>> virtio-vsock: SOCK_SEQPACKET description
>>
>> virtio-vsock.tex | 74 ++++++++++++++++++++++++++++------------------
>> 1 file changed, 46 insertions(+), 28 deletions(-)
>>
> The series LGTM!
>
> Let's wait for other comments.
Ping, Linux kernel patches are already merged to net-next
Thank You
>
> I'll send a follow up patch next week about feature bit for stream
> socket (bit 0).
>
> Thanks,
> Stefano
>
>
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
^ permalink raw reply [flat|nested] 10+ messages in thread