All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Skripkin <paskripkin@gmail.com>
To: Aviral Gupta <shiv14112001@gmail.com>
Cc: ulf.hansson@linaro.org, adrian.hunter@intel.com, axboe@kernel.dk,
	beanhuo@micron.com, satyat@google.com, avri.altman@wdc.com,
	richard.peng@oppo.com, guoqing.jiang@cloud.ionos.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] This patch fixes the warning generated due to use of symbolic
Date: Mon, 24 May 2021 19:19:07 +0300	[thread overview]
Message-ID: <20210524191907.034efdd6@gmail.com> (raw)
In-Reply-To: <20210524155705.5138-1-shiv14112001@gmail.com>

On Mon, 24 May 2021 21:27:06 +0530
Aviral Gupta <shiv14112001@gmail.com> wrote:

> It's better to use octal permissons instead of symbolic ones because
> peoples are more familiar with octal permissons.
> WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
> +	md->force_ro.attr.mode = S_IRUGO | S_IWUSR;
> 
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
> using octal permissions '0444'.
> +			mode = S_IRUGO;
> 
> WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
> +			mode = S_IRUGO | S_IWUSR;
> 
> WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider
> using octal permissions '0400'.
> +			debugfs_create_file("ext_csd", S_IRUSR,
> root, card,
> 
> Signed-off-by: Aviral Gupta <shiv14112001@gmail.com>
> ---
>  drivers/mmc/core/block.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Hi, Aviral!

I guess, you missed my and Greg's mails last time... 

Anyway, subject line is strange, it should be smth like "mmc: core:
fix symbolic permissions".

Please, refer to
https://www.kernel.org/doc/html/latest/process/submitting-patches.html.


With regards,
Pavel Skripkin

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Skripkin <paskripkin@gmail.com>
To: Aviral Gupta <shiv14112001@gmail.com>
Cc: axboe@kernel.dk, richard.peng@oppo.com, ulf.hansson@linaro.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	adrian.hunter@intel.com, guoqing.jiang@cloud.ionos.com,
	satyat@google.com, avri.altman@wdc.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	beanhuo@micron.com
Subject: Re: [PATCH] This patch fixes the warning generated due to use of symbolic
Date: Mon, 24 May 2021 19:19:07 +0300	[thread overview]
Message-ID: <20210524191907.034efdd6@gmail.com> (raw)
In-Reply-To: <20210524155705.5138-1-shiv14112001@gmail.com>

On Mon, 24 May 2021 21:27:06 +0530
Aviral Gupta <shiv14112001@gmail.com> wrote:

> It's better to use octal permissons instead of symbolic ones because
> peoples are more familiar with octal permissons.
> WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
> +	md->force_ro.attr.mode = S_IRUGO | S_IWUSR;
> 
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
> using octal permissions '0444'.
> +			mode = S_IRUGO;
> 
> WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
> +			mode = S_IRUGO | S_IWUSR;
> 
> WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider
> using octal permissions '0400'.
> +			debugfs_create_file("ext_csd", S_IRUSR,
> root, card,
> 
> Signed-off-by: Aviral Gupta <shiv14112001@gmail.com>
> ---
>  drivers/mmc/core/block.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Hi, Aviral!

I guess, you missed my and Greg's mails last time... 

Anyway, subject line is strange, it should be smth like "mmc: core:
fix symbolic permissions".

Please, refer to
https://www.kernel.org/doc/html/latest/process/submitting-patches.html.


With regards,
Pavel Skripkin
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  parent reply	other threads:[~2021-05-24 16:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24 15:57 [PATCH] This patch fixes the warning generated due to use of symbolic Aviral Gupta
2021-05-24 15:57 ` Aviral Gupta
2021-05-24 16:07 ` Greg KH
2021-05-24 16:07   ` Greg KH
2021-05-24 16:19 ` Pavel Skripkin [this message]
2021-05-24 16:19   ` Pavel Skripkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210524191907.034efdd6@gmail.com \
    --to=paskripkin@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=avri.altman@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=beanhuo@micron.com \
    --cc=guoqing.jiang@cloud.ionos.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=richard.peng@oppo.com \
    --cc=satyat@google.com \
    --cc=shiv14112001@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.