From: Christoph Hellwig <hch@lst.de>
To: Prike Liang <Prike.Liang@amd.com>
Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, Alexander.Deucher@amd.com,
Shyam-sundar.S-k@amd.com, Mario.Limonciello@amd.com
Subject: Re: [PATCH] nvme-pci: set some AMD PCIe downstream storage device to D3 for s2idle
Date: Tue, 25 May 2021 08:21:19 +0200 [thread overview]
Message-ID: <20210525062119.GA12561@lst.de> (raw)
In-Reply-To: <1621910939-24831-1-git-send-email-Prike.Liang@amd.com>
On Tue, May 25, 2021 at 10:48:59AM +0800, Prike Liang wrote:
> +#ifdef CONFIG_X86
> +#include <asm/cpu_device_id.h>
> +#endif
>
> #include "trace.h"
> #include "nvme.h"
> @@ -2828,6 +2831,16 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
> }
>
> #ifdef CONFIG_ACPI
> +
> +#ifdef CONFIG_X86
> +static const struct x86_cpu_id storage_d3_cpu_ids[] = {
> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 25, 80, NULL), /*Cezanne*/
> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /*Renoir*/
> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL),/*Lucienne*/
> + {}
> +};
> +#endif
This is completely unacceptable. The NVMe driver could not care less
what CPU we on. We need information from the PCI or power managment core
on how broken the power management of the root port is, not this kind of
crap in a low-level driver, with potentially many more needing the same
kind of quirk in the future.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-25 6:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 2:48 [PATCH] nvme-pci: set some AMD PCIe downstream storage device to D3 for s2idle Prike Liang
2021-05-25 6:21 ` Christoph Hellwig [this message]
2021-05-25 12:11 ` Liang, Prike
2021-05-25 12:15 ` Christoph Hellwig
2021-05-25 13:39 ` Deucher, Alexander
2021-05-25 13:54 ` Hans de Goede
2021-05-25 14:06 ` Limonciello, Mario
2021-05-25 14:16 ` Christoph Hellwig
2021-05-25 15:18 ` Limonciello, Mario
2021-05-25 17:45 ` Keith Busch
2021-05-25 18:27 ` Limonciello, Mario
2021-05-25 19:55 ` Keith Busch
2021-05-25 20:02 ` Chaitanya Kulkarni
2021-05-26 8:52 ` Hans de Goede
2021-05-26 13:02 ` Christoph Hellwig
2021-05-26 14:45 ` Keith Busch
2021-05-26 14:55 ` Rafael J. Wysocki
2021-05-26 17:02 ` Limonciello, Mario
2021-05-26 17:27 ` Rafael J. Wysocki
2021-05-26 17:32 ` Limonciello, Mario
2021-05-26 17:42 ` Limonciello, Mario
2021-05-25 19:59 ` Keith Busch
2021-05-25 20:09 ` Limonciello, Mario
2021-05-25 20:24 ` Keith Busch
2021-05-25 21:51 ` Limonciello, Mario
2021-05-25 14:09 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525062119.GA12561@lst.de \
--to=hch@lst.de \
--cc=Alexander.Deucher@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Prike.Liang@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.