All of lore.kernel.org
 help / color / mirror / Atom feed
* [l1k:bcm2835_spi_limit 3/3] drivers/spi/spi-omap2-mcspi.c:1077:13: warning: conflicting types for 'omap2_mcspi_cleanup'
@ 2021-05-24 23:29 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-05-24 23:29 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 8389 bytes --]

tree:   https://github.com/l1k/linux bcm2835_spi_limit
head:   3d5ecff93d06ef97936ba4129888298cbdff3dcb
commit: 3d5ecff93d06ef97936ba4129888298cbdff3dcb [3/3] spi: Cleanup on failure of initial setup
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/l1k/linux/commit/3d5ecff93d06ef97936ba4129888298cbdff3dcb
        git remote add l1k https://github.com/l1k/linux
        git fetch --no-tags l1k bcm2835_spi_limit
        git checkout 3d5ecff93d06ef97936ba4129888298cbdff3dcb
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/spi/spi-omap2-mcspi.c: In function 'omap2_mcspi_setup':
   drivers/spi/spi-omap2-mcspi.c:1062:4: error: implicit declaration of function 'omap2_mcspi_cleanup'; did you mean 'omap2_mcspi_setup'? [-Werror=implicit-function-declaration]
    1062 |    omap2_mcspi_cleanup(spi);
         |    ^~~~~~~~~~~~~~~~~~~
         |    omap2_mcspi_setup
   drivers/spi/spi-omap2-mcspi.c: At top level:
>> drivers/spi/spi-omap2-mcspi.c:1077:13: warning: conflicting types for 'omap2_mcspi_cleanup'
    1077 | static void omap2_mcspi_cleanup(struct spi_device *spi)
         |             ^~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-omap2-mcspi.c:1077:13: error: static declaration of 'omap2_mcspi_cleanup' follows non-static declaration
   drivers/spi/spi-omap2-mcspi.c:1062:4: note: previous implicit declaration of 'omap2_mcspi_cleanup' was here
    1062 |    omap2_mcspi_cleanup(spi);
         |    ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/omap2_mcspi_cleanup +1077 drivers/spi/spi-omap2-mcspi.c

32f2fc5dc3992b drivers/spi/spi-omap2-mcspi.c Vignesh Raghavendra 2020-02-04  1034  
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1035  static int omap2_mcspi_setup(struct spi_device *spi)
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1036  {
3d5ecff93d06ef drivers/spi/spi-omap2-mcspi.c Lukas Wunner        2021-05-24  1037  	bool			initial_setup = false;
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1038  	int			ret;
1bd897f84964c2 drivers/spi/spi-omap2-mcspi.c Benoit Cousson      2012-03-26  1039  	struct omap2_mcspi	*mcspi = spi_master_get_devdata(spi->master);
1bd897f84964c2 drivers/spi/spi-omap2-mcspi.c Benoit Cousson      2012-03-26  1040  	struct omap2_mcspi_regs	*ctx = &mcspi->ctx;
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1041  	struct omap2_mcspi_cs	*cs = spi->controller_state;
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1042  
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1043  	if (!cs) {
10aa5a35e34fb0 drivers/spi/spi-omap2-mcspi.c Russell King        2012-06-18  1044  		cs = kzalloc(sizeof *cs, GFP_KERNEL);
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1045  		if (!cs)
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1046  			return -ENOMEM;
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1047  		cs->base = mcspi->base + spi->chip_select * 0x14;
e5480b7397f497 drivers/spi/omap2_mcspi.c     Russell King        2008-09-01  1048  		cs->phys = mcspi->phys + spi->chip_select * 0x14;
97ca0d6cc11871 drivers/spi/spi-omap2-mcspi.c Mark A. Greer       2014-07-01  1049  		cs->mode = 0;
a41ae1ad907655 drivers/spi/omap2_mcspi.c     Hemanth V           2009-09-22  1050  		cs->chconf0 = 0;
faee9b05f69f22 drivers/spi/spi-omap2-mcspi.c Stefan Sørensen     2014-02-02  1051  		cs->chctrl0 = 0;
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1052  		spi->controller_state = cs;
89c05372d08f39 drivers/spi/omap2_mcspi.c     Tero Kristo         2009-09-22  1053  		/* Link this to context save list */
1bd897f84964c2 drivers/spi/spi-omap2-mcspi.c Benoit Cousson      2012-03-26  1054  		list_add_tail(&cs->node, &ctx->cs);
3d5ecff93d06ef drivers/spi/spi-omap2-mcspi.c Lukas Wunner        2021-05-24  1055  		initial_setup = true;
2f538c017e1a86 drivers/spi/spi-omap2-mcspi.c Michael Welling     2015-11-30  1056  	}
2f538c017e1a86 drivers/spi/spi-omap2-mcspi.c Michael Welling     2015-11-30  1057  
034d3dc9886054 drivers/spi/spi-omap2-mcspi.c Shubhrajyoti D      2012-08-22  1058  	ret = pm_runtime_get_sync(mcspi->dev);
5a686b2c9ed442 drivers/spi/spi-omap2-mcspi.c Tony Lindgren       2018-04-27  1059  	if (ret < 0) {
5a686b2c9ed442 drivers/spi/spi-omap2-mcspi.c Tony Lindgren       2018-04-27  1060  		pm_runtime_put_noidle(mcspi->dev);
3d5ecff93d06ef drivers/spi/spi-omap2-mcspi.c Lukas Wunner        2021-05-24  1061  		if (initial_setup)
3d5ecff93d06ef drivers/spi/spi-omap2-mcspi.c Lukas Wunner        2021-05-24 @1062  			omap2_mcspi_cleanup(spi);
5a686b2c9ed442 drivers/spi/spi-omap2-mcspi.c Tony Lindgren       2018-04-27  1063  
1f1a4384b65002 drivers/spi/omap2_mcspi.c     Govindraj.R         2011-02-02  1064  		return ret;
5a686b2c9ed442 drivers/spi/spi-omap2-mcspi.c Tony Lindgren       2018-04-27  1065  	}
a41ae1ad907655 drivers/spi/omap2_mcspi.c     Hemanth V           2009-09-22  1066  
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1067  	ret = omap2_mcspi_setup_transfer(spi, NULL);
3d5ecff93d06ef drivers/spi/spi-omap2-mcspi.c Lukas Wunner        2021-05-24  1068  	if (ret && initial_setup)
3d5ecff93d06ef drivers/spi/spi-omap2-mcspi.c Lukas Wunner        2021-05-24  1069  		omap2_mcspi_cleanup(spi);
3d5ecff93d06ef drivers/spi/spi-omap2-mcspi.c Lukas Wunner        2021-05-24  1070  
034d3dc9886054 drivers/spi/spi-omap2-mcspi.c Shubhrajyoti D      2012-08-22  1071  	pm_runtime_mark_last_busy(mcspi->dev);
034d3dc9886054 drivers/spi/spi-omap2-mcspi.c Shubhrajyoti D      2012-08-22  1072  	pm_runtime_put_autosuspend(mcspi->dev);
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1073  
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1074  	return ret;
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1075  }
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1076  
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17 @1077  static void omap2_mcspi_cleanup(struct spi_device *spi)
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1078  {
89c05372d08f39 drivers/spi/omap2_mcspi.c     Tero Kristo         2009-09-22  1079  	struct omap2_mcspi_cs	*cs;
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1080  
5e7749436d576a drivers/spi/omap2_mcspi.c     Scott Ellis         2010-03-10  1081  	if (spi->controller_state) {
89c05372d08f39 drivers/spi/omap2_mcspi.c     Tero Kristo         2009-09-22  1082  		/* Unlink controller state from context save list */
89c05372d08f39 drivers/spi/omap2_mcspi.c     Tero Kristo         2009-09-22  1083  		cs = spi->controller_state;
89c05372d08f39 drivers/spi/omap2_mcspi.c     Tero Kristo         2009-09-22  1084  		list_del(&cs->node);
89c05372d08f39 drivers/spi/omap2_mcspi.c     Tero Kristo         2009-09-22  1085  
10aa5a35e34fb0 drivers/spi/spi-omap2-mcspi.c Russell King        2012-06-18  1086  		kfree(cs);
5e7749436d576a drivers/spi/omap2_mcspi.c     Scott Ellis         2010-03-10  1087  	}
99f1a43f436a6a drivers/spi/omap2_mcspi.c     Scott Ellis         2010-05-24  1088  }
ccdc7bf925731e drivers/spi/omap2_mcspi.c     Samuel Ortiz        2007-07-17  1089  

:::::: The code at line 1077 was first introduced by commit
:::::: ccdc7bf925731ef37f0af95262d675b74544932f SPI: omap2_mcspi driver

:::::: TO: Samuel Ortiz <samuel.ortiz@solidboot.com>
:::::: CC: Linus Torvalds <torvalds@woody.linux-foundation.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68141 bytes --]

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2021-05-24 23:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 23:29 [l1k:bcm2835_spi_limit 3/3] drivers/spi/spi-omap2-mcspi.c:1077:13: warning: conflicting types for 'omap2_mcspi_cleanup' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.