[PATCH] MIPS: alchemy: xxs1500: add gpio-au1000.h header file

[PATCH] MIPS: alchemy: xxs1500: add gpio-au1000.h header file

[Randy Dunlap]

board-xxs1500.c references 2 functions without declaring them, so add
the header file to placate the build.

../arch/mips/alchemy/board-xxs1500.c: In function 'board_setup':
../arch/mips/alchemy/board-xxs1500.c:56:2: error: implicit declaration of function 'alchemy_gpio1_input_enable' [-Werror=implicit-function-declaration]
   56 |  alchemy_gpio1_input_enable();
../arch/mips/alchemy/board-xxs1500.c:57:2: error: implicit declaration of function 'alchemy_gpio2_enable'; did you mean 'alchemy_uart_enable'? [-Werror=implicit-function-declaration]
   57 |  alchemy_gpio2_enable();

Fixes: 8e026910fcd4 ("MIPS: Alchemy: merge GPR/MTX-1/XXS1500 board code into single files")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
Cc: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
 arch/mips/alchemy/board-xxs1500.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20210514.orig/arch/mips/alchemy/board-xxs1500.c
+++ linux-next-20210514/arch/mips/alchemy/board-xxs1500.c
@@ -18,6 +18,7 @@
 #include <asm/reboot.h>
 #include <asm/setup.h>
 #include <asm/mach-au1x00/au1000.h>
+#include <asm/mach-au1x00/gpio-au1000.h>
 #include <prom.h>
 
 const char *get_system_type(void)

Re: [PATCH] MIPS: alchemy: xxs1500: add gpio-au1000.h header file

[Manuel Lauss]

Hello,

On Mon, May 17, 2021 at 2:01 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> board-xxs1500.c references 2 functions without declaring them, so add
> the header file to placate the build.
>
> ../arch/mips/alchemy/board-xxs1500.c: In function 'board_setup':
> ../arch/mips/alchemy/board-xxs1500.c:56:2: error: implicit declaration of function 'alchemy_gpio1_input_enable' [-Werror=implicit-function-declaration]
>    56 |  alchemy_gpio1_input_enable();
> ../arch/mips/alchemy/board-xxs1500.c:57:2: error: implicit declaration of function 'alchemy_gpio2_enable'; did you mean 'alchemy_uart_enable'? [-Werror=implicit-function-declaration]
>    57 |  alchemy_gpio2_enable();
>
> Fixes: 8e026910fcd4 ("MIPS: Alchemy: merge GPR/MTX-1/XXS1500 board code into single files")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> Cc: Manuel Lauss <manuel.lauss@googlemail.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
>  arch/mips/alchemy/board-xxs1500.c |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20210514.orig/arch/mips/alchemy/board-xxs1500.c
> +++ linux-next-20210514/arch/mips/alchemy/board-xxs1500.c
> @@ -18,6 +18,7 @@
>  #include <asm/reboot.h>
>  #include <asm/setup.h>
>  #include <asm/mach-au1x00/au1000.h>
> +#include <asm/mach-au1x00/gpio-au1000.h>

Acked-by: Manuel Lauss <manuel.lauss@gmail.com>

Thank you!
     Manuel

Re: [PATCH] MIPS: alchemy: xxs1500: add gpio-au1000.h header file

[Thomas Bogendoerfer]

On Sun, May 16, 2021 at 05:01:08PM -0700, Randy Dunlap wrote:
> board-xxs1500.c references 2 functions without declaring them, so add
> the header file to placate the build.
> 
> ../arch/mips/alchemy/board-xxs1500.c: In function 'board_setup':
> ../arch/mips/alchemy/board-xxs1500.c:56:2: error: implicit declaration of function 'alchemy_gpio1_input_enable' [-Werror=implicit-function-declaration]
>    56 |  alchemy_gpio1_input_enable();
> ../arch/mips/alchemy/board-xxs1500.c:57:2: error: implicit declaration of function 'alchemy_gpio2_enable'; did you mean 'alchemy_uart_enable'? [-Werror=implicit-function-declaration]
>    57 |  alchemy_gpio2_enable();
> 
> Fixes: 8e026910fcd4 ("MIPS: Alchemy: merge GPR/MTX-1/XXS1500 board code into single files")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> Cc: Manuel Lauss <manuel.lauss@googlemail.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
>  arch/mips/alchemy/board-xxs1500.c |    1 +
>  1 file changed, 1 insertion(+)

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]