All of lore.kernel.org
 help / color / mirror / Atom feed
* + exec-remove-checks-in-__register_bimfmt.patch added to -mm tree
@ 2021-05-25 20:16 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2021-05-25 20:16 UTC (permalink / raw)
  To: adobriyan, mm-commits


The patch titled
     Subject: exec: remove checks in __register_bimfmt()
has been added to the -mm tree.  Its filename is
     exec-remove-checks-in-__register_bimfmt.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/exec-remove-checks-in-__register_bimfmt.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/exec-remove-checks-in-__register_bimfmt.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Alexey Dobriyan <adobriyan@gmail.com>
Subject: exec: remove checks in __register_bimfmt()

Delete NULL check, all callers pass valid pointer.

Delete ->load_binary check -- failure to provide hook in a custom module
will be very noticeable at the very first execve call.

Link: https://lkml.kernel.org/r/YK1Gy1qXaLAR+tPl@localhost.localdomain
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/exec.c |    3 ---
 1 file changed, 3 deletions(-)

--- a/fs/exec.c~exec-remove-checks-in-__register_bimfmt
+++ a/fs/exec.c
@@ -84,9 +84,6 @@ static DEFINE_RWLOCK(binfmt_lock);
 
 void __register_binfmt(struct linux_binfmt * fmt, int insert)
 {
-	BUG_ON(!fmt);
-	if (WARN_ON(!fmt->load_binary))
-		return;
 	write_lock(&binfmt_lock);
 	insert ? list_add(&fmt->lh, &formats) :
 		 list_add_tail(&fmt->lh, &formats);
_

Patches currently in -mm which might be from adobriyan@gmail.com are

exec-remove-checks-in-__register_bimfmt.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-25 20:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 20:16 + exec-remove-checks-in-__register_bimfmt.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.