* [PATCH] free the metadata buffer for sg type BOs as well
@ 2021-05-26 3:46 Shiwu Zhang
2021-05-26 11:31 ` Das, Nirmoy
2021-05-26 12:44 ` Christian König
0 siblings, 2 replies; 4+ messages in thread
From: Shiwu Zhang @ 2021-05-26 3:46 UTC (permalink / raw)
To: amd-gfx, nirmoy.das
Signed-off-by: Shiwu Zhang <shiwu.zhang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 2d876e1eaa7c..e9f8701fd046 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -95,7 +95,7 @@ static void amdgpu_bo_destroy(struct ttm_buffer_object *tbo)
}
amdgpu_bo_unref(&bo->parent);
- if (bo->tbo.type == ttm_bo_type_device) {
+ if (bo->tbo.type != ttm_bo_type_kernel) {
ubo = to_amdgpu_bo_user(bo);
kfree(ubo->metadata);
}
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] free the metadata buffer for sg type BOs as well
2021-05-26 3:46 [PATCH] free the metadata buffer for sg type BOs as well Shiwu Zhang
@ 2021-05-26 11:31 ` Das, Nirmoy
2021-05-26 12:44 ` Christian König
1 sibling, 0 replies; 4+ messages in thread
From: Das, Nirmoy @ 2021-05-26 11:31 UTC (permalink / raw)
To: Zhang, Morris, amd-gfx; +Cc: Koenig, Christian
[AMD Official Use Only]
Please add a commit message as well.
With that, this is Acked-by: Nirmoy Das <Nirmoy.das@amd.com> but Christian should review it as well.
Nirmoy
-----Original Message-----
From: Zhang, Morris <Shiwu.Zhang@amd.com>
Sent: Wednesday, May 26, 2021 5:46 AM
To: amd-gfx@lists.freedesktop.org; Das, Nirmoy <Nirmoy.Das@amd.com>
Subject: [PATCH] free the metadata buffer for sg type BOs as well
Signed-off-by: Shiwu Zhang <shiwu.zhang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 2d876e1eaa7c..e9f8701fd046 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -95,7 +95,7 @@ static void amdgpu_bo_destroy(struct ttm_buffer_object *tbo)
}
amdgpu_bo_unref(&bo->parent);
- if (bo->tbo.type == ttm_bo_type_device) {
+ if (bo->tbo.type != ttm_bo_type_kernel) {
ubo = to_amdgpu_bo_user(bo);
kfree(ubo->metadata);
}
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] free the metadata buffer for sg type BOs as well
2021-05-26 3:46 [PATCH] free the metadata buffer for sg type BOs as well Shiwu Zhang
2021-05-26 11:31 ` Das, Nirmoy
@ 2021-05-26 12:44 ` Christian König
2021-05-28 2:57 ` Zhang, Morris
1 sibling, 1 reply; 4+ messages in thread
From: Christian König @ 2021-05-26 12:44 UTC (permalink / raw)
To: Shiwu Zhang, amd-gfx, nirmoy.das
You need a commit message.
Am 26.05.21 um 05:46 schrieb Shiwu Zhang:
> Signed-off-by: Shiwu Zhang <shiwu.zhang@amd.com>
With that fixed the patch is Reviewed-by: Christian König
<christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 2d876e1eaa7c..e9f8701fd046 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -95,7 +95,7 @@ static void amdgpu_bo_destroy(struct ttm_buffer_object *tbo)
> }
> amdgpu_bo_unref(&bo->parent);
>
> - if (bo->tbo.type == ttm_bo_type_device) {
> + if (bo->tbo.type != ttm_bo_type_kernel) {
> ubo = to_amdgpu_bo_user(bo);
> kfree(ubo->metadata);
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] free the metadata buffer for sg type BOs as well
2021-05-26 12:44 ` Christian König
@ 2021-05-28 2:57 ` Zhang, Morris
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Morris @ 2021-05-28 2:57 UTC (permalink / raw)
To: Christian König, amd-gfx, Das, Nirmoy
[AMD Official Use Only - Internal Distribution Only]
Hi Das&Christian,
Merged.
Thanks you both for the comments.
--Brs,
Morris Zhang
MLSE Linux ML SRDC
Ext. 25147
-----Original Message-----
From: Christian König <ckoenig.leichtzumerken@gmail.com>
Sent: Wednesday, May 26, 2021 8:44 PM
To: Zhang, Morris <Shiwu.Zhang@amd.com>; amd-gfx@lists.freedesktop.org; Das, Nirmoy <Nirmoy.Das@amd.com>
Subject: Re: [PATCH] free the metadata buffer for sg type BOs as well
You need a commit message.
Am 26.05.21 um 05:46 schrieb Shiwu Zhang:
> Signed-off-by: Shiwu Zhang <shiwu.zhang@amd.com>
With that fixed the patch is Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 2d876e1eaa7c..e9f8701fd046 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -95,7 +95,7 @@ static void amdgpu_bo_destroy(struct ttm_buffer_object *tbo)
> }
> amdgpu_bo_unref(&bo->parent);
>
> - if (bo->tbo.type == ttm_bo_type_device) {
> + if (bo->tbo.type != ttm_bo_type_kernel) {
> ubo = to_amdgpu_bo_user(bo);
> kfree(ubo->metadata);
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-28 2:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 3:46 [PATCH] free the metadata buffer for sg type BOs as well Shiwu Zhang
2021-05-26 11:31 ` Das, Nirmoy
2021-05-26 12:44 ` Christian König
2021-05-28 2:57 ` Zhang, Morris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.