* [PATCH v2] mtd: parsers: qcom: Fix leaking of partition name
@ 2021-05-25 23:09 ` Ansuel Smith
0 siblings, 0 replies; 8+ messages in thread
From: Ansuel Smith @ 2021-05-25 23:09 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Manivannan Sadhasivam, linux-arm-msm,
linux-mtd, linux-kernel
Cc: Ansuel Smith
Add cleanup function as the name variable for the partition name was
allocaed but never freed after the use as the add mtd function
duplicate the name and free the pparts struct as the partition name is
assumed to be static.
The leak was found using kmemleak.
Fixes: 803eb124e1a6 ("mtd: parsers: Add Qcom SMEM parser")
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
drivers/mtd/parsers/qcomsmempart.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/mtd/parsers/qcomsmempart.c b/drivers/mtd/parsers/qcomsmempart.c
index d9083308f6ba..06a818cd2433 100644
--- a/drivers/mtd/parsers/qcomsmempart.c
+++ b/drivers/mtd/parsers/qcomsmempart.c
@@ -159,6 +159,15 @@ static int parse_qcomsmem_part(struct mtd_info *mtd,
return ret;
}
+static void parse_qcomsmem_cleanup(const struct mtd_partition *pparts,
+ int nr_parts)
+{
+ int i;
+
+ for (i = 0; i < nr_parts; i++)
+ kfree(pparts[i].name);
+}
+
static const struct of_device_id qcomsmem_of_match_table[] = {
{ .compatible = "qcom,smem-part" },
{},
@@ -167,6 +176,7 @@ MODULE_DEVICE_TABLE(of, qcomsmem_of_match_table);
static struct mtd_part_parser mtd_parser_qcomsmem = {
.parse_fn = parse_qcomsmem_part,
+ .cleanup = parse_qcomsmem_cleanup,
.name = "qcomsmem",
.of_match_table = qcomsmem_of_match_table,
};
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] mtd: parsers: qcom: Fix leaking of partition name
@ 2021-05-25 23:09 ` Ansuel Smith
0 siblings, 0 replies; 8+ messages in thread
From: Ansuel Smith @ 2021-05-25 23:09 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Manivannan Sadhasivam, linux-arm-msm,
linux-mtd, linux-kernel
Cc: Ansuel Smith
Add cleanup function as the name variable for the partition name was
allocaed but never freed after the use as the add mtd function
duplicate the name and free the pparts struct as the partition name is
assumed to be static.
The leak was found using kmemleak.
Fixes: 803eb124e1a6 ("mtd: parsers: Add Qcom SMEM parser")
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
drivers/mtd/parsers/qcomsmempart.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/mtd/parsers/qcomsmempart.c b/drivers/mtd/parsers/qcomsmempart.c
index d9083308f6ba..06a818cd2433 100644
--- a/drivers/mtd/parsers/qcomsmempart.c
+++ b/drivers/mtd/parsers/qcomsmempart.c
@@ -159,6 +159,15 @@ static int parse_qcomsmem_part(struct mtd_info *mtd,
return ret;
}
+static void parse_qcomsmem_cleanup(const struct mtd_partition *pparts,
+ int nr_parts)
+{
+ int i;
+
+ for (i = 0; i < nr_parts; i++)
+ kfree(pparts[i].name);
+}
+
static const struct of_device_id qcomsmem_of_match_table[] = {
{ .compatible = "qcom,smem-part" },
{},
@@ -167,6 +176,7 @@ MODULE_DEVICE_TABLE(of, qcomsmem_of_match_table);
static struct mtd_part_parser mtd_parser_qcomsmem = {
.parse_fn = parse_qcomsmem_part,
+ .cleanup = parse_qcomsmem_cleanup,
.name = "qcomsmem",
.of_match_table = qcomsmem_of_match_table,
};
--
2.31.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mtd: parsers: qcom: Fix leaking of partition name
2021-05-25 23:09 ` Ansuel Smith
@ 2021-05-25 23:16 ` Bjorn Andersson
-1 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2021-05-25 23:16 UTC (permalink / raw)
To: Ansuel Smith
Cc: Andy Gross, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Manivannan Sadhasivam, linux-arm-msm,
linux-mtd, linux-kernel
On Tue 25 May 18:09 CDT 2021, Ansuel Smith wrote:
> Add cleanup function as the name variable for the partition name was
> allocaed but never freed after the use as the add mtd function
> duplicate the name and free the pparts struct as the partition name is
> assumed to be static.
> The leak was found using kmemleak.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Fixes: 803eb124e1a6 ("mtd: parsers: Add Qcom SMEM parser")
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> drivers/mtd/parsers/qcomsmempart.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/mtd/parsers/qcomsmempart.c b/drivers/mtd/parsers/qcomsmempart.c
> index d9083308f6ba..06a818cd2433 100644
> --- a/drivers/mtd/parsers/qcomsmempart.c
> +++ b/drivers/mtd/parsers/qcomsmempart.c
> @@ -159,6 +159,15 @@ static int parse_qcomsmem_part(struct mtd_info *mtd,
> return ret;
> }
>
> +static void parse_qcomsmem_cleanup(const struct mtd_partition *pparts,
> + int nr_parts)
> +{
> + int i;
> +
> + for (i = 0; i < nr_parts; i++)
> + kfree(pparts[i].name);
> +}
> +
> static const struct of_device_id qcomsmem_of_match_table[] = {
> { .compatible = "qcom,smem-part" },
> {},
> @@ -167,6 +176,7 @@ MODULE_DEVICE_TABLE(of, qcomsmem_of_match_table);
>
> static struct mtd_part_parser mtd_parser_qcomsmem = {
> .parse_fn = parse_qcomsmem_part,
> + .cleanup = parse_qcomsmem_cleanup,
> .name = "qcomsmem",
> .of_match_table = qcomsmem_of_match_table,
> };
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mtd: parsers: qcom: Fix leaking of partition name
@ 2021-05-25 23:16 ` Bjorn Andersson
0 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2021-05-25 23:16 UTC (permalink / raw)
To: Ansuel Smith
Cc: Andy Gross, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Manivannan Sadhasivam, linux-arm-msm,
linux-mtd, linux-kernel
On Tue 25 May 18:09 CDT 2021, Ansuel Smith wrote:
> Add cleanup function as the name variable for the partition name was
> allocaed but never freed after the use as the add mtd function
> duplicate the name and free the pparts struct as the partition name is
> assumed to be static.
> The leak was found using kmemleak.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Fixes: 803eb124e1a6 ("mtd: parsers: Add Qcom SMEM parser")
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> drivers/mtd/parsers/qcomsmempart.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/mtd/parsers/qcomsmempart.c b/drivers/mtd/parsers/qcomsmempart.c
> index d9083308f6ba..06a818cd2433 100644
> --- a/drivers/mtd/parsers/qcomsmempart.c
> +++ b/drivers/mtd/parsers/qcomsmempart.c
> @@ -159,6 +159,15 @@ static int parse_qcomsmem_part(struct mtd_info *mtd,
> return ret;
> }
>
> +static void parse_qcomsmem_cleanup(const struct mtd_partition *pparts,
> + int nr_parts)
> +{
> + int i;
> +
> + for (i = 0; i < nr_parts; i++)
> + kfree(pparts[i].name);
> +}
> +
> static const struct of_device_id qcomsmem_of_match_table[] = {
> { .compatible = "qcom,smem-part" },
> {},
> @@ -167,6 +176,7 @@ MODULE_DEVICE_TABLE(of, qcomsmem_of_match_table);
>
> static struct mtd_part_parser mtd_parser_qcomsmem = {
> .parse_fn = parse_qcomsmem_part,
> + .cleanup = parse_qcomsmem_cleanup,
> .name = "qcomsmem",
> .of_match_table = qcomsmem_of_match_table,
> };
> --
> 2.31.1
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mtd: parsers: qcom: Fix leaking of partition name
2021-05-25 23:09 ` Ansuel Smith
@ 2021-05-26 6:02 ` Manivannan Sadhasivam
-1 siblings, 0 replies; 8+ messages in thread
From: Manivannan Sadhasivam @ 2021-05-26 6:02 UTC (permalink / raw)
To: Ansuel Smith
Cc: Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-arm-msm, linux-mtd, linux-kernel
On Wed, May 26, 2021 at 01:09:31AM +0200, Ansuel Smith wrote:
> Add cleanup function as the name variable for the partition name was
> allocaed but never freed after the use as the add mtd function
> duplicate the name and free the pparts struct as the partition name is
> assumed to be static.
> The leak was found using kmemleak.
>
> Fixes: 803eb124e1a6 ("mtd: parsers: Add Qcom SMEM parser")
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/mtd/parsers/qcomsmempart.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/mtd/parsers/qcomsmempart.c b/drivers/mtd/parsers/qcomsmempart.c
> index d9083308f6ba..06a818cd2433 100644
> --- a/drivers/mtd/parsers/qcomsmempart.c
> +++ b/drivers/mtd/parsers/qcomsmempart.c
> @@ -159,6 +159,15 @@ static int parse_qcomsmem_part(struct mtd_info *mtd,
> return ret;
> }
>
> +static void parse_qcomsmem_cleanup(const struct mtd_partition *pparts,
> + int nr_parts)
> +{
> + int i;
> +
> + for (i = 0; i < nr_parts; i++)
> + kfree(pparts[i].name);
> +}
> +
> static const struct of_device_id qcomsmem_of_match_table[] = {
> { .compatible = "qcom,smem-part" },
> {},
> @@ -167,6 +176,7 @@ MODULE_DEVICE_TABLE(of, qcomsmem_of_match_table);
>
> static struct mtd_part_parser mtd_parser_qcomsmem = {
> .parse_fn = parse_qcomsmem_part,
> + .cleanup = parse_qcomsmem_cleanup,
> .name = "qcomsmem",
> .of_match_table = qcomsmem_of_match_table,
> };
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mtd: parsers: qcom: Fix leaking of partition name
@ 2021-05-26 6:02 ` Manivannan Sadhasivam
0 siblings, 0 replies; 8+ messages in thread
From: Manivannan Sadhasivam @ 2021-05-26 6:02 UTC (permalink / raw)
To: Ansuel Smith
Cc: Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-arm-msm, linux-mtd, linux-kernel
On Wed, May 26, 2021 at 01:09:31AM +0200, Ansuel Smith wrote:
> Add cleanup function as the name variable for the partition name was
> allocaed but never freed after the use as the add mtd function
> duplicate the name and free the pparts struct as the partition name is
> assumed to be static.
> The leak was found using kmemleak.
>
> Fixes: 803eb124e1a6 ("mtd: parsers: Add Qcom SMEM parser")
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/mtd/parsers/qcomsmempart.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/mtd/parsers/qcomsmempart.c b/drivers/mtd/parsers/qcomsmempart.c
> index d9083308f6ba..06a818cd2433 100644
> --- a/drivers/mtd/parsers/qcomsmempart.c
> +++ b/drivers/mtd/parsers/qcomsmempart.c
> @@ -159,6 +159,15 @@ static int parse_qcomsmem_part(struct mtd_info *mtd,
> return ret;
> }
>
> +static void parse_qcomsmem_cleanup(const struct mtd_partition *pparts,
> + int nr_parts)
> +{
> + int i;
> +
> + for (i = 0; i < nr_parts; i++)
> + kfree(pparts[i].name);
> +}
> +
> static const struct of_device_id qcomsmem_of_match_table[] = {
> { .compatible = "qcom,smem-part" },
> {},
> @@ -167,6 +176,7 @@ MODULE_DEVICE_TABLE(of, qcomsmem_of_match_table);
>
> static struct mtd_part_parser mtd_parser_qcomsmem = {
> .parse_fn = parse_qcomsmem_part,
> + .cleanup = parse_qcomsmem_cleanup,
> .name = "qcomsmem",
> .of_match_table = qcomsmem_of_match_table,
> };
> --
> 2.31.1
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mtd: parsers: qcom: Fix leaking of partition name
2021-05-25 23:09 ` Ansuel Smith
@ 2021-05-26 9:02 ` Miquel Raynal
-1 siblings, 0 replies; 8+ messages in thread
From: Miquel Raynal @ 2021-05-26 9:02 UTC (permalink / raw)
To: Ansuel Smith, Andy Gross, Bjorn Andersson, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Manivannan Sadhasivam,
linux-arm-msm, linux-mtd, linux-kernel
On Tue, 2021-05-25 at 23:09:31 UTC, Ansuel Smith wrote:
> Add cleanup function as the name variable for the partition name was
> allocaed but never freed after the use as the add mtd function
> duplicate the name and free the pparts struct as the partition name is
> assumed to be static.
> The leak was found using kmemleak.
>
> Fixes: 803eb124e1a6 ("mtd: parsers: Add Qcom SMEM parser")
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mtd: parsers: qcom: Fix leaking of partition name
@ 2021-05-26 9:02 ` Miquel Raynal
0 siblings, 0 replies; 8+ messages in thread
From: Miquel Raynal @ 2021-05-26 9:02 UTC (permalink / raw)
To: Ansuel Smith, Andy Gross, Bjorn Andersson, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Manivannan Sadhasivam,
linux-arm-msm, linux-mtd, linux-kernel
On Tue, 2021-05-25 at 23:09:31 UTC, Ansuel Smith wrote:
> Add cleanup function as the name variable for the partition name was
> allocaed but never freed after the use as the add mtd function
> duplicate the name and free the pparts struct as the partition name is
> assumed to be static.
> The leak was found using kmemleak.
>
> Fixes: 803eb124e1a6 ("mtd: parsers: Add Qcom SMEM parser")
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-05-26 9:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 23:09 [PATCH v2] mtd: parsers: qcom: Fix leaking of partition name Ansuel Smith
2021-05-25 23:09 ` Ansuel Smith
2021-05-25 23:16 ` Bjorn Andersson
2021-05-25 23:16 ` Bjorn Andersson
2021-05-26 6:02 ` Manivannan Sadhasivam
2021-05-26 6:02 ` Manivannan Sadhasivam
2021-05-26 9:02 ` Miquel Raynal
2021-05-26 9:02 ` Miquel Raynal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.