* [PATCH v4] dt-binding: mtd: nand: Document the cs-gpios property
@ 2021-05-10 17:18 ` Miquel Raynal
0 siblings, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2021-05-10 17:18 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
linux-mtd, Naga Sureshkumar Relli, Michal Simek,
Thomas Petazzoni, Miquel Raynal
To reach higher capacities, arrays of chips are now pretty common.
Unfortunately, most of the controllers have been designed a decade ago
and did not all anticipate the need for several chip-selects. The new
cs-gpios property allows to workaround this limitation by adding as many
GPIO chip-select as needed.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
Resending only the binding patch of the series, with the following
changes requested by Rob:
* Fixed the coherency between cs-gpios and gpios-cs
* Added maxItems: 8 (this is a good enough value for most of the cases I
guess, this can be increased later if needed).
* Adding maxItems: 8 lead to an error when checking the example,
minItems: 8 had to be added as well to the schema to fix it, not sure
this was expected or not.
.../bindings/mtd/nand-controller.yaml | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
index 678b39952502..bd217e6f5018 100644
--- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
+++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
@@ -38,6 +38,17 @@ properties:
ranges: true
+ cs-gpios:
+ minItems: 1
+ maxItems: 8
+ description:
+ Array of chip-select available to the controller. The first
+ entries are a 1:1 mapping of the available chip-select on the
+ NAND controller (even if they are not used). As many additional
+ chip-select as needed may follow and should be phandles of GPIO
+ lines. 'reg' entries of the NAND chip subnodes become indexes of
+ this array when this property is present.
+
patternProperties:
"^nand@[a-f0-9]$":
type: object
@@ -164,14 +175,19 @@ examples:
nand-controller {
#address-cells = <1>;
#size-cells = <0>;
+ cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */
/* controller specific properties */
nand@0 {
- reg = <0>;
+ reg = <0>; /* Native CS */
nand-use-soft-ecc-engine;
nand-ecc-algo = "bch";
/* controller specific properties */
};
+
+ nand@1 {
+ reg = <1>; /* GPIO CS */
+ };
};
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v4] dt-binding: mtd: nand: Document the cs-gpios property
@ 2021-05-10 17:18 ` Miquel Raynal
0 siblings, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2021-05-10 17:18 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
linux-mtd, Naga Sureshkumar Relli, Michal Simek,
Thomas Petazzoni, Miquel Raynal
To reach higher capacities, arrays of chips are now pretty common.
Unfortunately, most of the controllers have been designed a decade ago
and did not all anticipate the need for several chip-selects. The new
cs-gpios property allows to workaround this limitation by adding as many
GPIO chip-select as needed.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
Resending only the binding patch of the series, with the following
changes requested by Rob:
* Fixed the coherency between cs-gpios and gpios-cs
* Added maxItems: 8 (this is a good enough value for most of the cases I
guess, this can be increased later if needed).
* Adding maxItems: 8 lead to an error when checking the example,
minItems: 8 had to be added as well to the schema to fix it, not sure
this was expected or not.
.../bindings/mtd/nand-controller.yaml | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
index 678b39952502..bd217e6f5018 100644
--- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
+++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
@@ -38,6 +38,17 @@ properties:
ranges: true
+ cs-gpios:
+ minItems: 1
+ maxItems: 8
+ description:
+ Array of chip-select available to the controller. The first
+ entries are a 1:1 mapping of the available chip-select on the
+ NAND controller (even if they are not used). As many additional
+ chip-select as needed may follow and should be phandles of GPIO
+ lines. 'reg' entries of the NAND chip subnodes become indexes of
+ this array when this property is present.
+
patternProperties:
"^nand@[a-f0-9]$":
type: object
@@ -164,14 +175,19 @@ examples:
nand-controller {
#address-cells = <1>;
#size-cells = <0>;
+ cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */
/* controller specific properties */
nand@0 {
- reg = <0>;
+ reg = <0>; /* Native CS */
nand-use-soft-ecc-engine;
nand-ecc-algo = "bch";
/* controller specific properties */
};
+
+ nand@1 {
+ reg = <1>; /* GPIO CS */
+ };
};
--
2.27.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-binding: mtd: nand: Document the cs-gpios property
2021-05-10 17:18 ` Miquel Raynal
@ 2021-05-11 16:24 ` Rob Herring
-1 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-05-11 16:24 UTC (permalink / raw)
To: Miquel Raynal
Cc: Tudor Ambarus, Michal Simek, linux-mtd, Rob Herring,
Vignesh Raghavendra, devicetree, Richard Weinberger,
Naga Sureshkumar Relli, Thomas Petazzoni
On Mon, 10 May 2021 19:18:00 +0200, Miquel Raynal wrote:
> To reach higher capacities, arrays of chips are now pretty common.
> Unfortunately, most of the controllers have been designed a decade ago
> and did not all anticipate the need for several chip-selects. The new
> cs-gpios property allows to workaround this limitation by adding as many
> GPIO chip-select as needed.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>
> Resending only the binding patch of the series, with the following
> changes requested by Rob:
> * Fixed the coherency between cs-gpios and gpios-cs
> * Added maxItems: 8 (this is a good enough value for most of the cases I
> guess, this can be increased later if needed).
> * Adding maxItems: 8 lead to an error when checking the example,
> minItems: 8 had to be added as well to the schema to fix it, not sure
> this was expected or not.
>
> .../bindings/mtd/nand-controller.yaml | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-binding: mtd: nand: Document the cs-gpios property
@ 2021-05-11 16:24 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-05-11 16:24 UTC (permalink / raw)
To: Miquel Raynal
Cc: Tudor Ambarus, Michal Simek, linux-mtd, Rob Herring,
Vignesh Raghavendra, devicetree, Richard Weinberger,
Naga Sureshkumar Relli, Thomas Petazzoni
On Mon, 10 May 2021 19:18:00 +0200, Miquel Raynal wrote:
> To reach higher capacities, arrays of chips are now pretty common.
> Unfortunately, most of the controllers have been designed a decade ago
> and did not all anticipate the need for several chip-selects. The new
> cs-gpios property allows to workaround this limitation by adding as many
> GPIO chip-select as needed.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>
> Resending only the binding patch of the series, with the following
> changes requested by Rob:
> * Fixed the coherency between cs-gpios and gpios-cs
> * Added maxItems: 8 (this is a good enough value for most of the cases I
> guess, this can be increased later if needed).
> * Adding maxItems: 8 lead to an error when checking the example,
> minItems: 8 had to be added as well to the schema to fix it, not sure
> this was expected or not.
>
> .../bindings/mtd/nand-controller.yaml | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-binding: mtd: nand: Document the cs-gpios property
2021-05-10 17:18 ` Miquel Raynal
@ 2021-05-26 9:03 ` Miquel Raynal
-1 siblings, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2021-05-26 9:03 UTC (permalink / raw)
To: Miquel Raynal, Rob Herring, devicetree
Cc: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
linux-mtd, Naga Sureshkumar Relli, Michal Simek,
Thomas Petazzoni
On Mon, 2021-05-10 at 17:18:00 UTC, Miquel Raynal wrote:
> To reach higher capacities, arrays of chips are now pretty common.
> Unfortunately, most of the controllers have been designed a decade ago
> and did not all anticipate the need for several chip-selects. The new
> cs-gpios property allows to workaround this limitation by adding as many
> GPIO chip-select as needed.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next.
Miquel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-binding: mtd: nand: Document the cs-gpios property
@ 2021-05-26 9:03 ` Miquel Raynal
0 siblings, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2021-05-26 9:03 UTC (permalink / raw)
To: Miquel Raynal, Rob Herring, devicetree
Cc: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
linux-mtd, Naga Sureshkumar Relli, Michal Simek,
Thomas Petazzoni
On Mon, 2021-05-10 at 17:18:00 UTC, Miquel Raynal wrote:
> To reach higher capacities, arrays of chips are now pretty common.
> Unfortunately, most of the controllers have been designed a decade ago
> and did not all anticipate the need for several chip-selects. The new
> cs-gpios property allows to workaround this limitation by adding as many
> GPIO chip-select as needed.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-26 9:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 17:18 [PATCH v4] dt-binding: mtd: nand: Document the cs-gpios property Miquel Raynal
2021-05-10 17:18 ` Miquel Raynal
2021-05-11 16:24 ` Rob Herring
2021-05-11 16:24 ` Rob Herring
2021-05-26 9:03 ` Miquel Raynal
2021-05-26 9:03 ` Miquel Raynal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.