From: Ali Abdallah <ali.abdallah@suse.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: conntrack: add new sysctl to disable RST check
Date: Wed, 26 May 2021 17:12:03 +0200 [thread overview]
Message-ID: <20210526151203.rncl2c2vu5hgc6fx@Fryzen495> (raw)
In-Reply-To: <97089f6c-9889-0824-8aea-6fada4a93b20@6wind.com>
On 26.05.2021 17:06, Nicolas Dichtel wrote:
> Le 26/05/2021 à 16:34, Ali Abdallah a écrit :
> > That what the doc on nf_conntrack_tcp_be_liberal says as well, logically
> > not 0 is 1, so IMHO I don't think that can lead to confusion.
>
> There is a lot of sysctl that have several magic values, see
> https://www.kernel.org/doc/Documentation/networking/ip-sysctl.txt
>
> And some act like boolean but accept all values,
> /proc/sys/net/ipv4/conf/*/forwarding for example.
>
> There is nothing obvious with sysctl values (and a lot of inconsistencies), it's
> why I suggest to be explicit.
Yes, I absolutely see your point, and I have no problem in making that
explicit, I will sent a v2 patch saying explicitly that only "1" would
disable RST seq number checks, hopefully it gets merged soon.
> Regards,
> Nicolas
Kind Regards,
Ali
next prev parent reply other threads:[~2021-05-26 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 9:24 [PATCH] netfilter: conntrack: add new sysctl to disable RST check Ali Abdallah
2021-05-26 14:29 ` Nicolas Dichtel
2021-05-26 14:34 ` Ali Abdallah
2021-05-26 15:06 ` Nicolas Dichtel
2021-05-26 15:12 ` Ali Abdallah [this message]
2021-05-28 9:15 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526151203.rncl2c2vu5hgc6fx@Fryzen495 \
--to=ali.abdallah@suse.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.