All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Ali Abdallah <ali.abdallah@suse.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: conntrack: add new sysctl to disable RST check
Date: Fri, 28 May 2021 11:15:51 +0200	[thread overview]
Message-ID: <20210528091551.GA30879@breakpoint.cc> (raw)
In-Reply-To: <20210526092444.lca726ghsrli5fpx@Fryzen495>

Ali Abdallah <ali.abdallah@suse.com> wrote:
> This patch adds a new sysctl tcp_ignore_invalid_rst to disable marking
> out of segments RSTs as INVALID.

Just for archives:
I am not sure this is still needed after the recent change, but I can
see why its desirable to keep NAT working even when RST is invalid.

I think that the more fundamental problem is the inability to permit
setting a conntrack as INVALID while allowing NAT to work, i.e. move
drop decision to ruleset.

However, I see that this isn't easy to change.  Therefore,

Reviewed-by: Florian Westphal <fw@strlen.de>

      parent reply	other threads:[~2021-05-28  9:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  9:24 [PATCH] netfilter: conntrack: add new sysctl to disable RST check Ali Abdallah
2021-05-26 14:29 ` Nicolas Dichtel
2021-05-26 14:34   ` Ali Abdallah
2021-05-26 15:06     ` Nicolas Dichtel
2021-05-26 15:12       ` Ali Abdallah
2021-05-28  9:15 ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210528091551.GA30879@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=ali.abdallah@suse.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.