* Re: [PATCH 21/24] usb: host: xhci: Move array of structs from the stack onto the heap
@ 2021-05-26 18:45 kernel test robot
2021-05-26 18:45 ` [PATCH] usb: host: xhci: fix call_kern.cocci warnings kernel test robot
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-05-26 18:45 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1690 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210526130037.856068-22-lee.jones@linaro.org>
References: <20210526130037.856068-22-lee.jones@linaro.org>
TO: Lee Jones <lee.jones@linaro.org>
TO: lee.jones(a)linaro.org
CC: linux-kernel(a)vger.kernel.org
CC: Mathias Nyman <mathias.nyman@intel.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: linux-usb(a)vger.kernel.org
Hi Lee,
I love your patch! Perhaps something to improve:
[auto build test WARNING on peter.chen-usb/for-usb-next]
[also build test WARNING on usb/usb-testing v5.13-rc3]
[cannot apply to balbi-usb/testing/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lee-Jones/Rid-W-1-warnings-from-USB/20210526-210403
base: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git for-usb-next
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
config: riscv-randconfig-c004-20210526 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/usb/host/xhci.c:2791:48-58: ERROR: function xhci_reserve_bandwidth called on line 2911 inside lock on line 2885 but uses GFP_KERNEL
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27732 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] usb: host: xhci: fix call_kern.cocci warnings
2021-05-26 18:45 [PATCH 21/24] usb: host: xhci: Move array of structs from the stack onto the heap kernel test robot
@ 2021-05-26 18:45 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-05-26 18:45 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1793 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210526130037.856068-22-lee.jones@linaro.org>
References: <20210526130037.856068-22-lee.jones@linaro.org>
TO: Lee Jones <lee.jones@linaro.org>
TO: lee.jones(a)linaro.org
CC: linux-kernel(a)vger.kernel.org
CC: Mathias Nyman <mathias.nyman@intel.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: linux-usb(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/usb/host/xhci.c:2791:48-58: ERROR: function xhci_reserve_bandwidth called on line 2911 inside lock on line 2885 but uses GFP_KERNEL
Find functions that refer to GFP_KERNEL but are called with locks held.
Semantic patch information:
The proposed change of converting the GFP_KERNEL is not necessarily the
correct one. It may be desired to unlock the lock, or to not call the
function under the lock in the first place.
Generated by: scripts/coccinelle/locks/call_kern.cocci
CC: Lee Jones <lee.jones@linaro.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Lee-Jones/Rid-W-1-warnings-from-USB/20210526-210403
base: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git for-usb-next
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
Please take the patch only if it's a positive warning. Thanks!
xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -2788,7 +2788,7 @@ static int xhci_reserve_bandwidth(struct
return -ENOMEM;
}
- ep_bw_info = kzalloc(sizeof(*ep_bw_info) * 31, GFP_KERNEL);
+ ep_bw_info = kzalloc(sizeof(*ep_bw_info) * 31, GFP_ATOMIC);
if (!ep_bw_info)
return -ENOMEM;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-26 18:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 18:45 [PATCH 21/24] usb: host: xhci: Move array of structs from the stack onto the heap kernel test robot
2021-05-26 18:45 ` [PATCH] usb: host: xhci: fix call_kern.cocci warnings kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.