* [PATCH] drm/i915: Use generic_access_phys
@ 2021-05-26 15:11 ` Daniel Vetter
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Vetter @ 2021-05-26 15:11 UTC (permalink / raw)
To: Intel Graphics Development
Cc: Thomas Hellström, Daniel Vetter, DRI Development,
Chris Wilson, Jon Bloomfield, Daniel Vetter, Andrew Morton,
Michel Lespinasse, Christian König
Since
commit 96667f8a4382db9ed042332ca6ee165ae9b91307
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Fri Nov 27 17:41:21 2020 +0100
mm: Close race in generic_access_phys
it is race-free and can therefore be safely used for dynamic mappings
like we have too.
Cc: Jon Bloomfield <jon.bloomfield@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Michel Lespinasse <walken@google.com>
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 60 +++---------------------
1 file changed, 6 insertions(+), 54 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index f6fe5cb01438..717798293044 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -414,58 +414,6 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)
return i915_error_to_vmf_fault(ret);
}
-static int
-vm_access(struct vm_area_struct *area, unsigned long addr,
- void *buf, int len, int write)
-{
- struct i915_mmap_offset *mmo = area->vm_private_data;
- struct drm_i915_gem_object *obj = mmo->obj;
- struct i915_gem_ww_ctx ww;
- void *vaddr;
- int err = 0;
-
- if (i915_gem_object_is_readonly(obj) && write)
- return -EACCES;
-
- addr -= area->vm_start;
- if (addr >= obj->base.size)
- return -EINVAL;
-
- i915_gem_ww_ctx_init(&ww, true);
-retry:
- err = i915_gem_object_lock(obj, &ww);
- if (err)
- goto out;
-
- /* As this is primarily for debugging, let's focus on simplicity */
- vaddr = i915_gem_object_pin_map(obj, I915_MAP_FORCE_WC);
- if (IS_ERR(vaddr)) {
- err = PTR_ERR(vaddr);
- goto out;
- }
-
- if (write) {
- memcpy(vaddr + addr, buf, len);
- __i915_gem_object_flush_map(obj, addr, len);
- } else {
- memcpy(buf, vaddr + addr, len);
- }
-
- i915_gem_object_unpin_map(obj);
-out:
- if (err == -EDEADLK) {
- err = i915_gem_ww_ctx_backoff(&ww);
- if (!err)
- goto retry;
- }
- i915_gem_ww_ctx_fini(&ww);
-
- if (err)
- return err;
-
- return len;
-}
-
void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
{
struct i915_vma *vma;
@@ -801,14 +749,18 @@ static void vm_close(struct vm_area_struct *vma)
static const struct vm_operations_struct vm_ops_gtt = {
.fault = vm_fault_gtt,
- .access = vm_access,
+#ifdef CONFIG_HAVE_IOREMAP_PROT
+ .access = generic_access_phys
+#endif
.open = vm_open,
.close = vm_close,
};
static const struct vm_operations_struct vm_ops_cpu = {
.fault = vm_fault_cpu,
- .access = vm_access,
+#ifdef CONFIG_HAVE_IOREMAP_PROT
+ .access = generic_access_phys
+#endif
.open = vm_open,
.close = vm_close,
};
--
2.31.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Use generic_access_phys
@ 2021-05-26 15:11 ` Daniel Vetter
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Vetter @ 2021-05-26 15:11 UTC (permalink / raw)
To: Intel Graphics Development
Cc: Thomas Hellström, Daniel Vetter, DRI Development,
Chris Wilson, Daniel Vetter, Andrew Morton, Michel Lespinasse,
Christian König
Since
commit 96667f8a4382db9ed042332ca6ee165ae9b91307
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Fri Nov 27 17:41:21 2020 +0100
mm: Close race in generic_access_phys
it is race-free and can therefore be safely used for dynamic mappings
like we have too.
Cc: Jon Bloomfield <jon.bloomfield@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Michel Lespinasse <walken@google.com>
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 60 +++---------------------
1 file changed, 6 insertions(+), 54 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index f6fe5cb01438..717798293044 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -414,58 +414,6 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)
return i915_error_to_vmf_fault(ret);
}
-static int
-vm_access(struct vm_area_struct *area, unsigned long addr,
- void *buf, int len, int write)
-{
- struct i915_mmap_offset *mmo = area->vm_private_data;
- struct drm_i915_gem_object *obj = mmo->obj;
- struct i915_gem_ww_ctx ww;
- void *vaddr;
- int err = 0;
-
- if (i915_gem_object_is_readonly(obj) && write)
- return -EACCES;
-
- addr -= area->vm_start;
- if (addr >= obj->base.size)
- return -EINVAL;
-
- i915_gem_ww_ctx_init(&ww, true);
-retry:
- err = i915_gem_object_lock(obj, &ww);
- if (err)
- goto out;
-
- /* As this is primarily for debugging, let's focus on simplicity */
- vaddr = i915_gem_object_pin_map(obj, I915_MAP_FORCE_WC);
- if (IS_ERR(vaddr)) {
- err = PTR_ERR(vaddr);
- goto out;
- }
-
- if (write) {
- memcpy(vaddr + addr, buf, len);
- __i915_gem_object_flush_map(obj, addr, len);
- } else {
- memcpy(buf, vaddr + addr, len);
- }
-
- i915_gem_object_unpin_map(obj);
-out:
- if (err == -EDEADLK) {
- err = i915_gem_ww_ctx_backoff(&ww);
- if (!err)
- goto retry;
- }
- i915_gem_ww_ctx_fini(&ww);
-
- if (err)
- return err;
-
- return len;
-}
-
void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
{
struct i915_vma *vma;
@@ -801,14 +749,18 @@ static void vm_close(struct vm_area_struct *vma)
static const struct vm_operations_struct vm_ops_gtt = {
.fault = vm_fault_gtt,
- .access = vm_access,
+#ifdef CONFIG_HAVE_IOREMAP_PROT
+ .access = generic_access_phys
+#endif
.open = vm_open,
.close = vm_close,
};
static const struct vm_operations_struct vm_ops_cpu = {
.fault = vm_fault_cpu,
- .access = vm_access,
+#ifdef CONFIG_HAVE_IOREMAP_PROT
+ .access = generic_access_phys
+#endif
.open = vm_open,
.close = vm_close,
};
--
2.31.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] drm/i915: Use generic_access_phys
2021-05-26 15:11 ` [Intel-gfx] " Daniel Vetter
@ 2021-05-26 15:30 ` Daniel Vetter
-1 siblings, 0 replies; 16+ messages in thread
From: Daniel Vetter @ 2021-05-26 15:30 UTC (permalink / raw)
To: Intel Graphics Development
Cc: Thomas Hellström, Daniel Vetter, DRI Development,
Chris Wilson, Jon Bloomfield, Daniel Vetter, Andrew Morton,
Michel Lespinasse, Christian König
Since
commit 96667f8a4382db9ed042332ca6ee165ae9b91307
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Fri Nov 27 17:41:21 2020 +0100
mm: Close race in generic_access_phys
it is race-free and can therefore be safely used for dynamic mappings
like we have too.
v2 git commit --amend
*sigh*
Cc: Jon Bloomfield <jon.bloomfield@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Michel Lespinasse <walken@google.com>
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 60 +++---------------------
1 file changed, 6 insertions(+), 54 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index f6fe5cb01438..16a059d54bda 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -414,58 +414,6 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)
return i915_error_to_vmf_fault(ret);
}
-static int
-vm_access(struct vm_area_struct *area, unsigned long addr,
- void *buf, int len, int write)
-{
- struct i915_mmap_offset *mmo = area->vm_private_data;
- struct drm_i915_gem_object *obj = mmo->obj;
- struct i915_gem_ww_ctx ww;
- void *vaddr;
- int err = 0;
-
- if (i915_gem_object_is_readonly(obj) && write)
- return -EACCES;
-
- addr -= area->vm_start;
- if (addr >= obj->base.size)
- return -EINVAL;
-
- i915_gem_ww_ctx_init(&ww, true);
-retry:
- err = i915_gem_object_lock(obj, &ww);
- if (err)
- goto out;
-
- /* As this is primarily for debugging, let's focus on simplicity */
- vaddr = i915_gem_object_pin_map(obj, I915_MAP_FORCE_WC);
- if (IS_ERR(vaddr)) {
- err = PTR_ERR(vaddr);
- goto out;
- }
-
- if (write) {
- memcpy(vaddr + addr, buf, len);
- __i915_gem_object_flush_map(obj, addr, len);
- } else {
- memcpy(buf, vaddr + addr, len);
- }
-
- i915_gem_object_unpin_map(obj);
-out:
- if (err == -EDEADLK) {
- err = i915_gem_ww_ctx_backoff(&ww);
- if (!err)
- goto retry;
- }
- i915_gem_ww_ctx_fini(&ww);
-
- if (err)
- return err;
-
- return len;
-}
-
void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
{
struct i915_vma *vma;
@@ -801,14 +749,18 @@ static void vm_close(struct vm_area_struct *vma)
static const struct vm_operations_struct vm_ops_gtt = {
.fault = vm_fault_gtt,
- .access = vm_access,
+#ifdef CONFIG_HAVE_IOREMAP_PROT
+ .access = generic_access_phys,
+#endif
.open = vm_open,
.close = vm_close,
};
static const struct vm_operations_struct vm_ops_cpu = {
.fault = vm_fault_cpu,
- .access = vm_access,
+#ifdef CONFIG_HAVE_IOREMAP_PROT
+ .access = generic_access_phys,
+#endif
.open = vm_open,
.close = vm_close,
};
--
2.31.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Use generic_access_phys
@ 2021-05-26 15:30 ` Daniel Vetter
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Vetter @ 2021-05-26 15:30 UTC (permalink / raw)
To: Intel Graphics Development
Cc: Thomas Hellström, Daniel Vetter, DRI Development,
Chris Wilson, Daniel Vetter, Andrew Morton, Michel Lespinasse,
Christian König
Since
commit 96667f8a4382db9ed042332ca6ee165ae9b91307
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Fri Nov 27 17:41:21 2020 +0100
mm: Close race in generic_access_phys
it is race-free and can therefore be safely used for dynamic mappings
like we have too.
v2 git commit --amend
*sigh*
Cc: Jon Bloomfield <jon.bloomfield@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Michel Lespinasse <walken@google.com>
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 60 +++---------------------
1 file changed, 6 insertions(+), 54 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index f6fe5cb01438..16a059d54bda 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -414,58 +414,6 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)
return i915_error_to_vmf_fault(ret);
}
-static int
-vm_access(struct vm_area_struct *area, unsigned long addr,
- void *buf, int len, int write)
-{
- struct i915_mmap_offset *mmo = area->vm_private_data;
- struct drm_i915_gem_object *obj = mmo->obj;
- struct i915_gem_ww_ctx ww;
- void *vaddr;
- int err = 0;
-
- if (i915_gem_object_is_readonly(obj) && write)
- return -EACCES;
-
- addr -= area->vm_start;
- if (addr >= obj->base.size)
- return -EINVAL;
-
- i915_gem_ww_ctx_init(&ww, true);
-retry:
- err = i915_gem_object_lock(obj, &ww);
- if (err)
- goto out;
-
- /* As this is primarily for debugging, let's focus on simplicity */
- vaddr = i915_gem_object_pin_map(obj, I915_MAP_FORCE_WC);
- if (IS_ERR(vaddr)) {
- err = PTR_ERR(vaddr);
- goto out;
- }
-
- if (write) {
- memcpy(vaddr + addr, buf, len);
- __i915_gem_object_flush_map(obj, addr, len);
- } else {
- memcpy(buf, vaddr + addr, len);
- }
-
- i915_gem_object_unpin_map(obj);
-out:
- if (err == -EDEADLK) {
- err = i915_gem_ww_ctx_backoff(&ww);
- if (!err)
- goto retry;
- }
- i915_gem_ww_ctx_fini(&ww);
-
- if (err)
- return err;
-
- return len;
-}
-
void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
{
struct i915_vma *vma;
@@ -801,14 +749,18 @@ static void vm_close(struct vm_area_struct *vma)
static const struct vm_operations_struct vm_ops_gtt = {
.fault = vm_fault_gtt,
- .access = vm_access,
+#ifdef CONFIG_HAVE_IOREMAP_PROT
+ .access = generic_access_phys,
+#endif
.open = vm_open,
.close = vm_close,
};
static const struct vm_operations_struct vm_ops_cpu = {
.fault = vm_fault_cpu,
- .access = vm_access,
+#ifdef CONFIG_HAVE_IOREMAP_PROT
+ .access = generic_access_phys,
+#endif
.open = vm_open,
.close = vm_close,
};
--
2.31.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915: Use generic_access_phys
2021-05-26 15:11 ` [Intel-gfx] " Daniel Vetter
(?)
(?)
@ 2021-05-26 18:54 ` kernel test robot
-1 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-05-26 18:54 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics Development
Cc: kbuild-all, Thomas Hellström, Daniel Vetter,
DRI Development, Chris Wilson, Jon Bloomfield, Andrew Morton,
Linux Memory Management List, Michel Lespinasse,
Christian König
[-- Attachment #1: Type: text/plain, Size: 2419 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a001-20210526 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/80157be9e8542ce9a835e6f159408b951590b578
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
git checkout 80157be9e8542ce9a835e6f159408b951590b578
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gem/i915_gem_mman.c:755:2: error: request for member 'open' in something not a structure or union
755 | .open = vm_open,
| ^
drivers/gpu/drm/i915/gem/i915_gem_mman.c:764:2: error: request for member 'open' in something not a structure or union
764 | .open = vm_open,
| ^
vim +/open +755 drivers/gpu/drm/i915/gem/i915_gem_mman.c
cc662126b4134e2 Abdiel Janulgue 2019-12-04 749
cc662126b4134e2 Abdiel Janulgue 2019-12-04 750 static const struct vm_operations_struct vm_ops_gtt = {
cc662126b4134e2 Abdiel Janulgue 2019-12-04 751 .fault = vm_fault_gtt,
80157be9e8542ce Daniel Vetter 2021-05-26 752 #ifdef CONFIG_HAVE_IOREMAP_PROT
80157be9e8542ce Daniel Vetter 2021-05-26 753 .access = generic_access_phys
80157be9e8542ce Daniel Vetter 2021-05-26 754 #endif
cc662126b4134e2 Abdiel Janulgue 2019-12-04 @755 .open = vm_open,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 756 .close = vm_close,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 757 };
cc662126b4134e2 Abdiel Janulgue 2019-12-04 758
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40661 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915: Use generic_access_phys
@ 2021-05-26 18:54 ` kernel test robot
0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-05-26 18:54 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics Development
Cc: Thomas Hellström, kbuild-all, Daniel Vetter,
DRI Development, Chris Wilson, Linux Memory Management List,
Jon Bloomfield, Andrew Morton, Michel Lespinasse,
Christian König
[-- Attachment #1: Type: text/plain, Size: 2419 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a001-20210526 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/80157be9e8542ce9a835e6f159408b951590b578
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
git checkout 80157be9e8542ce9a835e6f159408b951590b578
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gem/i915_gem_mman.c:755:2: error: request for member 'open' in something not a structure or union
755 | .open = vm_open,
| ^
drivers/gpu/drm/i915/gem/i915_gem_mman.c:764:2: error: request for member 'open' in something not a structure or union
764 | .open = vm_open,
| ^
vim +/open +755 drivers/gpu/drm/i915/gem/i915_gem_mman.c
cc662126b4134e2 Abdiel Janulgue 2019-12-04 749
cc662126b4134e2 Abdiel Janulgue 2019-12-04 750 static const struct vm_operations_struct vm_ops_gtt = {
cc662126b4134e2 Abdiel Janulgue 2019-12-04 751 .fault = vm_fault_gtt,
80157be9e8542ce Daniel Vetter 2021-05-26 752 #ifdef CONFIG_HAVE_IOREMAP_PROT
80157be9e8542ce Daniel Vetter 2021-05-26 753 .access = generic_access_phys
80157be9e8542ce Daniel Vetter 2021-05-26 754 #endif
cc662126b4134e2 Abdiel Janulgue 2019-12-04 @755 .open = vm_open,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 756 .close = vm_close,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 757 };
cc662126b4134e2 Abdiel Janulgue 2019-12-04 758
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40661 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Use generic_access_phys
@ 2021-05-26 18:54 ` kernel test robot
0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-05-26 18:54 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics Development
Cc: Thomas Hellström, kbuild-all, Daniel Vetter,
DRI Development, Chris Wilson, Linux Memory Management List,
Andrew Morton, Michel Lespinasse, Christian König
[-- Attachment #1: Type: text/plain, Size: 2419 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a001-20210526 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/80157be9e8542ce9a835e6f159408b951590b578
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
git checkout 80157be9e8542ce9a835e6f159408b951590b578
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gem/i915_gem_mman.c:755:2: error: request for member 'open' in something not a structure or union
755 | .open = vm_open,
| ^
drivers/gpu/drm/i915/gem/i915_gem_mman.c:764:2: error: request for member 'open' in something not a structure or union
764 | .open = vm_open,
| ^
vim +/open +755 drivers/gpu/drm/i915/gem/i915_gem_mman.c
cc662126b4134e2 Abdiel Janulgue 2019-12-04 749
cc662126b4134e2 Abdiel Janulgue 2019-12-04 750 static const struct vm_operations_struct vm_ops_gtt = {
cc662126b4134e2 Abdiel Janulgue 2019-12-04 751 .fault = vm_fault_gtt,
80157be9e8542ce Daniel Vetter 2021-05-26 752 #ifdef CONFIG_HAVE_IOREMAP_PROT
80157be9e8542ce Daniel Vetter 2021-05-26 753 .access = generic_access_phys
80157be9e8542ce Daniel Vetter 2021-05-26 754 #endif
cc662126b4134e2 Abdiel Janulgue 2019-12-04 @755 .open = vm_open,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 756 .close = vm_close,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 757 };
cc662126b4134e2 Abdiel Janulgue 2019-12-04 758
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40661 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915: Use generic_access_phys
@ 2021-05-26 18:54 ` kernel test robot
0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-05-26 18:54 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2472 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a001-20210526 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/80157be9e8542ce9a835e6f159408b951590b578
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
git checkout 80157be9e8542ce9a835e6f159408b951590b578
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gem/i915_gem_mman.c:755:2: error: request for member 'open' in something not a structure or union
755 | .open = vm_open,
| ^
drivers/gpu/drm/i915/gem/i915_gem_mman.c:764:2: error: request for member 'open' in something not a structure or union
764 | .open = vm_open,
| ^
vim +/open +755 drivers/gpu/drm/i915/gem/i915_gem_mman.c
cc662126b4134e2 Abdiel Janulgue 2019-12-04 749
cc662126b4134e2 Abdiel Janulgue 2019-12-04 750 static const struct vm_operations_struct vm_ops_gtt = {
cc662126b4134e2 Abdiel Janulgue 2019-12-04 751 .fault = vm_fault_gtt,
80157be9e8542ce Daniel Vetter 2021-05-26 752 #ifdef CONFIG_HAVE_IOREMAP_PROT
80157be9e8542ce Daniel Vetter 2021-05-26 753 .access = generic_access_phys
80157be9e8542ce Daniel Vetter 2021-05-26 754 #endif
cc662126b4134e2 Abdiel Janulgue 2019-12-04 @755 .open = vm_open,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 756 .close = vm_close,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 757 };
cc662126b4134e2 Abdiel Janulgue 2019-12-04 758
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40661 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915: Use generic_access_phys
2021-05-26 15:11 ` [Intel-gfx] " Daniel Vetter
(?)
(?)
@ 2021-05-26 20:33 ` kernel test robot
-1 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-05-26 20:33 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics Development
Cc: kbuild-all, clang-built-linux, Thomas Hellström,
Daniel Vetter, DRI Development, Chris Wilson, Jon Bloomfield,
Andrew Morton, Linux Memory Management List, Michel Lespinasse,
Christian König
[-- Attachment #1: Type: text/plain, Size: 2930 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-r025-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/80157be9e8542ce9a835e6f159408b951590b578
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
git checkout 80157be9e8542ce9a835e6f159408b951590b578
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gem/i915_gem_mman.c:755:2: error: member reference base type 'int (struct vm_area_struct *, unsigned long, void *, int, int)' is not a structure or union
.open = vm_open,
^~~~~
drivers/gpu/drm/i915/gem/i915_gem_mman.c:764:2: error: member reference base type 'int (struct vm_area_struct *, unsigned long, void *, int, int)' is not a structure or union
.open = vm_open,
^~~~~
2 errors generated.
vim +755 drivers/gpu/drm/i915/gem/i915_gem_mman.c
cc662126b4134e2 Abdiel Janulgue 2019-12-04 749
cc662126b4134e2 Abdiel Janulgue 2019-12-04 750 static const struct vm_operations_struct vm_ops_gtt = {
cc662126b4134e2 Abdiel Janulgue 2019-12-04 751 .fault = vm_fault_gtt,
80157be9e8542ce Daniel Vetter 2021-05-26 752 #ifdef CONFIG_HAVE_IOREMAP_PROT
80157be9e8542ce Daniel Vetter 2021-05-26 753 .access = generic_access_phys
80157be9e8542ce Daniel Vetter 2021-05-26 754 #endif
cc662126b4134e2 Abdiel Janulgue 2019-12-04 @755 .open = vm_open,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 756 .close = vm_close,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 757 };
cc662126b4134e2 Abdiel Janulgue 2019-12-04 758
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38291 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915: Use generic_access_phys
@ 2021-05-26 20:33 ` kernel test robot
0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-05-26 20:33 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics Development
Cc: Thomas Hellström, kbuild-all, Linux Memory Management List,
Daniel Vetter, DRI Development, Chris Wilson, clang-built-linux,
Jon Bloomfield, Andrew Morton, Michel Lespinasse,
Christian König
[-- Attachment #1: Type: text/plain, Size: 2930 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-r025-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/80157be9e8542ce9a835e6f159408b951590b578
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
git checkout 80157be9e8542ce9a835e6f159408b951590b578
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gem/i915_gem_mman.c:755:2: error: member reference base type 'int (struct vm_area_struct *, unsigned long, void *, int, int)' is not a structure or union
.open = vm_open,
^~~~~
drivers/gpu/drm/i915/gem/i915_gem_mman.c:764:2: error: member reference base type 'int (struct vm_area_struct *, unsigned long, void *, int, int)' is not a structure or union
.open = vm_open,
^~~~~
2 errors generated.
vim +755 drivers/gpu/drm/i915/gem/i915_gem_mman.c
cc662126b4134e2 Abdiel Janulgue 2019-12-04 749
cc662126b4134e2 Abdiel Janulgue 2019-12-04 750 static const struct vm_operations_struct vm_ops_gtt = {
cc662126b4134e2 Abdiel Janulgue 2019-12-04 751 .fault = vm_fault_gtt,
80157be9e8542ce Daniel Vetter 2021-05-26 752 #ifdef CONFIG_HAVE_IOREMAP_PROT
80157be9e8542ce Daniel Vetter 2021-05-26 753 .access = generic_access_phys
80157be9e8542ce Daniel Vetter 2021-05-26 754 #endif
cc662126b4134e2 Abdiel Janulgue 2019-12-04 @755 .open = vm_open,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 756 .close = vm_close,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 757 };
cc662126b4134e2 Abdiel Janulgue 2019-12-04 758
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38291 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Use generic_access_phys
@ 2021-05-26 20:33 ` kernel test robot
0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-05-26 20:33 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics Development
Cc: Thomas Hellström, kbuild-all, Linux Memory Management List,
Daniel Vetter, DRI Development, Chris Wilson, clang-built-linux,
Andrew Morton, Michel Lespinasse, Christian König
[-- Attachment #1: Type: text/plain, Size: 2930 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-r025-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/80157be9e8542ce9a835e6f159408b951590b578
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
git checkout 80157be9e8542ce9a835e6f159408b951590b578
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gem/i915_gem_mman.c:755:2: error: member reference base type 'int (struct vm_area_struct *, unsigned long, void *, int, int)' is not a structure or union
.open = vm_open,
^~~~~
drivers/gpu/drm/i915/gem/i915_gem_mman.c:764:2: error: member reference base type 'int (struct vm_area_struct *, unsigned long, void *, int, int)' is not a structure or union
.open = vm_open,
^~~~~
2 errors generated.
vim +755 drivers/gpu/drm/i915/gem/i915_gem_mman.c
cc662126b4134e2 Abdiel Janulgue 2019-12-04 749
cc662126b4134e2 Abdiel Janulgue 2019-12-04 750 static const struct vm_operations_struct vm_ops_gtt = {
cc662126b4134e2 Abdiel Janulgue 2019-12-04 751 .fault = vm_fault_gtt,
80157be9e8542ce Daniel Vetter 2021-05-26 752 #ifdef CONFIG_HAVE_IOREMAP_PROT
80157be9e8542ce Daniel Vetter 2021-05-26 753 .access = generic_access_phys
80157be9e8542ce Daniel Vetter 2021-05-26 754 #endif
cc662126b4134e2 Abdiel Janulgue 2019-12-04 @755 .open = vm_open,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 756 .close = vm_close,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 757 };
cc662126b4134e2 Abdiel Janulgue 2019-12-04 758
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38291 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915: Use generic_access_phys
@ 2021-05-26 20:33 ` kernel test robot
0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-05-26 20:33 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2988 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-r025-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/80157be9e8542ce9a835e6f159408b951590b578
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425
git checkout 80157be9e8542ce9a835e6f159408b951590b578
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gem/i915_gem_mman.c:755:2: error: member reference base type 'int (struct vm_area_struct *, unsigned long, void *, int, int)' is not a structure or union
.open = vm_open,
^~~~~
drivers/gpu/drm/i915/gem/i915_gem_mman.c:764:2: error: member reference base type 'int (struct vm_area_struct *, unsigned long, void *, int, int)' is not a structure or union
.open = vm_open,
^~~~~
2 errors generated.
vim +755 drivers/gpu/drm/i915/gem/i915_gem_mman.c
cc662126b4134e2 Abdiel Janulgue 2019-12-04 749
cc662126b4134e2 Abdiel Janulgue 2019-12-04 750 static const struct vm_operations_struct vm_ops_gtt = {
cc662126b4134e2 Abdiel Janulgue 2019-12-04 751 .fault = vm_fault_gtt,
80157be9e8542ce Daniel Vetter 2021-05-26 752 #ifdef CONFIG_HAVE_IOREMAP_PROT
80157be9e8542ce Daniel Vetter 2021-05-26 753 .access = generic_access_phys
80157be9e8542ce Daniel Vetter 2021-05-26 754 #endif
cc662126b4134e2 Abdiel Janulgue 2019-12-04 @755 .open = vm_open,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 756 .close = vm_close,
cc662126b4134e2 Abdiel Janulgue 2019-12-04 757 };
cc662126b4134e2 Abdiel Janulgue 2019-12-04 758
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38291 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Use generic_access_phys (rev2)
2021-05-26 15:11 ` [Intel-gfx] " Daniel Vetter
` (3 preceding siblings ...)
(?)
@ 2021-05-26 21:50 ` Patchwork
-1 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2021-05-26 21:50 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Use generic_access_phys (rev2)
URL : https://patchwork.freedesktop.org/series/90616/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
12c4102fd7e8 drm/i915: Use generic_access_phys
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 96667f8a4382 ("mm: Close race in generic_access_phys")'
#11:
commit 96667f8a4382db9ed042332ca6ee165ae9b91307
-:118: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>'
total: 1 errors, 1 warnings, 0 checks, 78 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use generic_access_phys (rev2)
2021-05-26 15:11 ` [Intel-gfx] " Daniel Vetter
` (4 preceding siblings ...)
(?)
@ 2021-05-26 22:19 ` Patchwork
-1 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2021-05-26 22:19 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 16617 bytes --]
== Series Details ==
Series: drm/i915: Use generic_access_phys (rev2)
URL : https://patchwork.freedesktop.org/series/90616/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10138 -> Patchwork_20209
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20209 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20209, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20209:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@mman:
- fi-bwr-2160: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-bwr-2160/igt@i915_selftest@live@mman.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-bwr-2160/igt@i915_selftest@live@mman.html
- fi-kbl-r: [PASS][3] -> [DMESG-FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-kbl-r/igt@i915_selftest@live@mman.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-kbl-r/igt@i915_selftest@live@mman.html
- fi-bdw-5557u: NOTRUN -> [DMESG-FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-bdw-5557u/igt@i915_selftest@live@mman.html
- fi-cfl-8109u: [PASS][6] -> [DMESG-FAIL][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-cfl-8109u/igt@i915_selftest@live@mman.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-cfl-8109u/igt@i915_selftest@live@mman.html
- fi-snb-2600: [PASS][8] -> [DMESG-FAIL][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-snb-2600/igt@i915_selftest@live@mman.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-snb-2600/igt@i915_selftest@live@mman.html
- fi-cml-u2: [PASS][10] -> [DMESG-FAIL][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-cml-u2/igt@i915_selftest@live@mman.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-cml-u2/igt@i915_selftest@live@mman.html
- fi-tgl-u2: [PASS][12] -> [DMESG-FAIL][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-tgl-u2/igt@i915_selftest@live@mman.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-tgl-u2/igt@i915_selftest@live@mman.html
- fi-ilk-650: [PASS][14] -> [DMESG-FAIL][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-ilk-650/igt@i915_selftest@live@mman.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-ilk-650/igt@i915_selftest@live@mman.html
- fi-hsw-4770: [PASS][16] -> [DMESG-FAIL][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-hsw-4770/igt@i915_selftest@live@mman.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-hsw-4770/igt@i915_selftest@live@mman.html
- fi-cfl-guc: [PASS][18] -> [DMESG-FAIL][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-cfl-guc/igt@i915_selftest@live@mman.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-cfl-guc/igt@i915_selftest@live@mman.html
- fi-skl-6700k2: [PASS][20] -> [DMESG-FAIL][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-skl-6700k2/igt@i915_selftest@live@mman.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-skl-6700k2/igt@i915_selftest@live@mman.html
- fi-elk-e7500: [PASS][22] -> [DMESG-FAIL][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-elk-e7500/igt@i915_selftest@live@mman.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-elk-e7500/igt@i915_selftest@live@mman.html
- fi-kbl-7567u: [PASS][24] -> [DMESG-FAIL][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-kbl-7567u/igt@i915_selftest@live@mman.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-kbl-7567u/igt@i915_selftest@live@mman.html
- fi-glk-dsi: [PASS][26] -> [DMESG-FAIL][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-glk-dsi/igt@i915_selftest@live@mman.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-glk-dsi/igt@i915_selftest@live@mman.html
- fi-ivb-3770: [PASS][28] -> [DMESG-FAIL][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-ivb-3770/igt@i915_selftest@live@mman.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-ivb-3770/igt@i915_selftest@live@mman.html
- fi-icl-y: [PASS][30] -> [DMESG-FAIL][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-icl-y/igt@i915_selftest@live@mman.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-icl-y/igt@i915_selftest@live@mman.html
- fi-snb-2520m: [PASS][32] -> [DMESG-FAIL][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-snb-2520m/igt@i915_selftest@live@mman.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-snb-2520m/igt@i915_selftest@live@mman.html
- fi-cfl-8700k: [PASS][34] -> [DMESG-FAIL][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-cfl-8700k/igt@i915_selftest@live@mman.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-cfl-8700k/igt@i915_selftest@live@mman.html
- fi-tgl-y: [PASS][36] -> [INCOMPLETE][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-tgl-y/igt@i915_selftest@live@mman.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-tgl-y/igt@i915_selftest@live@mman.html
- fi-icl-u2: [PASS][38] -> [DMESG-FAIL][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-icl-u2/igt@i915_selftest@live@mman.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-icl-u2/igt@i915_selftest@live@mman.html
- fi-skl-6600u: [PASS][40] -> [DMESG-FAIL][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-skl-6600u/igt@i915_selftest@live@mman.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-skl-6600u/igt@i915_selftest@live@mman.html
- fi-kbl-x1275: [PASS][42] -> [DMESG-FAIL][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-kbl-x1275/igt@i915_selftest@live@mman.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-kbl-x1275/igt@i915_selftest@live@mman.html
- fi-kbl-7500u: [PASS][44] -> [DMESG-FAIL][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-kbl-7500u/igt@i915_selftest@live@mman.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-kbl-7500u/igt@i915_selftest@live@mman.html
- fi-kbl-guc: [PASS][46] -> [DMESG-FAIL][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-kbl-guc/igt@i915_selftest@live@mman.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-kbl-guc/igt@i915_selftest@live@mman.html
* igt@runner@aborted:
- fi-snb-2520m: NOTRUN -> [FAIL][48]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-snb-2520m/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@mman:
- {fi-ehl-1}: [PASS][49] -> [DMESG-FAIL][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-ehl-1/igt@i915_selftest@live@mman.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-ehl-1/igt@i915_selftest@live@mman.html
- {fi-tgl-dsi}: [PASS][51] -> [INCOMPLETE][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-tgl-dsi/igt@i915_selftest@live@mman.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-tgl-dsi/igt@i915_selftest@live@mman.html
- {fi-hsw-gt1}: [PASS][53] -> [DMESG-FAIL][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-hsw-gt1/igt@i915_selftest@live@mman.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-hsw-gt1/igt@i915_selftest@live@mman.html
- {fi-rkl-11500t}: [PASS][55] -> [DMESG-FAIL][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-rkl-11500t/igt@i915_selftest@live@mman.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-rkl-11500t/igt@i915_selftest@live@mman.html
Known issues
------------
Here are the changes found in Patchwork_20209 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][57] ([i915#2283])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
* igt@i915_selftest@live@mman:
- fi-bsw-kefka: [PASS][58] -> [INCOMPLETE][59] ([i915#2369])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-bsw-kefka/igt@i915_selftest@live@mman.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-bsw-kefka/igt@i915_selftest@live@mman.html
- fi-bsw-nick: [PASS][60] -> [INCOMPLETE][61] ([i915#2369])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-bsw-nick/igt@i915_selftest@live@mman.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-bsw-nick/igt@i915_selftest@live@mman.html
- fi-kbl-soraka: [PASS][62] -> [INCOMPLETE][63] ([i915#2369])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-kbl-soraka/igt@i915_selftest@live@mman.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-kbl-soraka/igt@i915_selftest@live@mman.html
- fi-pnv-d510: [PASS][64] -> [INCOMPLETE][65] ([i915#299])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-pnv-d510/igt@i915_selftest@live@mman.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-pnv-d510/igt@i915_selftest@live@mman.html
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][66] ([fdo#109271] / [fdo#111827]) +8 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-tgl-u2: [PASS][67] -> [FAIL][68] ([i915#2416])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-tgl-u2/igt@kms_frontbuffer_tracking@basic.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-tgl-u2/igt@kms_frontbuffer_tracking@basic.html
- fi-icl-u2: [PASS][69] -> [FAIL][70] ([i915#49])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_psr@cursor_plane_move:
- fi-bdw-5557u: NOTRUN -> [SKIP][71] ([fdo#109271]) +9 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html
* igt@runner@aborted:
- fi-ilk-650: NOTRUN -> [FAIL][72] ([fdo#109271])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-ilk-650/igt@runner@aborted.html
- fi-pnv-d510: NOTRUN -> [FAIL][73] ([fdo#109271] / [i915#2403] / [i915#2505])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-pnv-d510/igt@runner@aborted.html
- fi-bwr-2160: NOTRUN -> [FAIL][74] ([i915#2505])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-bwr-2160/igt@runner@aborted.html
- fi-hsw-4770: NOTRUN -> [FAIL][75] ([fdo#109271] / [i915#1436] / [i915#2505])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-hsw-4770/igt@runner@aborted.html
- fi-snb-2600: NOTRUN -> [FAIL][76] ([i915#698])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-snb-2600/igt@runner@aborted.html
- fi-ivb-3770: NOTRUN -> [FAIL][77] ([fdo#109271])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-ivb-3770/igt@runner@aborted.html
- fi-elk-e7500: NOTRUN -> [FAIL][78] ([fdo#109271])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-elk-e7500/igt@runner@aborted.html
#### Warnings ####
* igt@runner@aborted:
- fi-icl-u2: [FAIL][79] ([i915#2426] / [i915#2782] / [i915#3363]) -> [FAIL][80] ([i915#2782] / [i915#3363])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-icl-u2/igt@runner@aborted.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-icl-u2/igt@runner@aborted.html
- fi-glk-dsi: [FAIL][81] ([i915#2426] / [i915#3363] / [k.org#202321]) -> [FAIL][82] ([i915#3363] / [k.org#202321])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-glk-dsi/igt@runner@aborted.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-glk-dsi/igt@runner@aborted.html
- fi-bdw-5557u: [FAIL][83] ([i915#1602] / [i915#2029]) -> [FAIL][84] ([i915#3462])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-bdw-5557u/igt@runner@aborted.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-bdw-5557u/igt@runner@aborted.html
- fi-kbl-guc: [FAIL][85] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][86] ([i915#1436] / [i915#3363])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-kbl-guc/igt@runner@aborted.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-kbl-guc/igt@runner@aborted.html
- fi-cml-u2: [FAIL][87] ([i915#2082] / [i915#2426] / [i915#3363] / [i915#3462]) -> [FAIL][88] ([i915#3363] / [i915#3462])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10138/fi-cml-u2/igt@runner@aborted.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/fi-cml-u2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2416]: https://gitlab.freedesktop.org/drm/intel/issues/2416
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#698]: https://gitlab.freedesktop.org/drm/intel/issues/698
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (44 -> 40)
------------------------------
Missing (4): fi-cml-drallion fi-ilk-m540 fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_10138 -> Patchwork_20209
CI-20190529: 20190529
CI_DRM_10138: 041f69e539b30565783cd1298842cc269f5005cb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6094: f62d8953c0bc5ed68ea978662e62f9dbb46cf101 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_20209: 12c4102fd7e8207d6c138e1fafe44b0d5c1b816d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
12c4102fd7e8 drm/i915: Use generic_access_phys
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20209/index.html
[-- Attachment #1.2: Type: text/html, Size: 19679 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915: Use generic_access_phys
2021-05-26 15:11 ` [Intel-gfx] " Daniel Vetter
@ 2021-05-27 9:15 ` Daniel Vetter
-1 siblings, 0 replies; 16+ messages in thread
From: Daniel Vetter @ 2021-05-27 9:15 UTC (permalink / raw)
To: Intel Graphics Development
Cc: Thomas Hellström, Daniel Vetter, DRI Development,
Chris Wilson, Jon Bloomfield, Daniel Vetter, Andrew Morton,
Michel Lespinasse, Christian König
On Wed, May 26, 2021 at 05:11:06PM +0200, Daniel Vetter wrote:
> Since
>
> commit 96667f8a4382db9ed042332ca6ee165ae9b91307
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Fri Nov 27 17:41:21 2020 +0100
>
> mm: Close race in generic_access_phys
>
> it is race-free and can therefore be safely used for dynamic mappings
> like we have too.
>
> Cc: Jon Bloomfield <jon.bloomfield@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: Michel Lespinasse <walken@google.com>
This turned out to be a bad idea, because we stuff normal memory into our
io mappings (how well does that work on other archs, no idea). That would
be fixable, but then again we have our issue with using multiple
inconsistent mmaps, and at that point it's probably a lost cause :-(
-Daniel
> ---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 60 +++---------------------
> 1 file changed, 6 insertions(+), 54 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> index f6fe5cb01438..717798293044 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> @@ -414,58 +414,6 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)
> return i915_error_to_vmf_fault(ret);
> }
>
> -static int
> -vm_access(struct vm_area_struct *area, unsigned long addr,
> - void *buf, int len, int write)
> -{
> - struct i915_mmap_offset *mmo = area->vm_private_data;
> - struct drm_i915_gem_object *obj = mmo->obj;
> - struct i915_gem_ww_ctx ww;
> - void *vaddr;
> - int err = 0;
> -
> - if (i915_gem_object_is_readonly(obj) && write)
> - return -EACCES;
> -
> - addr -= area->vm_start;
> - if (addr >= obj->base.size)
> - return -EINVAL;
> -
> - i915_gem_ww_ctx_init(&ww, true);
> -retry:
> - err = i915_gem_object_lock(obj, &ww);
> - if (err)
> - goto out;
> -
> - /* As this is primarily for debugging, let's focus on simplicity */
> - vaddr = i915_gem_object_pin_map(obj, I915_MAP_FORCE_WC);
> - if (IS_ERR(vaddr)) {
> - err = PTR_ERR(vaddr);
> - goto out;
> - }
> -
> - if (write) {
> - memcpy(vaddr + addr, buf, len);
> - __i915_gem_object_flush_map(obj, addr, len);
> - } else {
> - memcpy(buf, vaddr + addr, len);
> - }
> -
> - i915_gem_object_unpin_map(obj);
> -out:
> - if (err == -EDEADLK) {
> - err = i915_gem_ww_ctx_backoff(&ww);
> - if (!err)
> - goto retry;
> - }
> - i915_gem_ww_ctx_fini(&ww);
> -
> - if (err)
> - return err;
> -
> - return len;
> -}
> -
> void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
> {
> struct i915_vma *vma;
> @@ -801,14 +749,18 @@ static void vm_close(struct vm_area_struct *vma)
>
> static const struct vm_operations_struct vm_ops_gtt = {
> .fault = vm_fault_gtt,
> - .access = vm_access,
> +#ifdef CONFIG_HAVE_IOREMAP_PROT
> + .access = generic_access_phys
> +#endif
> .open = vm_open,
> .close = vm_close,
> };
>
> static const struct vm_operations_struct vm_ops_cpu = {
> .fault = vm_fault_cpu,
> - .access = vm_access,
> +#ifdef CONFIG_HAVE_IOREMAP_PROT
> + .access = generic_access_phys
> +#endif
> .open = vm_open,
> .close = vm_close,
> };
> --
> 2.31.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Use generic_access_phys
@ 2021-05-27 9:15 ` Daniel Vetter
0 siblings, 0 replies; 16+ messages in thread
From: Daniel Vetter @ 2021-05-27 9:15 UTC (permalink / raw)
To: Intel Graphics Development
Cc: Thomas Hellström, Daniel Vetter, DRI Development,
Chris Wilson, Daniel Vetter, Andrew Morton, Michel Lespinasse,
Christian König
On Wed, May 26, 2021 at 05:11:06PM +0200, Daniel Vetter wrote:
> Since
>
> commit 96667f8a4382db9ed042332ca6ee165ae9b91307
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Fri Nov 27 17:41:21 2020 +0100
>
> mm: Close race in generic_access_phys
>
> it is race-free and can therefore be safely used for dynamic mappings
> like we have too.
>
> Cc: Jon Bloomfield <jon.bloomfield@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: Michel Lespinasse <walken@google.com>
This turned out to be a bad idea, because we stuff normal memory into our
io mappings (how well does that work on other archs, no idea). That would
be fixable, but then again we have our issue with using multiple
inconsistent mmaps, and at that point it's probably a lost cause :-(
-Daniel
> ---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 60 +++---------------------
> 1 file changed, 6 insertions(+), 54 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> index f6fe5cb01438..717798293044 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> @@ -414,58 +414,6 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)
> return i915_error_to_vmf_fault(ret);
> }
>
> -static int
> -vm_access(struct vm_area_struct *area, unsigned long addr,
> - void *buf, int len, int write)
> -{
> - struct i915_mmap_offset *mmo = area->vm_private_data;
> - struct drm_i915_gem_object *obj = mmo->obj;
> - struct i915_gem_ww_ctx ww;
> - void *vaddr;
> - int err = 0;
> -
> - if (i915_gem_object_is_readonly(obj) && write)
> - return -EACCES;
> -
> - addr -= area->vm_start;
> - if (addr >= obj->base.size)
> - return -EINVAL;
> -
> - i915_gem_ww_ctx_init(&ww, true);
> -retry:
> - err = i915_gem_object_lock(obj, &ww);
> - if (err)
> - goto out;
> -
> - /* As this is primarily for debugging, let's focus on simplicity */
> - vaddr = i915_gem_object_pin_map(obj, I915_MAP_FORCE_WC);
> - if (IS_ERR(vaddr)) {
> - err = PTR_ERR(vaddr);
> - goto out;
> - }
> -
> - if (write) {
> - memcpy(vaddr + addr, buf, len);
> - __i915_gem_object_flush_map(obj, addr, len);
> - } else {
> - memcpy(buf, vaddr + addr, len);
> - }
> -
> - i915_gem_object_unpin_map(obj);
> -out:
> - if (err == -EDEADLK) {
> - err = i915_gem_ww_ctx_backoff(&ww);
> - if (!err)
> - goto retry;
> - }
> - i915_gem_ww_ctx_fini(&ww);
> -
> - if (err)
> - return err;
> -
> - return len;
> -}
> -
> void __i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)
> {
> struct i915_vma *vma;
> @@ -801,14 +749,18 @@ static void vm_close(struct vm_area_struct *vma)
>
> static const struct vm_operations_struct vm_ops_gtt = {
> .fault = vm_fault_gtt,
> - .access = vm_access,
> +#ifdef CONFIG_HAVE_IOREMAP_PROT
> + .access = generic_access_phys
> +#endif
> .open = vm_open,
> .close = vm_close,
> };
>
> static const struct vm_operations_struct vm_ops_cpu = {
> .fault = vm_fault_cpu,
> - .access = vm_access,
> +#ifdef CONFIG_HAVE_IOREMAP_PROT
> + .access = generic_access_phys
> +#endif
> .open = vm_open,
> .close = vm_close,
> };
> --
> 2.31.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-05-27 9:15 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 15:11 [PATCH] drm/i915: Use generic_access_phys Daniel Vetter
2021-05-26 15:11 ` [Intel-gfx] " Daniel Vetter
2021-05-26 15:30 ` Daniel Vetter
2021-05-26 15:30 ` [Intel-gfx] " Daniel Vetter
2021-05-26 18:54 ` kernel test robot
2021-05-26 18:54 ` kernel test robot
2021-05-26 18:54 ` [Intel-gfx] " kernel test robot
2021-05-26 18:54 ` kernel test robot
2021-05-26 20:33 ` kernel test robot
2021-05-26 20:33 ` kernel test robot
2021-05-26 20:33 ` [Intel-gfx] " kernel test robot
2021-05-26 20:33 ` kernel test robot
2021-05-26 21:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Use generic_access_phys (rev2) Patchwork
2021-05-26 22:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-05-27 9:15 ` [PATCH] drm/i915: Use generic_access_phys Daniel Vetter
2021-05-27 9:15 ` [Intel-gfx] " Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.