* [PATCH v2 1/3] perf core: Make local function perf_pmu_snapshot_aux() static
2021-05-27 3:19 [PATCH v2 0/3] perf/events: Fix some build warnings in perf/events subsystem Haocheng Xie
@ 2021-05-27 3:19 ` Haocheng Xie
2021-05-27 7:38 ` [tip: perf/core] perf/core: " tip-bot2 for Haocheng Xie
2021-05-27 3:19 ` [PATCH v2 2/3] perf core: Fix some kernel-doc warnings Haocheng Xie
2021-05-27 3:19 ` [PATCH v2 3/3] perf/hw_breakpoint: Fix kernel-doc warnings in perf hw_breakpoint Haocheng Xie
2 siblings, 1 reply; 7+ messages in thread
From: Haocheng Xie @ 2021-05-27 3:19 UTC (permalink / raw)
To: mingo, acme, alexander.shishkin, jolsa, mark.rutland, mingo,
namhyung, peterz
Cc: linux-kernel, linux-perf-users, Haocheng Xie
Fixes the following W=1 kernel build warning:
kernel/events/core.c:6670:6: warning: no previous prototype for 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
Signed-off-by: Haocheng Xie <xiehaocheng.cn@gmail.com>
---
kernel/events/core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 6fee4a7..e1a80e1 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6667,10 +6667,10 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
return data->aux_size;
}
-long perf_pmu_snapshot_aux(struct perf_buffer *rb,
- struct perf_event *event,
- struct perf_output_handle *handle,
- unsigned long size)
+static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
+ struct perf_event *event,
+ struct perf_output_handle *handle,
+ unsigned long size)
{
unsigned long flags;
long ret;
--
2.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [tip: perf/core] perf/core: Make local function perf_pmu_snapshot_aux() static
2021-05-27 3:19 ` [PATCH v2 1/3] perf core: Make local function perf_pmu_snapshot_aux() static Haocheng Xie
@ 2021-05-27 7:38 ` tip-bot2 for Haocheng Xie
0 siblings, 0 replies; 7+ messages in thread
From: tip-bot2 for Haocheng Xie @ 2021-05-27 7:38 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Haocheng Xie, Ingo Molnar, x86, linux-kernel
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 32961aecf9da85c9e4c98d91ab8337424e0c8372
Gitweb: https://git.kernel.org/tip/32961aecf9da85c9e4c98d91ab8337424e0c8372
Author: Haocheng Xie <xiehaocheng.cn@gmail.com>
AuthorDate: Thu, 27 May 2021 11:19:45 +08:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 27 May 2021 09:35:21 +02:00
perf/core: Make local function perf_pmu_snapshot_aux() static
Fixes the following W=1 kernel build warning:
kernel/events/core.c:6670:6: warning: no previous prototype for 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
Signed-off-by: Haocheng Xie <xiehaocheng.cn@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210527031947.1801-2-xiehaocheng.cn@gmail.com
---
kernel/events/core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 2e947a4..4c6b320 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6674,10 +6674,10 @@ out:
return data->aux_size;
}
-long perf_pmu_snapshot_aux(struct perf_buffer *rb,
- struct perf_event *event,
- struct perf_output_handle *handle,
- unsigned long size)
+static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
+ struct perf_event *event,
+ struct perf_output_handle *handle,
+ unsigned long size)
{
unsigned long flags;
long ret;
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/3] perf core: Fix some kernel-doc warnings.
2021-05-27 3:19 [PATCH v2 0/3] perf/events: Fix some build warnings in perf/events subsystem Haocheng Xie
2021-05-27 3:19 ` [PATCH v2 1/3] perf core: Make local function perf_pmu_snapshot_aux() static Haocheng Xie
@ 2021-05-27 3:19 ` Haocheng Xie
2021-05-27 7:38 ` [tip: perf/core] perf/core: Fix DocBook warnings tip-bot2 for Haocheng Xie
2021-05-27 3:19 ` [PATCH v2 3/3] perf/hw_breakpoint: Fix kernel-doc warnings in perf hw_breakpoint Haocheng Xie
2 siblings, 1 reply; 7+ messages in thread
From: Haocheng Xie @ 2021-05-27 3:19 UTC (permalink / raw)
To: mingo, acme, alexander.shishkin, jolsa, mark.rutland, mingo,
namhyung, peterz
Cc: linux-kernel, linux-perf-users, Haocheng Xie
Fix the following W=1 kernel build warning(s):
kernel/events/core.c:143: warning: Function parameter or member 'cpu' not described in 'cpu_function_call'
kernel/events/core.c:11924: warning: Function parameter or member 'flags' not described in 'sys_perf_event_open'
kernel/events/core.c:12382: warning: Function parameter or member 'overflow_handler' not described in 'perf_event_create_kernel_counter'
kernel/events/core.c:12382: warning: Function parameter or member 'context' not described in 'perf_event_create_kernel_counter'
Signed-off-by: Haocheng Xie <xiehaocheng.cn@gmail.com>
---
kernel/events/core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index e1a80e1..acfd0b4 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -132,6 +132,7 @@ task_function_call(struct task_struct *p, remote_function_f func, void *info)
/**
* cpu_function_call - call a function on the cpu
+ * @cpu: target cpu to queue this function
* @func: the function to be called
* @info: the function call argument
*
@@ -11917,6 +11918,7 @@ __perf_event_ctx_lock_double(struct perf_event *group_leader,
* @pid: target pid
* @cpu: target cpu
* @group_fd: group leader event fd
+ * @flags: perf event open flags
*/
SYSCALL_DEFINE5(perf_event_open,
struct perf_event_attr __user *, attr_uptr,
@@ -12373,6 +12375,8 @@ SYSCALL_DEFINE5(perf_event_open,
* @attr: attributes of the counter to create
* @cpu: cpu in which the counter is bound
* @task: task to profile (NULL for percpu)
+ * @overflow_handler: callback to trigger when we hit the event
+ * @context: context data could be used in overflow_handler callback
*/
struct perf_event *
perf_event_create_kernel_counter(struct perf_event_attr *attr, int cpu,
--
2.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [tip: perf/core] perf/core: Fix DocBook warnings
2021-05-27 3:19 ` [PATCH v2 2/3] perf core: Fix some kernel-doc warnings Haocheng Xie
@ 2021-05-27 7:38 ` tip-bot2 for Haocheng Xie
0 siblings, 0 replies; 7+ messages in thread
From: tip-bot2 for Haocheng Xie @ 2021-05-27 7:38 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Haocheng Xie, Ingo Molnar, x86, linux-kernel
The following commit has been merged into the perf/core branch of tip:
Commit-ID: a1ddf5249f2c50f2e6e5efe604f01a01d5c23ef5
Gitweb: https://git.kernel.org/tip/a1ddf5249f2c50f2e6e5efe604f01a01d5c23ef5
Author: Haocheng Xie <xiehaocheng.cn@gmail.com>
AuthorDate: Thu, 27 May 2021 11:19:46 +08:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 27 May 2021 09:35:21 +02:00
perf/core: Fix DocBook warnings
Fix the following W=1 kernel build warning(s):
kernel/events/core.c:143: warning: Function parameter or member 'cpu' not described in 'cpu_function_call'
kernel/events/core.c:11924: warning: Function parameter or member 'flags' not described in 'sys_perf_event_open'
kernel/events/core.c:12382: warning: Function parameter or member 'overflow_handler' not described in 'perf_event_create_kernel_counter'
kernel/events/core.c:12382: warning: Function parameter or member 'context' not described in 'perf_event_create_kernel_counter'
Signed-off-by: Haocheng Xie <xiehaocheng.cn@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210527031947.1801-3-xiehaocheng.cn@gmail.com
---
kernel/events/core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 4c6b320..6c964de 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -132,6 +132,7 @@ task_function_call(struct task_struct *p, remote_function_f func, void *info)
/**
* cpu_function_call - call a function on the cpu
+ * @cpu: target cpu to queue this function
* @func: the function to be called
* @info: the function call argument
*
@@ -11924,6 +11925,7 @@ again:
* @pid: target pid
* @cpu: target cpu
* @group_fd: group leader event fd
+ * @flags: perf event open flags
*/
SYSCALL_DEFINE5(perf_event_open,
struct perf_event_attr __user *, attr_uptr,
@@ -12380,6 +12382,8 @@ err_fd:
* @attr: attributes of the counter to create
* @cpu: cpu in which the counter is bound
* @task: task to profile (NULL for percpu)
+ * @overflow_handler: callback to trigger when we hit the event
+ * @context: context data could be used in overflow_handler callback
*/
struct perf_event *
perf_event_create_kernel_counter(struct perf_event_attr *attr, int cpu,
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/3] perf/hw_breakpoint: Fix kernel-doc warnings in perf hw_breakpoint
2021-05-27 3:19 [PATCH v2 0/3] perf/events: Fix some build warnings in perf/events subsystem Haocheng Xie
2021-05-27 3:19 ` [PATCH v2 1/3] perf core: Make local function perf_pmu_snapshot_aux() static Haocheng Xie
2021-05-27 3:19 ` [PATCH v2 2/3] perf core: Fix some kernel-doc warnings Haocheng Xie
@ 2021-05-27 3:19 ` Haocheng Xie
2021-05-27 7:38 ` [tip: perf/core] perf/hw_breakpoint: Fix DocBook " tip-bot2 for Haocheng Xie
2 siblings, 1 reply; 7+ messages in thread
From: Haocheng Xie @ 2021-05-27 3:19 UTC (permalink / raw)
To: mingo, acme, alexander.shishkin, jolsa, mark.rutland, mingo,
namhyung, peterz
Cc: linux-kernel, linux-perf-users, Haocheng Xie
Fix the following W=1 kernel build warning(s):
kernel/events/hw_breakpoint.c:461: warning: Function parameter or member 'context' not described in 'register_user_hw_breakpoint'
kernel/events/hw_breakpoint.c:560: warning: Function parameter or member 'context' not described in 'register_wide_hw_breakpoint'
Signed-off-by: Haocheng Xie <xiehaocheng.cn@gmail.com>
---
kernel/events/hw_breakpoint.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
index b48d703..8359734 100644
--- a/kernel/events/hw_breakpoint.c
+++ b/kernel/events/hw_breakpoint.c
@@ -451,6 +451,7 @@ int register_perf_hw_breakpoint(struct perf_event *bp)
* register_user_hw_breakpoint - register a hardware breakpoint for user space
* @attr: breakpoint attributes
* @triggered: callback to trigger when we hit the breakpoint
+ * @context: context data could be used in the triggered callback
* @tsk: pointer to 'task_struct' of the process to which the address belongs
*/
struct perf_event *
@@ -550,6 +551,7 @@ EXPORT_SYMBOL_GPL(unregister_hw_breakpoint);
* register_wide_hw_breakpoint - register a wide breakpoint in the kernel
* @attr: breakpoint attributes
* @triggered: callback to trigger when we hit the breakpoint
+ * @context: context data could be used in the triggered callback
*
* @return a set of per_cpu pointers to perf events
*/
--
2.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [tip: perf/core] perf/hw_breakpoint: Fix DocBook warnings in perf hw_breakpoint
2021-05-27 3:19 ` [PATCH v2 3/3] perf/hw_breakpoint: Fix kernel-doc warnings in perf hw_breakpoint Haocheng Xie
@ 2021-05-27 7:38 ` tip-bot2 for Haocheng Xie
0 siblings, 0 replies; 7+ messages in thread
From: tip-bot2 for Haocheng Xie @ 2021-05-27 7:38 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Haocheng Xie, Ingo Molnar, x86, linux-kernel
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 875dd7bf548104bc1d2c5784a6af6cf38215a216
Gitweb: https://git.kernel.org/tip/875dd7bf548104bc1d2c5784a6af6cf38215a216
Author: Haocheng Xie <xiehaocheng.cn@gmail.com>
AuthorDate: Thu, 27 May 2021 11:19:47 +08:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 27 May 2021 09:35:22 +02:00
perf/hw_breakpoint: Fix DocBook warnings in perf hw_breakpoint
Fix the following W=1 kernel build warning(s):
kernel/events/hw_breakpoint.c:461: warning: Function parameter or member 'context' not described in 'register_user_hw_breakpoint'
kernel/events/hw_breakpoint.c:560: warning: Function parameter or member 'context' not described in 'register_wide_hw_breakpoint'
Signed-off-by: Haocheng Xie <xiehaocheng.cn@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210527031947.1801-4-xiehaocheng.cn@gmail.com
---
kernel/events/hw_breakpoint.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
index b48d703..8359734 100644
--- a/kernel/events/hw_breakpoint.c
+++ b/kernel/events/hw_breakpoint.c
@@ -451,6 +451,7 @@ int register_perf_hw_breakpoint(struct perf_event *bp)
* register_user_hw_breakpoint - register a hardware breakpoint for user space
* @attr: breakpoint attributes
* @triggered: callback to trigger when we hit the breakpoint
+ * @context: context data could be used in the triggered callback
* @tsk: pointer to 'task_struct' of the process to which the address belongs
*/
struct perf_event *
@@ -550,6 +551,7 @@ EXPORT_SYMBOL_GPL(unregister_hw_breakpoint);
* register_wide_hw_breakpoint - register a wide breakpoint in the kernel
* @attr: breakpoint attributes
* @triggered: callback to trigger when we hit the breakpoint
+ * @context: context data could be used in the triggered callback
*
* @return a set of per_cpu pointers to perf events
*/
^ permalink raw reply related [flat|nested] 7+ messages in thread