From: Cristian Marussi <cristian.marussi@arm.com> To: Etienne Carriere <etienne.carriere@linaro.org> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla <sudeep.holla@arm.com>, Vincent Guittot <vincent.guittot@linaro.org> Subject: Re: [PATCH v2 1/4] firmware: arm_scmi: fix deps arm-smccc-discovery deps in Kconfig Date: Thu, 27 May 2021 14:28:12 +0100 [thread overview] Message-ID: <20210527132812.GU28060@e120937-lin> (raw) In-Reply-To: <20210521134055.24271-1-etienne.carriere@linaro.org> Hi Etienne, On Fri, May 21, 2021 at 03:40:51PM +0200, Etienne Carriere wrote: > ARM_SCMI_PROTOCOL depends one either MAILBOX or HAVE_ARM_SMCCC_DISCOVERY, > not MAILBOX only. This change fixes this in Kconfig file and driver > private header file. > > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > --- > No change since v1 > --- > drivers/firmware/Kconfig | 2 +- > drivers/firmware/arm_scmi/common.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index db0ea2d2d75a..a9c613c32282 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -9,7 +9,7 @@ menu "Firmware Drivers" > config ARM_SCMI_PROTOCOL > tristate "ARM System Control and Management Interface (SCMI) Message Protocol" > depends on ARM || ARM64 || COMPILE_TEST > - depends on MAILBOX > + depends on MAILBOX || HAVE_ARM_SMCCC_DISCOVERY > help > ARM System Control and Management Interface (SCMI) protocol is a > set of operating system-independent software interfaces that are > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > index 228bf4a71d23..8685619d38f9 100644 > --- a/drivers/firmware/arm_scmi/common.h > +++ b/drivers/firmware/arm_scmi/common.h > @@ -331,7 +331,7 @@ struct scmi_desc { > }; > > extern const struct scmi_desc scmi_mailbox_desc; > -#ifdef CONFIG_HAVE_ARM_SMCCC > +#ifdef CONFIG_HAVE_ARM_SMCCC_DISCOVERY > extern const struct scmi_desc scmi_smc_desc; > #endif > This seems reasonable to me as of now, but I have to say in the original virtio-scmi series from Peter this issue is tackled a bit differently: (https://lore.kernel.org/linux-arm-kernel/20210511002040.802226-1-peter.hilber@opensynergy.com/) adding something like ARM_SCMI_HAVE_SHMEM and ARM_SCMI_HAVE_MSG and then make mailbox and smc transport select HAVE_SHMEM while virtio selects HAVE_MSG and keeping ARM_SCMI_PROTOCOL depends on either of those. I found such approach a bit better in term of abstraction indeed, but given that such virtio-scmi series I'm reworking is still probably a bit further down the line in terms of posting, I think that your solution is good enough for now if Sudeep agrees with it, and we can switch to the above mentioned HAVE_* abstractions once virtio-scmi is pushed forward. Reviewed-by: Cristian Marussi <cristian.marussi@arm.com> Thanks, Cristian > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com> To: Etienne Carriere <etienne.carriere@linaro.org> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla <sudeep.holla@arm.com>, Vincent Guittot <vincent.guittot@linaro.org> Subject: Re: [PATCH v2 1/4] firmware: arm_scmi: fix deps arm-smccc-discovery deps in Kconfig Date: Thu, 27 May 2021 14:28:12 +0100 [thread overview] Message-ID: <20210527132812.GU28060@e120937-lin> (raw) In-Reply-To: <20210521134055.24271-1-etienne.carriere@linaro.org> Hi Etienne, On Fri, May 21, 2021 at 03:40:51PM +0200, Etienne Carriere wrote: > ARM_SCMI_PROTOCOL depends one either MAILBOX or HAVE_ARM_SMCCC_DISCOVERY, > not MAILBOX only. This change fixes this in Kconfig file and driver > private header file. > > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > --- > No change since v1 > --- > drivers/firmware/Kconfig | 2 +- > drivers/firmware/arm_scmi/common.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index db0ea2d2d75a..a9c613c32282 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -9,7 +9,7 @@ menu "Firmware Drivers" > config ARM_SCMI_PROTOCOL > tristate "ARM System Control and Management Interface (SCMI) Message Protocol" > depends on ARM || ARM64 || COMPILE_TEST > - depends on MAILBOX > + depends on MAILBOX || HAVE_ARM_SMCCC_DISCOVERY > help > ARM System Control and Management Interface (SCMI) protocol is a > set of operating system-independent software interfaces that are > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > index 228bf4a71d23..8685619d38f9 100644 > --- a/drivers/firmware/arm_scmi/common.h > +++ b/drivers/firmware/arm_scmi/common.h > @@ -331,7 +331,7 @@ struct scmi_desc { > }; > > extern const struct scmi_desc scmi_mailbox_desc; > -#ifdef CONFIG_HAVE_ARM_SMCCC > +#ifdef CONFIG_HAVE_ARM_SMCCC_DISCOVERY > extern const struct scmi_desc scmi_smc_desc; > #endif > This seems reasonable to me as of now, but I have to say in the original virtio-scmi series from Peter this issue is tackled a bit differently: (https://lore.kernel.org/linux-arm-kernel/20210511002040.802226-1-peter.hilber@opensynergy.com/) adding something like ARM_SCMI_HAVE_SHMEM and ARM_SCMI_HAVE_MSG and then make mailbox and smc transport select HAVE_SHMEM while virtio selects HAVE_MSG and keeping ARM_SCMI_PROTOCOL depends on either of those. I found such approach a bit better in term of abstraction indeed, but given that such virtio-scmi series I'm reworking is still probably a bit further down the line in terms of posting, I think that your solution is good enough for now if Sudeep agrees with it, and we can switch to the above mentioned HAVE_* abstractions once virtio-scmi is pushed forward. Reviewed-by: Cristian Marussi <cristian.marussi@arm.com> Thanks, Cristian > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-27 13:28 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-21 13:40 [PATCH v2 1/4] firmware: arm_scmi: fix deps arm-smccc-discovery deps in Kconfig Etienne Carriere 2021-05-21 13:40 ` Etienne Carriere 2021-05-21 13:40 ` [PATCH v2 2/4] dt-bindings: arm: scmi property mboxes is not mandatory Etienne Carriere 2021-05-21 13:40 ` Etienne Carriere 2021-06-02 10:40 ` Sudeep Holla 2021-06-02 10:40 ` Sudeep Holla 2021-05-21 13:40 ` [PATCH v2 3/4] dt-bindings: arm: OP-TEE as transport channel for SCMI messages Etienne Carriere 2021-05-21 13:40 ` Etienne Carriere 2021-06-02 10:53 ` Sudeep Holla 2021-06-02 10:53 ` Sudeep Holla 2021-05-21 13:40 ` [PATCH v2 4/4] firmware: arm_scmi: add optee transport Etienne Carriere 2021-05-21 13:40 ` Etienne Carriere 2021-05-27 15:11 ` Cristian Marussi 2021-05-27 15:11 ` Cristian Marussi 2021-05-28 9:43 ` Etienne Carriere 2021-05-28 9:43 ` Etienne Carriere 2021-06-01 10:41 ` Cristian Marussi 2021-06-01 10:41 ` Cristian Marussi 2021-06-11 17:30 ` Cristian Marussi 2021-06-11 17:30 ` Cristian Marussi 2021-05-21 15:15 ` [PATCH v2 1/4] firmware: arm_scmi: fix deps arm-smccc-discovery deps in Kconfig Sudeep Holla 2021-05-21 15:15 ` Sudeep Holla 2021-05-21 15:20 ` Florian Fainelli 2021-05-21 15:20 ` Florian Fainelli 2021-05-21 15:26 ` Sudeep Holla 2021-05-21 15:26 ` Sudeep Holla 2021-05-27 13:28 ` Cristian Marussi [this message] 2021-05-27 13:28 ` Cristian Marussi 2021-06-02 10:55 ` Sudeep Holla 2021-06-02 10:55 ` Sudeep Holla 2021-06-04 8:53 ` (subset) " Sudeep Holla 2021-06-04 8:53 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210527132812.GU28060@e120937-lin \ --to=cristian.marussi@arm.com \ --cc=etienne.carriere@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sudeep.holla@arm.com \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.