All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: jacob berkman <jacob@87k.net>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH 0/3] A few small OpenBSD-ish fixes
Date: Thu, 27 May 2021 16:58:37 +0200	[thread overview]
Message-ID: <20210527145837.d6hjgf7ukd4xezdc@tomti.i.net-space.pl> (raw)
In-Reply-To: <20210519051415.847-1-jacob@87k.net>

Hi Jacob,

On Tue, May 18, 2021 at 10:14:12PM -0700, jacob berkman wrote:
> Hello,
>
> I built GRUB on OpenBSD 6.9 over the weekend, and ran into a few
> issues. The minor ones attached were easy enough to
> fix. Unfortunately, once installed, it merely prints "Grub Loading"
> (or something similar) and reboots. In trying to recover from this, I
> wiped out the MBR and that's when I gave up and figured maybe I should
> do this in a VM instead.

The patches look more or less good to me. Though I would like to ask you
to add to all of them your SOB line like:

Signed-off-by: jacob berkman <jacob@87k.net>

Additionally, please do not put whole description of the issue into the
subject. The subject should contain only a hint what a given patch does.

> One other issue I ran into was that setjmp.mod would fail to build
> because it didn't export any symbols. No other modules seemed to
> depend on it. I just removed it from Makefile, but I'm not familiar
> enough with GRUB to know whether that's a reasonable enough solution,
> or if that's related to the inability to boot.

Could you provide more details how to reproduce the issue?

Daniel


      parent reply	other threads:[~2021-05-27 14:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19  5:14 [PATCH 0/3] A few small OpenBSD-ish fixes jacob berkman
2021-05-19  5:14 ` [PATCH 1/3] Do not fail configure if Python is missing. It's only required for developement of GRUB jacob berkman
2021-05-19  5:14 ` [PATCH 2/3] Fix warning about misleading indentation on OpenBSD 6.9 with -Werror enabled (which is the default) jacob berkman
2021-05-19  5:14 ` [PATCH 3/3] Use size_t printf format to match type jacob berkman
2021-05-27 14:58 ` Daniel Kiper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210527145837.d6hjgf7ukd4xezdc@tomti.i.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=jacob@87k.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.