All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6sl: add PXP module
@ 2021-05-27 21:07 ` Andreas Kemnade
  0 siblings, 0 replies; 4+ messages in thread
From: Andreas Kemnade @ 2021-05-27 21:07 UTC (permalink / raw)
  To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
	devicetree, linux-arm-kernel, linux-kernel
  Cc: Andreas Kemnade

While the EPDC is optional, all editions have the PXP module, so adding
it to the corresponding .dtsi
Information taken from freescale kernel, compared with the
reference manual and tested by a separate program.

Since it does not depend on external wiring, the
status = "disabled" is left out here.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/imx6sl.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index 997b96c1c47b..6be83e863f19 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -762,8 +762,11 @@
 			};
 
 			pxp: pxp@20f0000 {
+				compatible = "fsl,imx6sl-pxp", "fsl,imx6ull-pxp";
 				reg = <0x020f0000 0x4000>;
 				interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX6SL_CLK_PXP_AXI>;
+				clock-names = "axi";
 			};
 
 			epdc: epdc@20f4000 {
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6sl: add PXP module
@ 2021-05-27 21:07 ` Andreas Kemnade
  0 siblings, 0 replies; 4+ messages in thread
From: Andreas Kemnade @ 2021-05-27 21:07 UTC (permalink / raw)
  To: robh+dt, shawnguo, s.hauer, kernel, festevam, linux-imx,
	devicetree, linux-arm-kernel, linux-kernel
  Cc: Andreas Kemnade

While the EPDC is optional, all editions have the PXP module, so adding
it to the corresponding .dtsi
Information taken from freescale kernel, compared with the
reference manual and tested by a separate program.

Since it does not depend on external wiring, the
status = "disabled" is left out here.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/imx6sl.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index 997b96c1c47b..6be83e863f19 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -762,8 +762,11 @@
 			};
 
 			pxp: pxp@20f0000 {
+				compatible = "fsl,imx6sl-pxp", "fsl,imx6ull-pxp";
 				reg = <0x020f0000 0x4000>;
 				interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX6SL_CLK_PXP_AXI>;
+				clock-names = "axi";
 			};
 
 			epdc: epdc@20f4000 {
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6sl: add PXP module
  2021-05-27 21:07 ` Andreas Kemnade
@ 2021-06-12  7:04   ` Shawn Guo
  -1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2021-06-12  7:04 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: robh+dt, s.hauer, kernel, festevam, linux-imx, devicetree,
	linux-arm-kernel, linux-kernel

On Thu, May 27, 2021 at 11:07:42PM +0200, Andreas Kemnade wrote:
> While the EPDC is optional, all editions have the PXP module, so adding
> it to the corresponding .dtsi
> Information taken from freescale kernel, compared with the
> reference manual and tested by a separate program.
> 
> Since it does not depend on external wiring, the
> status = "disabled" is left out here.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/imx6sl.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 997b96c1c47b..6be83e863f19 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -762,8 +762,11 @@
>  			};
>  
>  			pxp: pxp@20f0000 {
> +				compatible = "fsl,imx6sl-pxp", "fsl,imx6ull-pxp";

"fsl,imx6sl-pxp" needs to be documented.

Shawn

>  				reg = <0x020f0000 0x4000>;
>  				interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX6SL_CLK_PXP_AXI>;
> +				clock-names = "axi";
>  			};
>  
>  			epdc: epdc@20f4000 {
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6sl: add PXP module
@ 2021-06-12  7:04   ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2021-06-12  7:04 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: robh+dt, s.hauer, kernel, festevam, linux-imx, devicetree,
	linux-arm-kernel, linux-kernel

On Thu, May 27, 2021 at 11:07:42PM +0200, Andreas Kemnade wrote:
> While the EPDC is optional, all editions have the PXP module, so adding
> it to the corresponding .dtsi
> Information taken from freescale kernel, compared with the
> reference manual and tested by a separate program.
> 
> Since it does not depend on external wiring, the
> status = "disabled" is left out here.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/imx6sl.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 997b96c1c47b..6be83e863f19 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -762,8 +762,11 @@
>  			};
>  
>  			pxp: pxp@20f0000 {
> +				compatible = "fsl,imx6sl-pxp", "fsl,imx6ull-pxp";

"fsl,imx6sl-pxp" needs to be documented.

Shawn

>  				reg = <0x020f0000 0x4000>;
>  				interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX6SL_CLK_PXP_AXI>;
> +				clock-names = "axi";
>  			};
>  
>  			epdc: epdc@20f4000 {
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-12  7:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 21:07 [PATCH] ARM: dts: imx6sl: add PXP module Andreas Kemnade
2021-05-27 21:07 ` Andreas Kemnade
2021-06-12  7:04 ` Shawn Guo
2021-06-12  7:04   ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.