* [PATCH] S390: appldata depends on PROC_SYSCTL
@ 2021-05-28 0:24 Randy Dunlap
2021-05-31 14:09 ` Vasily Gorbik
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-05-28 0:24 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, linux-s390
APPLDATA_BASE should depend on PROC_SYSCTL instead of PROC_FS.
Building with PROC_FS but not PROC_SYSCTL causes a build error,
since appldata_base.c uses data and APIs from fs/proc/proc_sysctl.c.
arch/s390/appldata/appldata_base.o: in function `appldata_generic_handler':
appldata_base.c:(.text+0x192): undefined reference to `sysctl_vals'
Fixes: c185b783b099 ("[S390] Remove config options.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-s390@vger.kernel.org
---
arch/s390/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20210526.orig/arch/s390/Kconfig
+++ linux-next-20210526/arch/s390/Kconfig
@@ -853,7 +853,7 @@ config CMM_IUCV
config APPLDATA_BASE
def_bool n
prompt "Linux - VM Monitor Stream, base infrastructure"
- depends on PROC_FS
+ depends on PROC_SYSCTL
help
This provides a kernel interface for creating and updating z/VM APPLDATA
monitor records. The monitor records are updated at certain time
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] S390: appldata depends on PROC_SYSCTL
2021-05-28 0:24 [PATCH] S390: appldata depends on PROC_SYSCTL Randy Dunlap
@ 2021-05-31 14:09 ` Vasily Gorbik
0 siblings, 0 replies; 2+ messages in thread
From: Vasily Gorbik @ 2021-05-31 14:09 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Heiko Carstens, Christian Borntraeger, linux-s390
On Thu, May 27, 2021 at 05:24:20PM -0700, Randy Dunlap wrote:
> APPLDATA_BASE should depend on PROC_SYSCTL instead of PROC_FS.
> Building with PROC_FS but not PROC_SYSCTL causes a build error,
> since appldata_base.c uses data and APIs from fs/proc/proc_sysctl.c.
>
> arch/s390/appldata/appldata_base.o: in function `appldata_generic_handler':
> appldata_base.c:(.text+0x192): undefined reference to `sysctl_vals'
>
> Fixes: c185b783b099 ("[S390] Remove config options.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: linux-s390@vger.kernel.org
> ---
> arch/s390/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210526.orig/arch/s390/Kconfig
> +++ linux-next-20210526/arch/s390/Kconfig
> @@ -853,7 +853,7 @@ config CMM_IUCV
> config APPLDATA_BASE
> def_bool n
> prompt "Linux - VM Monitor Stream, base infrastructure"
> - depends on PROC_FS
> + depends on PROC_SYSCTL
> help
> This provides a kernel interface for creating and updating z/VM APPLDATA
> monitor records. The monitor records are updated at certain time
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-31 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28 0:24 [PATCH] S390: appldata depends on PROC_SYSCTL Randy Dunlap
2021-05-31 14:09 ` Vasily Gorbik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.