* [PATCH v2][next] floppy: Fix fall-through warning for Clang
@ 2021-05-28 20:03 Gustavo A. R. Silva
2021-05-29 6:37 ` Denis Efremov
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-28 20:03 UTC (permalink / raw)
To: Denis Efremov, Jens Axboe
Cc: linux-block, linux-kernel, Gustavo A. R. Silva, linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Link: https://lore.kernel.org/linux-hardening/47bcd36a-6524-348b-e802-0691d1b3c429@kernel.dk/
Suggested-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
Changes in v2:
- Add a break statement instead of fallthrough;
drivers/block/floppy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 8a9d22207c59..803af2a72520 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -2123,6 +2123,7 @@ static void format_interrupt(void)
switch (interpret_errors()) {
case 1:
cont->error();
+ break;
case 2:
break;
case 0:
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2][next] floppy: Fix fall-through warning for Clang
2021-05-28 20:03 [PATCH v2][next] floppy: Fix fall-through warning for Clang Gustavo A. R. Silva
@ 2021-05-29 6:37 ` Denis Efremov
2021-06-04 2:42 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Denis Efremov @ 2021-05-29 6:37 UTC (permalink / raw)
To: Gustavo A. R. Silva, Jens Axboe
Cc: linux-block, linux-kernel, linux-hardening
Hi,
On 5/28/21 11:03 PM, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Link: https://lore.kernel.org/linux-hardening/47bcd36a-6524-348b-e802-0691d1b3c429@kernel.dk/
> Suggested-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Applied, thanks!
https://github.com/evdenis/linux-floppy/commit/6eaddb2a2aa3acd0660537f9f6a12785be0ae830
I will send it to Jens with other floppy patches.
It will be in 5.14
Regards,
Denis
> ---
> Changes in v2:
> - Add a break statement instead of fallthrough;
>
> drivers/block/floppy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 8a9d22207c59..803af2a72520 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -2123,6 +2123,7 @@ static void format_interrupt(void)
> switch (interpret_errors()) {
> case 1:
> cont->error();
> + break;
> case 2:
> break;
> case 0:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2][next] floppy: Fix fall-through warning for Clang
2021-05-29 6:37 ` Denis Efremov
@ 2021-06-04 2:42 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-06-04 2:42 UTC (permalink / raw)
To: Denis Efremov, Gustavo A. R. Silva, Jens Axboe
Cc: linux-block, linux-kernel, linux-hardening
On 5/29/21 01:37, Denis Efremov wrote:
> Hi,
>
> On 5/28/21 11:03 PM, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Link: https://lore.kernel.org/linux-hardening/47bcd36a-6524-348b-e802-0691d1b3c429@kernel.dk/
>> Suggested-by: Jens Axboe <axboe@kernel.dk>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Applied, thanks!
> https://github.com/evdenis/linux-floppy/commit/6eaddb2a2aa3acd0660537f9f6a12785be0ae830
>
> I will send it to Jens with other floppy patches.
> It will be in 5.14
Awesome. :)
Thanks, Denis.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-04 3:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28 20:03 [PATCH v2][next] floppy: Fix fall-through warning for Clang Gustavo A. R. Silva
2021-05-29 6:37 ` Denis Efremov
2021-06-04 2:42 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.