* [PATCH] ASoC: snd-soc-lpass requires REGMAP_MMIO
@ 2021-05-29 18:49 Bertrand Jacquin
2021-06-01 12:59 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Bertrand Jacquin @ 2021-05-29 18:49 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, pierre-louis.bossart,
srinivas.kandagatla, alexandre.belloni
Cc: alsa-devel
With CONFIG_SND_SOC_LPASS_RX_MACRO=m and CONFIG_REGMAP_MMIO undefined,
build fails with the following error
make -f /var/tmp/portage/sys-kernel/stable-sources-5.12.8/work/linux-5.12.8-stable/scripts/Makefile.modpost
sed 's/\.ko$/\.o/' modules.order | scripts/mod/modpost -E -o modules-only.symvers -i vmlinux.symvers -T -
ERROR: modpost: "__devm_regmap_init_mmio_clk" [sound/soc/codecs/snd-soc-lpass-rx-macro.ko] undefined!
This does also apply to other Qualcomm Macro LPASS all making call to
devm_regmap_init_mmio()
---
sound/soc/codecs/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 1c87b42606c9..f5614f47f44d 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1824,18 +1824,22 @@ config SND_SOC_TPA6130A2
config SND_SOC_LPASS_WSA_MACRO
depends on COMMON_CLK
+ select REGMAP_MMIO
tristate "Qualcomm WSA Macro in LPASS(Low Power Audio SubSystem)"
config SND_SOC_LPASS_VA_MACRO
depends on COMMON_CLK
+ select REGMAP_MMIO
tristate "Qualcomm VA Macro in LPASS(Low Power Audio SubSystem)"
config SND_SOC_LPASS_RX_MACRO
depends on COMMON_CLK
+ select REGMAP_MMIO
tristate "Qualcomm RX Macro in LPASS(Low Power Audio SubSystem)"
config SND_SOC_LPASS_TX_MACRO
depends on COMMON_CLK
+ select REGMAP_MMIO
tristate "Qualcomm TX Macro in LPASS(Low Power Audio SubSystem)"
endmenu
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: snd-soc-lpass requires REGMAP_MMIO
2021-05-29 18:49 [PATCH] ASoC: snd-soc-lpass requires REGMAP_MMIO Bertrand Jacquin
@ 2021-06-01 12:59 ` Mark Brown
2021-06-03 22:18 ` Bertrand Jacquin
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2021-06-01 12:59 UTC (permalink / raw)
To: Bertrand Jacquin
Cc: alexandre.belloni, alsa-devel, lgirdwood, pierre-louis.bossart, tiwai
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Sat, May 29, 2021 at 07:49:57PM +0100, Bertrand Jacquin wrote:
> This does also apply to other Qualcomm Macro LPASS all making call to
> devm_regmap_init_mmio()
> ---
> sound/soc/codecs/Kconfig | 4 ++++
A Signed-off-by is required for patches, please see submitting-patches.rst
in the kernel tree for details on what this is and why it is important.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: snd-soc-lpass requires REGMAP_MMIO
2021-06-01 12:59 ` Mark Brown
@ 2021-06-03 22:18 ` Bertrand Jacquin
0 siblings, 0 replies; 5+ messages in thread
From: Bertrand Jacquin @ 2021-06-03 22:18 UTC (permalink / raw)
To: Mark Brown
Cc: alexandre.belloni, alsa-devel, lgirdwood, pierre-louis.bossart, tiwai
On Tuesday, June 01 2021 at 13:59:39 +0100, Mark Brown wrote:
> On Sat, May 29, 2021 at 07:49:57PM +0100, Bertrand Jacquin wrote:
>
> > This does also apply to other Qualcomm Macro LPASS all making call to
> > devm_regmap_init_mmio()
> > ---
> > sound/soc/codecs/Kconfig | 4 ++++
>
> A Signed-off-by is required for patches, please see submitting-patches.rst
> in the kernel tree for details on what this is and why it is important.
This sounds legit, I have submitted an updated version.
Cheers,
--
Bertrand
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: snd-soc-lpass requires REGMAP_MMIO
2021-06-03 22:18 Bertrand Jacquin
@ 2021-06-04 16:32 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-06-04 16:32 UTC (permalink / raw)
To: lgirdwood, alexandre.belloni, perex, Bertrand Jacquin,
srinivas.kandagatla, pierre-louis.bossart, tiwai
Cc: alsa-devel, Mark Brown
On Thu, 3 Jun 2021 23:18:16 +0100, Bertrand Jacquin wrote:
> With CONFIG_SND_SOC_LPASS_RX_MACRO=m and CONFIG_REGMAP_MMIO undefined,
> build fails with the following error
>
> make -f /var/tmp/portage/sys-kernel/stable-sources-5.12.8/work/linux-5.12.8-stable/scripts/Makefile.modpost
> sed 's/\.ko$/\.o/' modules.order | scripts/mod/modpost -E -o modules-only.symvers -i vmlinux.symvers -T -
> ERROR: modpost: "__devm_regmap_init_mmio_clk" [sound/soc/codecs/snd-soc-lpass-rx-macro.ko] undefined!
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: snd-soc-lpass requires REGMAP_MMIO
commit: e78f36bc13591e8d23948996ab6d195f1efa8f40
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ASoC: snd-soc-lpass requires REGMAP_MMIO
@ 2021-06-03 22:18 Bertrand Jacquin
2021-06-04 16:32 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Bertrand Jacquin @ 2021-06-03 22:18 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, pierre-louis.bossart,
srinivas.kandagatla, alexandre.belloni
Cc: alsa-devel
With CONFIG_SND_SOC_LPASS_RX_MACRO=m and CONFIG_REGMAP_MMIO undefined,
build fails with the following error
make -f /var/tmp/portage/sys-kernel/stable-sources-5.12.8/work/linux-5.12.8-stable/scripts/Makefile.modpost
sed 's/\.ko$/\.o/' modules.order | scripts/mod/modpost -E -o modules-only.symvers -i vmlinux.symvers -T -
ERROR: modpost: "__devm_regmap_init_mmio_clk" [sound/soc/codecs/snd-soc-lpass-rx-macro.ko] undefined!
This does also apply to other Qualcomm Macro LPASS all making call to
devm_regmap_init_mmio()
Signed-off-by: Bertrand Jacquin <bertrand@jacquin.bzh>
---
sound/soc/codecs/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 1c87b42606c9..f5614f47f44d 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1824,18 +1824,22 @@ config SND_SOC_TPA6130A2
config SND_SOC_LPASS_WSA_MACRO
depends on COMMON_CLK
+ select REGMAP_MMIO
tristate "Qualcomm WSA Macro in LPASS(Low Power Audio SubSystem)"
config SND_SOC_LPASS_VA_MACRO
depends on COMMON_CLK
+ select REGMAP_MMIO
tristate "Qualcomm VA Macro in LPASS(Low Power Audio SubSystem)"
config SND_SOC_LPASS_RX_MACRO
depends on COMMON_CLK
+ select REGMAP_MMIO
tristate "Qualcomm RX Macro in LPASS(Low Power Audio SubSystem)"
config SND_SOC_LPASS_TX_MACRO
depends on COMMON_CLK
+ select REGMAP_MMIO
tristate "Qualcomm TX Macro in LPASS(Low Power Audio SubSystem)"
endmenu
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-04 16:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-29 18:49 [PATCH] ASoC: snd-soc-lpass requires REGMAP_MMIO Bertrand Jacquin
2021-06-01 12:59 ` Mark Brown
2021-06-03 22:18 ` Bertrand Jacquin
2021-06-03 22:18 Bertrand Jacquin
2021-06-04 16:32 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.