* [PATCH nf-next] netfilter: nft_compat: fix bridge family target evaluation
@ 2021-05-29 16:50 Florian Westphal
2021-05-29 20:16 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2021-05-29 16:50 UTC (permalink / raw)
To: netfilter-devel; +Cc: Florian Westphal, kernel test robot
This always evals to true, so all packets get dropped in the ebtables
compat layer. ip(6)tables is fine.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 6d6dbfe7fe1e6e1 ("netfilter: nf_tables: remove xt_action_param from nft_pktinfo")
Signed-off-by: Florian Westphal <fw@strlen.de>
---
Pablo, feel free to squash if you prefer that.
net/netfilter/nft_compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nft_compat.c b/net/netfilter/nft_compat.c
index 936e244f5aba..3144a9ad2f6a 100644
--- a/net/netfilter/nft_compat.c
+++ b/net/netfilter/nft_compat.c
@@ -110,7 +110,7 @@ static void nft_target_eval_bridge(const struct nft_expr *expr,
ret = target->target(skb, &xt);
- if (&xt.hotdrop)
+ if (xt.hotdrop)
ret = NF_DROP;
switch (ret) {
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nf-next] netfilter: nft_compat: fix bridge family target evaluation
2021-05-29 16:50 [PATCH nf-next] netfilter: nft_compat: fix bridge family target evaluation Florian Westphal
@ 2021-05-29 20:16 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2021-05-29 20:16 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel, kernel test robot
On Sat, May 29, 2021 at 06:50:25PM +0200, Florian Westphal wrote:
> This always evals to true, so all packets get dropped in the ebtables
> compat layer. ip(6)tables is fine.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 6d6dbfe7fe1e6e1 ("netfilter: nf_tables: remove xt_action_param from nft_pktinfo")
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Pablo, feel free to squash if you prefer that.
Squashed, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-29 20:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-29 16:50 [PATCH nf-next] netfilter: nft_compat: fix bridge family target evaluation Florian Westphal
2021-05-29 20:16 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.