* [LTP] [PATCH 1/1] doc: Drop uClinux support
@ 2021-05-31 3:29 Petr Vorel
2021-05-31 3:37 ` Petr Vorel
2021-05-31 8:56 ` Cyril Hrubis
0 siblings, 2 replies; 5+ messages in thread
From: Petr Vorel @ 2021-05-31 3:29 UTC (permalink / raw)
To: ltp
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,
some shorter form could be added to 3. Test Contribution Checklist [1] as well.
Kind regards,
Petr
[1] https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#3-test-contribution-checklist
doc/maintainer-patch-review-checklist.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/maintainer-patch-review-checklist.txt b/doc/maintainer-patch-review-checklist.txt
index 5420fa933..81ed61ddf 100644
--- a/doc/maintainer-patch-review-checklist.txt
+++ b/doc/maintainer-patch-review-checklist.txt
@@ -44,6 +44,9 @@ New test should
* Docparse documentation
* If a test is a regression test it should include tags
(more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#2238-test-tags[Test tags])
+* When rewritting old tests, https://en.wikipedia.org/wiki/%CE%9CClinux[uClinux
+ (?Clinux)] support should be removed (project has been discontinued).
+ E.g. `FORK_OR_VFORK()` should be replaced with simple `fork()` or `SAFE_FORK()`.
### Shell tests
* Use new https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#23-writing-a-testcase-in-shell[shell API]
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [LTP] [PATCH 1/1] doc: Drop uClinux support
2021-05-31 3:29 [LTP] [PATCH 1/1] doc: Drop uClinux support Petr Vorel
@ 2021-05-31 3:37 ` Petr Vorel
2021-05-31 8:56 ` Cyril Hrubis
1 sibling, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2021-05-31 3:37 UTC (permalink / raw)
To: ltp
Hi,
[Cc: Mike ]
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi,
> some shorter form could be added to 3. Test Contribution Checklist [1] as well.
> Kind regards,
> Petr
> [1] https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#3-test-contribution-checklist
> doc/maintainer-patch-review-checklist.txt | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/doc/maintainer-patch-review-checklist.txt b/doc/maintainer-patch-review-checklist.txt
> index 5420fa933..81ed61ddf 100644
> --- a/doc/maintainer-patch-review-checklist.txt
> +++ b/doc/maintainer-patch-review-checklist.txt
> @@ -44,6 +44,9 @@ New test should
> * Docparse documentation
> * If a test is a regression test it should include tags
> (more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#2238-test-tags[Test tags])
> +* When rewritting old tests, https://en.wikipedia.org/wiki/%CE%9CClinux[uClinux
> + (?Clinux)] support should be removed (project has been discontinued).
> + E.g. `FORK_OR_VFORK()` should be replaced with simple `fork()` or `SAFE_FORK()`.
> ### Shell tests
> * Use new https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#23-writing-a-testcase-in-shell[shell API]
FYI: https://github.com/uclinux-dev
But that's just archiving the project, it's safe to remove uclinux support from
LTP.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH 1/1] doc: Drop uClinux support
2021-05-31 3:29 [LTP] [PATCH 1/1] doc: Drop uClinux support Petr Vorel
2021-05-31 3:37 ` Petr Vorel
@ 2021-05-31 8:56 ` Cyril Hrubis
2021-05-31 14:54 ` Petr Vorel
2021-06-02 11:18 ` Petr Vorel
1 sibling, 2 replies; 5+ messages in thread
From: Cyril Hrubis @ 2021-05-31 8:56 UTC (permalink / raw)
To: ltp
Hi!
> some shorter form could be added to 3. Test Contribution Checklist [1] as well.
>
> Kind regards,
> Petr
>
> [1] https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#3-test-contribution-checklist
>
> doc/maintainer-patch-review-checklist.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/doc/maintainer-patch-review-checklist.txt b/doc/maintainer-patch-review-checklist.txt
> index 5420fa933..81ed61ddf 100644
> --- a/doc/maintainer-patch-review-checklist.txt
> +++ b/doc/maintainer-patch-review-checklist.txt
> @@ -44,6 +44,9 @@ New test should
> * Docparse documentation
> * If a test is a regression test it should include tags
> (more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#2238-test-tags[Test tags])
> +* When rewritting old tests, https://en.wikipedia.org/wiki/%CE%9CClinux[uClinux
> + (??Clinux)] support should be removed (project has been discontinued).
^
I would just use u instead of \textmu
> + E.g. `FORK_OR_VFORK()` should be replaced with simple `fork()` or `SAFE_FORK()`.
+ and all #ifdef UCLINUX should be removed as well.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH 1/1] doc: Drop uClinux support
2021-05-31 8:56 ` Cyril Hrubis
@ 2021-05-31 14:54 ` Petr Vorel
2021-06-02 11:18 ` Petr Vorel
1 sibling, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2021-05-31 14:54 UTC (permalink / raw)
To: ltp
> Hi!
> > some shorter form could be added to 3. Test Contribution Checklist [1] as well.
> > Kind regards,
> > Petr
> > [1] https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#3-test-contribution-checklist
> > doc/maintainer-patch-review-checklist.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> > diff --git a/doc/maintainer-patch-review-checklist.txt b/doc/maintainer-patch-review-checklist.txt
> > index 5420fa933..81ed61ddf 100644
> > --- a/doc/maintainer-patch-review-checklist.txt
> > +++ b/doc/maintainer-patch-review-checklist.txt
> > @@ -44,6 +44,9 @@ New test should
> > * Docparse documentation
> > * If a test is a regression test it should include tags
> > (more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#2238-test-tags[Test tags])
> > +* When rewritting old tests, https://en.wikipedia.org/wiki/%CE%9CClinux[uClinux
> > + (??Clinux)] support should be removed (project has been discontinued).
> ^
> I would just use u instead of \textmu
> > + E.g. `FORK_OR_VFORK()` should be replaced with simple `fork()` or `SAFE_FORK()`.
> + and all #ifdef UCLINUX should be removed as well.
Oh yes, ifdefs were the primary reason for me to document this.
If nobody objects, I'll merge this tomorrow with your Reviewed-by: tag.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH 1/1] doc: Drop uClinux support
2021-05-31 8:56 ` Cyril Hrubis
2021-05-31 14:54 ` Petr Vorel
@ 2021-06-02 11:18 ` Petr Vorel
1 sibling, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2021-06-02 11:18 UTC (permalink / raw)
To: ltp
> Hi!
> > some shorter form could be added to 3. Test Contribution Checklist [1] as well.
> > Kind regards,
> > Petr
> > [1] https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#3-test-contribution-checklist
> > doc/maintainer-patch-review-checklist.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> > diff --git a/doc/maintainer-patch-review-checklist.txt b/doc/maintainer-patch-review-checklist.txt
> > index 5420fa933..81ed61ddf 100644
> > --- a/doc/maintainer-patch-review-checklist.txt
> > +++ b/doc/maintainer-patch-review-checklist.txt
> > @@ -44,6 +44,9 @@ New test should
> > * Docparse documentation
> > * If a test is a regression test it should include tags
> > (more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#2238-test-tags[Test tags])
> > +* When rewritting old tests, https://en.wikipedia.org/wiki/%CE%9CClinux[uClinux
> > + (??Clinux)] support should be removed (project has been discontinued).
> ^
> I would just use u instead of \textmu
> > + E.g. `FORK_OR_VFORK()` should be replaced with simple `fork()` or `SAFE_FORK()`.
> + and all #ifdef UCLINUX should be removed as well.
Fixed and merged.
Thanks!
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-02 11:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-31 3:29 [LTP] [PATCH 1/1] doc: Drop uClinux support Petr Vorel
2021-05-31 3:37 ` Petr Vorel
2021-05-31 8:56 ` Cyril Hrubis
2021-05-31 14:54 ` Petr Vorel
2021-06-02 11:18 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.