* [PATCH] target/nios2: Mark raise_exception() as noreturn
@ 2021-05-31 9:30 Philippe Mathieu-Daudé
2021-06-01 13:46 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-31 9:30 UTC (permalink / raw)
To: qemu-devel
Cc: Marek Vasut, Jeff Da Silva, Chris Wulff, Richard Henderson,
Philippe Mathieu-Daudé,
Sandra Loosemore, Yves Vandervennet, Ley Foon Tan
Raised exceptions don't return, so mark the helper with
TCG_CALL_NO_RETURN.
Fixes: 032c76bc6f9 ("nios2: Add architecture emulation support")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/nios2/helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/nios2/helper.h b/target/nios2/helper.h
index b0cb9146a5f..9bf14c128ed 100644
--- a/target/nios2/helper.h
+++ b/target/nios2/helper.h
@@ -18,7 +18,7 @@
* <http://www.gnu.org/licenses/lgpl-2.1.html>
*/
-DEF_HELPER_2(raise_exception, void, env, i32)
+DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_RETURN, noreturn, env, i32)
#if !defined(CONFIG_USER_ONLY)
DEF_HELPER_2(mmu_read_debug, void, env, i32)
--
2.26.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/nios2: Mark raise_exception() as noreturn
2021-05-31 9:30 [PATCH] target/nios2: Mark raise_exception() as noreturn Philippe Mathieu-Daudé
@ 2021-06-01 13:46 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2021-06-01 13:46 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Marek Vasut, Jeff Da Silva, Chris Wulff, Sandra Loosemore,
Yves Vandervennet, Ley Foon Tan
On 5/31/21 2:30 AM, Philippe Mathieu-Daudé wrote:
> Raised exceptions don't return, so mark the helper with
> TCG_CALL_NO_RETURN.
>
> Fixes: 032c76bc6f9 ("nios2: Add architecture emulation support")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/nios2/helper.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/nios2/helper.h b/target/nios2/helper.h
> index b0cb9146a5f..9bf14c128ed 100644
> --- a/target/nios2/helper.h
> +++ b/target/nios2/helper.h
> @@ -18,7 +18,7 @@
> * <http://www.gnu.org/licenses/lgpl-2.1.html>
> */
>
> -DEF_HELPER_2(raise_exception, void, env, i32)
> +DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_RETURN, noreturn, env, i32)
The noreturn is what you want for that.
For the flags, you probably want TCG_CALL_NO_WG.
>
> #if !defined(CONFIG_USER_ONLY)
> DEF_HELPER_2(mmu_read_debug, void, env, i32)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-01 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-31 9:30 [PATCH] target/nios2: Mark raise_exception() as noreturn Philippe Mathieu-Daudé
2021-06-01 13:46 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.