* [PATCH] kbuild: skip per-CPU BTF generation for pahole v1.18-v1.21
@ 2021-05-30 0:25 Andrii Nakryiko
2021-05-31 9:34 ` Mel Gorman
0 siblings, 1 reply; 2+ messages in thread
From: Andrii Nakryiko @ 2021-05-30 0:25 UTC (permalink / raw)
To: akpm
Cc: bpf, mgorman, msuchanek, linux-kernel, linux-mm, hritikxx8,
jolsa, kernel-team, Andrii Nakryiko, Arnaldo Carvalho de Melo,
Hao Luo
Commit "mm/page_alloc: convert per-cpu list protection to local_lock"
introduced a zero-sized per-CPU variable, which causes pahole to generate
invalid BTF. Only pahole versions 1.18 through 1.21 are impacted, as before
1.18 pahole doesn't know anything about per-CPU variables, and 1.22 contains
the proper fix for the issue.
Luckily, pahole 1.18 got --skip_encoding_btf_vars option disabling BTF
generation for per-CPU variables in anticipation of some unanticipated
problems. So use this escape hatch to disable per-CPU var BTF info on those
problematic pahole versions. Users relying on availability of per-CPU var BTFs
would need to upgrade to pahole 1.22+, but everyone won't notice any
regressions.
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Hao Luo <haoluo@google.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
scripts/link-vmlinux.sh | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index 3b342b0b0b38..66e7053aa907 100755
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -233,6 +233,10 @@ gen_btf()
vmlinux_link ${1}
+ if [ "${pahole_ver}" -ge "118" ] && [ "${pahole_ver}" -le "121" ]; then
+ # pahole 1.18 through 1.21 can't handle zero-sized per-CPU vars
+ extra_paholeopt="${extra_paholeopt} --skip_encoding_btf_vars"
+ fi
if [ "${pahole_ver}" -ge "121" ]; then
extra_paholeopt="${extra_paholeopt} --btf_gen_floats"
fi
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: skip per-CPU BTF generation for pahole v1.18-v1.21
2021-05-30 0:25 [PATCH] kbuild: skip per-CPU BTF generation for pahole v1.18-v1.21 Andrii Nakryiko
@ 2021-05-31 9:34 ` Mel Gorman
0 siblings, 0 replies; 2+ messages in thread
From: Mel Gorman @ 2021-05-31 9:34 UTC (permalink / raw)
To: Andrii Nakryiko
Cc: akpm, bpf, msuchanek, linux-kernel, linux-mm, hritikxx8, jolsa,
kernel-team, Arnaldo Carvalho de Melo, Hao Luo
On Sat, May 29, 2021 at 05:25:36PM -0700, Andrii Nakryiko wrote:
> Commit "mm/page_alloc: convert per-cpu list protection to local_lock"
> introduced a zero-sized per-CPU variable, which causes pahole to generate
> invalid BTF. Only pahole versions 1.18 through 1.21 are impacted, as before
> 1.18 pahole doesn't know anything about per-CPU variables, and 1.22 contains
> the proper fix for the issue.
>
> Luckily, pahole 1.18 got --skip_encoding_btf_vars option disabling BTF
> generation for per-CPU variables in anticipation of some unanticipated
> problems. So use this escape hatch to disable per-CPU var BTF info on those
> problematic pahole versions. Users relying on availability of per-CPU var BTFs
> would need to upgrade to pahole 1.22+, but everyone won't notice any
> regressions.
>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Hao Luo <haoluo@google.com>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-31 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-30 0:25 [PATCH] kbuild: skip per-CPU BTF generation for pahole v1.18-v1.21 Andrii Nakryiko
2021-05-31 9:34 ` Mel Gorman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.