All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'
@ 2021-05-30 11:58 ` kernel test robot
  0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2021-05-30 11:58 UTC (permalink / raw)
  To: Mel Gorman
  Cc: kbuild-all, clang-built-linux, Linux Memory Management List,
	Yang Shi, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 7913 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   3e029760e6f8ce90c122c267a039ae73b3f1f5a4
commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust
config: x86_64-randconfig-a006-20210530 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/udl/udl_modeset.c:12:
   In file included from include/linux/dma-buf.h:16:
   In file included from include/linux/dma-buf-map.h:9:
   In file included from include/linux/io.h:13:
   In file included from arch/x86/include/asm/io.h:44:
   In file included from ./arch/x86/include/generated/asm/early_ioremap.h:1:
   In file included from include/asm-generic/early_ioremap.h:6:
>> arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'
           FIX_KMAP_END = FIX_KMAP_BEGIN + (KM_MAX_IDX * NR_CPUS) - 1,
                                                         ^
   1 error generated.


vim +/NR_CPUS +103 arch/x86/include/asm/fixmap.h

c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   61  
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   62  /*
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   63   * Here we define all the compile-time 'special' virtual
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   64   * addresses. The point is to have a constant address at
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   65   * compile time, but to set the physical address only
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   66   * in the boot process.
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   67   * for x86_32: We allocate these special addresses
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   68   * from the end of virtual memory (0xfffff000) backwards.
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   69   * Also this lets us do fail-safe vmalloc(), we
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   70   * can guarantee that these special addresses and
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   71   * vmalloc()-ed addresses never overlap.
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   72   *
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   73   * These 'compile-time allocated' memory buffers are
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   74   * fixed-size 4k pages (or larger if used with an increment
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   75   * higher than 1). Use set_fixmap(idx,phys) to associate
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   76   * physical memory with fixmap indices.
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   77   *
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   78   * TLB entries of such buffers will not be flushed across
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   79   * task switches.
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   80   */
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   81  enum fixed_addresses {
96a388de5dc53a include/asm-x86/fixmap.h      Thomas Gleixner 2007-10-11   82  #ifdef CONFIG_X86_32
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   83  	FIX_HOLE,
96a388de5dc53a include/asm-x86/fixmap.h      Thomas Gleixner 2007-10-11   84  #else
1ad83c858c7d4e arch/x86/include/asm/fixmap.h Andy Lutomirski 2014-10-29   85  #ifdef CONFIG_X86_VSYSCALL_EMULATION
f40c330091c7aa arch/x86/include/asm/fixmap.h Andy Lutomirski 2014-05-05   86  	VSYSCALL_PAGE = (FIXADDR_TOP - VSYSCALL_ADDR) >> PAGE_SHIFT,
1ad83c858c7d4e arch/x86/include/asm/fixmap.h Andy Lutomirski 2014-10-29   87  #endif
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   88  #endif
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   89  	FIX_DBGP_BASE,
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   90  	FIX_EARLYCON_MEM_BASE,
ff30a0543e9a6c arch/x86/include/asm/fixmap.h Jan Beulich     2010-03-15   91  #ifdef CONFIG_PROVIDE_OHCI1394_DMA_INIT
ff30a0543e9a6c arch/x86/include/asm/fixmap.h Jan Beulich     2010-03-15   92  	FIX_OHCI1394_BASE,
ff30a0543e9a6c arch/x86/include/asm/fixmap.h Jan Beulich     2010-03-15   93  #endif
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   94  #ifdef CONFIG_X86_LOCAL_APIC
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   95  	FIX_APIC_BASE,	/* local (CPU) APIC) -- required for SMP or not */
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   96  #endif
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   97  #ifdef CONFIG_X86_IO_APIC
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   98  	FIX_IO_APIC_BASE_0,
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   99  	FIX_IO_APIC_BASE_END = FIX_IO_APIC_BASE_0 + MAX_IO_APICS - 1,
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  100  #endif
14df3267029158 arch/x86/include/asm/fixmap.h Thomas Gleixner 2020-11-18  101  #ifdef CONFIG_KMAP_LOCAL
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  102  	FIX_KMAP_BEGIN,	/* reserved pte's for temporary kernel mappings */
157e118b55113d arch/x86/include/asm/fixmap.h Thomas Gleixner 2020-11-03 @103  	FIX_KMAP_END = FIX_KMAP_BEGIN + (KM_MAX_IDX * NR_CPUS) - 1,
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  104  #ifdef CONFIG_PCI_MMCONFIG
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  105  	FIX_PCIE_MCFG,
96a388de5dc53a include/asm-x86/fixmap.h      Thomas Gleixner 2007-10-11  106  #endif
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  107  #endif
ecac71816a1829 arch/x86/include/asm/fixmap.h Juergen Gross   2020-08-15  108  #ifdef CONFIG_PARAVIRT_XXL
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  109  	FIX_PARAVIRT_BOOTMAP,
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  110  #endif
69218e47994da6 arch/x86/include/asm/fixmap.h Thomas Garnier  2017-03-14  111  

:::::: The code at line 103 was first introduced by commit
:::::: 157e118b55113d1e6c7f8ddfcec0a1dbf3a69511 x86/mm/highmem: Use generic kmap atomic implementation

:::::: TO: Thomas Gleixner <tglx@linutronix.de>
:::::: CC: Thomas Gleixner <tglx@linutronix.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41603 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'
@ 2021-05-30 11:58 ` kernel test robot
  0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2021-05-30 11:58 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 8013 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   3e029760e6f8ce90c122c267a039ae73b3f1f5a4
commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust
config: x86_64-randconfig-a006-20210530 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/udl/udl_modeset.c:12:
   In file included from include/linux/dma-buf.h:16:
   In file included from include/linux/dma-buf-map.h:9:
   In file included from include/linux/io.h:13:
   In file included from arch/x86/include/asm/io.h:44:
   In file included from ./arch/x86/include/generated/asm/early_ioremap.h:1:
   In file included from include/asm-generic/early_ioremap.h:6:
>> arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'
           FIX_KMAP_END = FIX_KMAP_BEGIN + (KM_MAX_IDX * NR_CPUS) - 1,
                                                         ^
   1 error generated.


vim +/NR_CPUS +103 arch/x86/include/asm/fixmap.h

c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   61  
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   62  /*
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   63   * Here we define all the compile-time 'special' virtual
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   64   * addresses. The point is to have a constant address at
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   65   * compile time, but to set the physical address only
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   66   * in the boot process.
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   67   * for x86_32: We allocate these special addresses
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   68   * from the end of virtual memory (0xfffff000) backwards.
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   69   * Also this lets us do fail-safe vmalloc(), we
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   70   * can guarantee that these special addresses and
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   71   * vmalloc()-ed addresses never overlap.
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   72   *
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   73   * These 'compile-time allocated' memory buffers are
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   74   * fixed-size 4k pages (or larger if used with an increment
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   75   * higher than 1). Use set_fixmap(idx,phys) to associate
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   76   * physical memory with fixmap indices.
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   77   *
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   78   * TLB entries of such buffers will not be flushed across
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   79   * task switches.
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   80   */
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   81  enum fixed_addresses {
96a388de5dc53a include/asm-x86/fixmap.h      Thomas Gleixner 2007-10-11   82  #ifdef CONFIG_X86_32
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   83  	FIX_HOLE,
96a388de5dc53a include/asm-x86/fixmap.h      Thomas Gleixner 2007-10-11   84  #else
1ad83c858c7d4e arch/x86/include/asm/fixmap.h Andy Lutomirski 2014-10-29   85  #ifdef CONFIG_X86_VSYSCALL_EMULATION
f40c330091c7aa arch/x86/include/asm/fixmap.h Andy Lutomirski 2014-05-05   86  	VSYSCALL_PAGE = (FIXADDR_TOP - VSYSCALL_ADDR) >> PAGE_SHIFT,
1ad83c858c7d4e arch/x86/include/asm/fixmap.h Andy Lutomirski 2014-10-29   87  #endif
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   88  #endif
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   89  	FIX_DBGP_BASE,
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   90  	FIX_EARLYCON_MEM_BASE,
ff30a0543e9a6c arch/x86/include/asm/fixmap.h Jan Beulich     2010-03-15   91  #ifdef CONFIG_PROVIDE_OHCI1394_DMA_INIT
ff30a0543e9a6c arch/x86/include/asm/fixmap.h Jan Beulich     2010-03-15   92  	FIX_OHCI1394_BASE,
ff30a0543e9a6c arch/x86/include/asm/fixmap.h Jan Beulich     2010-03-15   93  #endif
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   94  #ifdef CONFIG_X86_LOCAL_APIC
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   95  	FIX_APIC_BASE,	/* local (CPU) APIC) -- required for SMP or not */
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   96  #endif
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   97  #ifdef CONFIG_X86_IO_APIC
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   98  	FIX_IO_APIC_BASE_0,
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15   99  	FIX_IO_APIC_BASE_END = FIX_IO_APIC_BASE_0 + MAX_IO_APICS - 1,
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  100  #endif
14df3267029158 arch/x86/include/asm/fixmap.h Thomas Gleixner 2020-11-18  101  #ifdef CONFIG_KMAP_LOCAL
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  102  	FIX_KMAP_BEGIN,	/* reserved pte's for temporary kernel mappings */
157e118b55113d arch/x86/include/asm/fixmap.h Thomas Gleixner 2020-11-03 @103  	FIX_KMAP_END = FIX_KMAP_BEGIN + (KM_MAX_IDX * NR_CPUS) - 1,
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  104  #ifdef CONFIG_PCI_MMCONFIG
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  105  	FIX_PCIE_MCFG,
96a388de5dc53a include/asm-x86/fixmap.h      Thomas Gleixner 2007-10-11  106  #endif
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  107  #endif
ecac71816a1829 arch/x86/include/asm/fixmap.h Juergen Gross   2020-08-15  108  #ifdef CONFIG_PARAVIRT_XXL
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  109  	FIX_PARAVIRT_BOOTMAP,
c577b098f9bf46 arch/x86/include/asm/fixmap.h Gustavo Padovan 2009-02-15  110  #endif
69218e47994da6 arch/x86/include/asm/fixmap.h Thomas Garnier  2017-03-14  111  

:::::: The code at line 103 was first introduced by commit
:::::: 157e118b55113d1e6c7f8ddfcec0a1dbf3a69511 x86/mm/highmem: Use generic kmap atomic implementation

:::::: TO: Thomas Gleixner <tglx@linutronix.de>
:::::: CC: Thomas Gleixner <tglx@linutronix.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41603 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'
  2021-05-30 11:58 ` kernel test robot
@ 2021-05-31  9:39   ` Mel Gorman
  -1 siblings, 0 replies; 8+ messages in thread
From: Mel Gorman @ 2021-05-31  9:39 UTC (permalink / raw)
  To: kernel test robot
  Cc: kbuild-all, clang-built-linux, Linux Memory Management List,
	Yang Shi, Andrew Morton

On Sun, May 30, 2021 at 07:58:14PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   3e029760e6f8ce90c122c267a039ae73b3f1f5a4
> commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust
> config: x86_64-randconfig-a006-20210530 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install x86_64 cross compiling tool for clang build
>         # apt-get install binutils-x86-64-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> 

Hi Andrew,

Can you please drop the patch
mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust.patch?

-- 
Mel Gorman
SUSE Labs


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'
@ 2021-05-31  9:39   ` Mel Gorman
  0 siblings, 0 replies; 8+ messages in thread
From: Mel Gorman @ 2021-05-31  9:39 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

On Sun, May 30, 2021 at 07:58:14PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   3e029760e6f8ce90c122c267a039ae73b3f1f5a4
> commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust
> config: x86_64-randconfig-a006-20210530 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install x86_64 cross compiling tool for clang build
>         # apt-get install binutils-x86-64-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> 

Hi Andrew,

Can you please drop the patch
mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust.patch?

-- 
Mel Gorman
SUSE Labs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'
  2021-05-31  9:39   ` Mel Gorman
@ 2021-05-31 22:05     ` Andrew Morton
  -1 siblings, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2021-05-31 22:05 UTC (permalink / raw)
  To: Mel Gorman
  Cc: kernel test robot, kbuild-all, clang-built-linux,
	Linux Memory Management List, Yang Shi

On Mon, 31 May 2021 10:39:17 +0100 Mel Gorman <mgorman@suse.de> wrote:

> On Sun, May 30, 2021 at 07:58:14PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   3e029760e6f8ce90c122c267a039ae73b3f1f5a4
> > commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust
> > config: x86_64-randconfig-a006-20210530 (attached as .config)
> > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # install x86_64 cross compiling tool for clang build
> >         # apt-get install binutils-x86-64-linux-gnu
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> > 
> 
> Hi Andrew,
> 
> Can you please drop the patch
> mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust.patch?

Didn't I fix this with
mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix.patch?

This fix is lame - x86's fixmap.h should be standalone.  But this gets us
moving ahead with the MM changes for now.



From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix

x86_64 asm/fixmap.h needs linux/threads.h for NR_CPUS

Cc: Dan Streetman <ddstreet@ieee.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Yang Shi <shy828301@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/asm-generic/early_ioremap.h |    1 +
 1 file changed, 1 insertion(+)

--- a/include/asm-generic/early_ioremap.h~mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix
+++ a/include/asm-generic/early_ioremap.h
@@ -3,6 +3,7 @@
 #define _ASM_EARLY_IOREMAP_H_
 
 #include <linux/types.h>
+#include <linux/threads.h>	/* x86 fixmap.h needs NR_CPUS */
 #include <asm/fixmap.h>
 
 /*
_



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'
@ 2021-05-31 22:05     ` Andrew Morton
  0 siblings, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2021-05-31 22:05 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2685 bytes --]

On Mon, 31 May 2021 10:39:17 +0100 Mel Gorman <mgorman@suse.de> wrote:

> On Sun, May 30, 2021 at 07:58:14PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   3e029760e6f8ce90c122c267a039ae73b3f1f5a4
> > commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust
> > config: x86_64-randconfig-a006-20210530 (attached as .config)
> > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # install x86_64 cross compiling tool for clang build
> >         # apt-get install binutils-x86-64-linux-gnu
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> > 
> 
> Hi Andrew,
> 
> Can you please drop the patch
> mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust.patch?

Didn't I fix this with
mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix.patch?

This fix is lame - x86's fixmap.h should be standalone.  But this gets us
moving ahead with the MM changes for now.



From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix

x86_64 asm/fixmap.h needs linux/threads.h for NR_CPUS

Cc: Dan Streetman <ddstreet@ieee.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Yang Shi <shy828301@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/asm-generic/early_ioremap.h |    1 +
 1 file changed, 1 insertion(+)

--- a/include/asm-generic/early_ioremap.h~mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix
+++ a/include/asm-generic/early_ioremap.h
@@ -3,6 +3,7 @@
 #define _ASM_EARLY_IOREMAP_H_
 
 #include <linux/types.h>
+#include <linux/threads.h>	/* x86 fixmap.h needs NR_CPUS */
 #include <asm/fixmap.h>
 
 /*
_

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'
  2021-05-31 22:05     ` Andrew Morton
@ 2021-06-01  7:48       ` Mel Gorman
  -1 siblings, 0 replies; 8+ messages in thread
From: Mel Gorman @ 2021-06-01  7:48 UTC (permalink / raw)
  To: Andrew Morton
  Cc: kernel test robot, kbuild-all, clang-built-linux,
	Linux Memory Management List, Yang Shi

On Mon, May 31, 2021 at 03:05:54PM -0700, Andrew Morton wrote:
> On Mon, 31 May 2021 10:39:17 +0100 Mel Gorman <mgorman@suse.de> wrote:
> 
> > On Sun, May 30, 2021 at 07:58:14PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head:   3e029760e6f8ce90c122c267a039ae73b3f1f5a4
> > > commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust
> > > config: x86_64-randconfig-a006-20210530 (attached as .config)
> > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # install x86_64 cross compiling tool for clang build
> > >         # apt-get install binutils-x86-64-linux-gnu
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c
> > >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > >         git fetch --no-tags linux-next master
> > >         git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c
> > >         # save the attached .config to linux build tree
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> > > 
> > 
> > Hi Andrew,
> > 
> > Can you please drop the patch
> > mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust.patch?
> 
> Didn't I fix this with
> mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix.patch?
> 
> This fix is lame - x86's fixmap.h should be standalone.  But this gets us
> moving ahead with the MM changes for now.
> 

I think you did fix it but I was surprised by the level
of fallout from this patch and then there were objections
to adding header dependencies unnecessarily such as this
https://lore.kernel.org/lkml/YK3vrIB7cWop+UIW@gmail.com/ .  That was
specific to modifying the x86 headers so your fix should not hit the same
objection but still, as you said, x86 fixmap should be standalone.

-- 
Mel Gorman
SUSE Labs


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'
@ 2021-06-01  7:48       ` Mel Gorman
  0 siblings, 0 replies; 8+ messages in thread
From: Mel Gorman @ 2021-06-01  7:48 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2324 bytes --]

On Mon, May 31, 2021 at 03:05:54PM -0700, Andrew Morton wrote:
> On Mon, 31 May 2021 10:39:17 +0100 Mel Gorman <mgorman@suse.de> wrote:
> 
> > On Sun, May 30, 2021 at 07:58:14PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head:   3e029760e6f8ce90c122c267a039ae73b3f1f5a4
> > > commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust
> > > config: x86_64-randconfig-a006-20210530 (attached as .config)
> > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # install x86_64 cross compiling tool for clang build
> > >         # apt-get install binutils-x86-64-linux-gnu
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c
> > >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > >         git fetch --no-tags linux-next master
> > >         git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c
> > >         # save the attached .config to linux build tree
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> > > 
> > 
> > Hi Andrew,
> > 
> > Can you please drop the patch
> > mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust.patch?
> 
> Didn't I fix this with
> mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix.patch?
> 
> This fix is lame - x86's fixmap.h should be standalone.  But this gets us
> moving ahead with the MM changes for now.
> 

I think you did fix it but I was surprised by the level
of fallout from this patch and then there were objections
to adding header dependencies unnecessarily such as this
https://lore.kernel.org/lkml/YK3vrIB7cWop+UIW(a)gmail.com/ .  That was
specific to modifying the x86 headers so your fix should not hit the same
objection but still, as you said, x86 fixmap should be standalone.

-- 
Mel Gorman
SUSE Labs

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-06-01  7:48 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-30 11:58 [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS' kernel test robot
2021-05-30 11:58 ` kernel test robot
2021-05-31  9:39 ` Mel Gorman
2021-05-31  9:39   ` Mel Gorman
2021-05-31 22:05   ` Andrew Morton
2021-05-31 22:05     ` Andrew Morton
2021-06-01  7:48     ` Mel Gorman
2021-06-01  7:48       ` Mel Gorman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.