* [PATCH] ext4: fsmap: Fix the block/inode bitmap comment
@ 2021-05-31 3:49 Ritesh Harjani
2021-05-31 22:51 ` Darrick J. Wong
2021-06-24 13:48 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Ritesh Harjani @ 2021-05-31 3:49 UTC (permalink / raw)
To: linux-ext4; +Cc: Theodore Ts'o, Ritesh Harjani
While debugging fstest ext4/027 failure, found below comment to be wrong and
confusing. Hence fix it while we are at it.
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
---
fs/ext4/fsmap.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/fsmap.h b/fs/ext4/fsmap.h
index 68c8001fee85..ac642be2302e 100644
--- a/fs/ext4/fsmap.h
+++ b/fs/ext4/fsmap.h
@@ -50,7 +50,7 @@ int ext4_getfsmap(struct super_block *sb, struct ext4_fsmap_head *head,
#define EXT4_FMR_OWN_INODES FMR_OWNER('X', 5) /* inodes */
#define EXT4_FMR_OWN_GDT FMR_OWNER('f', 1) /* group descriptors */
#define EXT4_FMR_OWN_RESV_GDT FMR_OWNER('f', 2) /* reserved gdt blocks */
-#define EXT4_FMR_OWN_BLKBM FMR_OWNER('f', 3) /* inode bitmap */
-#define EXT4_FMR_OWN_INOBM FMR_OWNER('f', 4) /* block bitmap */
+#define EXT4_FMR_OWN_BLKBM FMR_OWNER('f', 3) /* block bitmap */
+#define EXT4_FMR_OWN_INOBM FMR_OWNER('f', 4) /* inode bitmap */
#endif /* __EXT4_FSMAP_H__ */
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: fsmap: Fix the block/inode bitmap comment
2021-05-31 3:49 [PATCH] ext4: fsmap: Fix the block/inode bitmap comment Ritesh Harjani
@ 2021-05-31 22:51 ` Darrick J. Wong
2021-06-24 13:48 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2021-05-31 22:51 UTC (permalink / raw)
To: Ritesh Harjani; +Cc: linux-ext4, Theodore Ts'o
On Mon, May 31, 2021 at 09:19:08AM +0530, Ritesh Harjani wrote:
> While debugging fstest ext4/027 failure, found below comment to be wrong and
> confusing. Hence fix it while we are at it.
>
> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Doh. Thanks for fixing that.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/ext4/fsmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/fsmap.h b/fs/ext4/fsmap.h
> index 68c8001fee85..ac642be2302e 100644
> --- a/fs/ext4/fsmap.h
> +++ b/fs/ext4/fsmap.h
> @@ -50,7 +50,7 @@ int ext4_getfsmap(struct super_block *sb, struct ext4_fsmap_head *head,
> #define EXT4_FMR_OWN_INODES FMR_OWNER('X', 5) /* inodes */
> #define EXT4_FMR_OWN_GDT FMR_OWNER('f', 1) /* group descriptors */
> #define EXT4_FMR_OWN_RESV_GDT FMR_OWNER('f', 2) /* reserved gdt blocks */
> -#define EXT4_FMR_OWN_BLKBM FMR_OWNER('f', 3) /* inode bitmap */
> -#define EXT4_FMR_OWN_INOBM FMR_OWNER('f', 4) /* block bitmap */
> +#define EXT4_FMR_OWN_BLKBM FMR_OWNER('f', 3) /* block bitmap */
> +#define EXT4_FMR_OWN_INOBM FMR_OWNER('f', 4) /* inode bitmap */
>
> #endif /* __EXT4_FSMAP_H__ */
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: fsmap: Fix the block/inode bitmap comment
2021-05-31 3:49 [PATCH] ext4: fsmap: Fix the block/inode bitmap comment Ritesh Harjani
2021-05-31 22:51 ` Darrick J. Wong
@ 2021-06-24 13:48 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2021-06-24 13:48 UTC (permalink / raw)
To: Ritesh Harjani; +Cc: linux-ext4
On Mon, May 31, 2021 at 09:19:08AM +0530, Ritesh Harjani wrote:
> While debugging fstest ext4/027 failure, found below comment to be wrong and
> confusing. Hence fix it while we are at it.
>
> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-24 13:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-31 3:49 [PATCH] ext4: fsmap: Fix the block/inode bitmap comment Ritesh Harjani
2021-05-31 22:51 ` Darrick J. Wong
2021-06-24 13:48 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.