* [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in flexrm_mbox_probe()
@ 2021-06-01 8:28 Zhihao Cheng
2021-06-09 12:13 ` Zhihao Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Zhihao Cheng @ 2021-06-01 8:28 UTC (permalink / raw)
To: jaswinder.singh, eric, jassisinghbrar
Cc: bcm-kernel-feedback-list, linux-kernel, linux-rpi-kernel,
chengzhihao1, yukuai3
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
---
drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
index b4f33dc399a0..78073ad1f2f1 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
if (IS_ERR(mbox->regs)) {
ret = PTR_ERR(mbox->regs);
- dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
goto fail;
}
regs_end = mbox->regs + resource_size(iomem);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in flexrm_mbox_probe()
2021-06-01 8:28 [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in flexrm_mbox_probe() Zhihao Cheng
@ 2021-06-09 12:13 ` Zhihao Cheng
2021-06-09 15:57 ` Scott Branden
0 siblings, 1 reply; 3+ messages in thread
From: Zhihao Cheng @ 2021-06-09 12:13 UTC (permalink / raw)
To: jaswinder.singh, eric, jassisinghbrar
Cc: bcm-kernel-feedback-list, linux-kernel, linux-rpi-kernel, yukuai3
在 2021/6/1 16:28, Zhihao Cheng 写道:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> ---
> drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
> index b4f33dc399a0..78073ad1f2f1 100644
> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
> @@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
> mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
> if (IS_ERR(mbox->regs)) {
> ret = PTR_ERR(mbox->regs);
> - dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
> goto fail;
> }
> regs_end = mbox->regs + resource_size(iomem);
friendly ping.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in flexrm_mbox_probe()
2021-06-09 12:13 ` Zhihao Cheng
@ 2021-06-09 15:57 ` Scott Branden
0 siblings, 0 replies; 3+ messages in thread
From: Scott Branden @ 2021-06-09 15:57 UTC (permalink / raw)
To: Zhihao Cheng, jaswinder.singh, eric, jassisinghbrar
Cc: bcm-kernel-feedback-list, linux-kernel, linux-rpi-kernel, yukuai3
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
On 2021-06-09 5:13 a.m., Zhihao Cheng wrote:
> 在 2021/6/1 16:28, Zhihao Cheng 写道:
>> There is a error message within devm_ioremap_resource
>> already, so remove the dev_err call to avoid redundant
>> error message.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Acked-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>> drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
>> index b4f33dc399a0..78073ad1f2f1 100644
>> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
>> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
>> @@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
>> mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>> if (IS_ERR(mbox->regs)) {
>> ret = PTR_ERR(mbox->regs);
>> - dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>> goto fail;
>> }
>> regs_end = mbox->regs + resource_size(iomem);
>
> friendly ping.
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-09 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 8:28 [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in flexrm_mbox_probe() Zhihao Cheng
2021-06-09 12:13 ` Zhihao Cheng
2021-06-09 15:57 ` Scott Branden
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.