All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: khilman@baylibre.com, jbrunet@baylibre.com,
	martin.blumenstingl@googlemail.com
Cc: linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, tobetter@gmail.com,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: [PATCH 3/6] arm64: dts: meson-sm1-odroid-c4: fix hub_5v regulator gpio
Date: Tue,  1 Jun 2021 11:01:37 +0200	[thread overview]
Message-ID: <20210601090140.261768-4-narmstrong@baylibre.com> (raw)
In-Reply-To: <20210601090140.261768-1-narmstrong@baylibre.com>

As described in the Odroid-C4 schematics, the HUB_5V regulator is controlled
by GPIOH_8 and in Open Drain since this GPIO doesn't support Push-Pull.

Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
index 8c327c03d845..63695ea21b1c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
@@ -31,7 +31,7 @@ hub_5v: regulator-hub_5v {
 		vin-supply = <&vcc_5v>;
 
 		/* Connected to the Hub CHIPENABLE, LOW sets low power state */
-		gpio = <&gpio GPIOH_4 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
 		enable-active-high;
 	};
 
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: khilman@baylibre.com, jbrunet@baylibre.com,
	martin.blumenstingl@googlemail.com
Cc: linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, tobetter@gmail.com,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: [PATCH 3/6] arm64: dts: meson-sm1-odroid-c4: fix hub_5v regulator gpio
Date: Tue,  1 Jun 2021 11:01:37 +0200	[thread overview]
Message-ID: <20210601090140.261768-4-narmstrong@baylibre.com> (raw)
In-Reply-To: <20210601090140.261768-1-narmstrong@baylibre.com>

As described in the Odroid-C4 schematics, the HUB_5V regulator is controlled
by GPIOH_8 and in Open Drain since this GPIO doesn't support Push-Pull.

Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
index 8c327c03d845..63695ea21b1c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
@@ -31,7 +31,7 @@ hub_5v: regulator-hub_5v {
 		vin-supply = <&vcc_5v>;
 
 		/* Connected to the Hub CHIPENABLE, LOW sets low power state */
-		gpio = <&gpio GPIOH_4 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
 		enable-active-high;
 	};
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: khilman@baylibre.com, jbrunet@baylibre.com,
	martin.blumenstingl@googlemail.com
Cc: linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, tobetter@gmail.com,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: [PATCH 3/6] arm64: dts: meson-sm1-odroid-c4: fix hub_5v regulator gpio
Date: Tue,  1 Jun 2021 11:01:37 +0200	[thread overview]
Message-ID: <20210601090140.261768-4-narmstrong@baylibre.com> (raw)
In-Reply-To: <20210601090140.261768-1-narmstrong@baylibre.com>

As described in the Odroid-C4 schematics, the HUB_5V regulator is controlled
by GPIOH_8 and in Open Drain since this GPIO doesn't support Push-Pull.

Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
index 8c327c03d845..63695ea21b1c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts
@@ -31,7 +31,7 @@ hub_5v: regulator-hub_5v {
 		vin-supply = <&vcc_5v>;
 
 		/* Connected to the Hub CHIPENABLE, LOW sets low power state */
-		gpio = <&gpio GPIOH_4 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
 		enable-active-high;
 	};
 
-- 
2.25.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  parent reply	other threads:[~2021-06-01  9:01 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01  9:01 [PATCH 0/6] arm64: dts: meson-sm1-odroid: various fixes for C4/HC4 Neil Armstrong
2021-06-01  9:01 ` Neil Armstrong
2021-06-01  9:01 ` Neil Armstrong
2021-06-01  9:01 ` [PATCH 1/6] arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-03 18:03   ` Martin Blumenstingl
2021-06-03 18:03     ` Martin Blumenstingl
2021-06-03 18:03     ` Martin Blumenstingl
2021-06-01  9:01 ` [PATCH 2/6] arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as open source Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-03 18:03   ` Martin Blumenstingl
2021-06-03 18:03     ` Martin Blumenstingl
2021-06-03 18:03     ` Martin Blumenstingl
2021-06-01  9:01 ` Neil Armstrong [this message]
2021-06-01  9:01   ` [PATCH 3/6] arm64: dts: meson-sm1-odroid-c4: fix hub_5v regulator gpio Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-03 18:07   ` Martin Blumenstingl
2021-06-03 18:07     ` Martin Blumenstingl
2021-06-03 18:07     ` Martin Blumenstingl
2021-06-04  9:43     ` Neil Armstrong
2021-06-04  9:43       ` Neil Armstrong
2021-06-04  9:43       ` Neil Armstrong
2021-06-04 10:13       ` Martin Blumenstingl
2021-06-04 10:13         ` Martin Blumenstingl
2021-06-04 10:13         ` Martin Blumenstingl
2021-06-04 10:19         ` Neil Armstrong
2021-06-04 10:19           ` Neil Armstrong
2021-06-04 10:19           ` Neil Armstrong
2021-06-01  9:01 ` [PATCH 4/6] arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0 Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-03 18:10   ` Martin Blumenstingl
2021-06-03 18:10     ` Martin Blumenstingl
2021-06-03 18:10     ` Martin Blumenstingl
2021-06-01  9:01 ` [PATCH 5/6] arm64: dts: meson-sm1-odroid-hc4: add regulators controlled by GPIOH_8 Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-03 18:08   ` Martin Blumenstingl
2021-06-03 18:08     ` Martin Blumenstingl
2021-06-03 18:08     ` Martin Blumenstingl
2021-06-01  9:01 ` [PATCH 6/6] arm64: dts: meson-sm1-odroid-hc4: add spifc node to ODROID-HC4 Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-01  9:01   ` Neil Armstrong
2021-06-03 18:10   ` Martin Blumenstingl
2021-06-03 18:10     ` Martin Blumenstingl
2021-06-03 18:10     ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210601090140.261768-4-narmstrong@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=tobetter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.