* [PATCH -next] media: atomisp: Remove unneeded if-null-free check
@ 2021-06-01 14:20 Zheng Yongjun
2021-06-01 14:46 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Zheng Yongjun @ 2021-06-01 14:20 UTC (permalink / raw)
To: mchehab, linux-media, linux-staging, linux-kernel
Cc: sakari.ailus, gregkh, Zheng Yongjun
Eliminate the following coccicheck warning:
drivers/staging/media/atomisp/pci/sh_css_firmware.c:369:4-10: WARNING:
NULL check before some freeing functions is not needed.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/staging/media/atomisp/pci/sh_css_firmware.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
index f4ce8ace9d50..980fc09fcc8b 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
@@ -365,8 +365,7 @@ void sh_css_unload_firmware(void)
for (i = 0; i < sh_css_num_binaries; i++) {
if (fw_minibuffer[i].name)
kfree((void *)fw_minibuffer[i].name);
- if (fw_minibuffer[i].buffer)
- kvfree(fw_minibuffer[i].buffer);
+ kvfree(fw_minibuffer[i].buffer);
}
kfree(fw_minibuffer);
fw_minibuffer = NULL;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] media: atomisp: Remove unneeded if-null-free check
2021-06-01 14:20 [PATCH -next] media: atomisp: Remove unneeded if-null-free check Zheng Yongjun
@ 2021-06-01 14:46 ` Dan Carpenter
2021-06-02 1:32 ` 答复: " zhengyongjun
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2021-06-01 14:46 UTC (permalink / raw)
To: Zheng Yongjun
Cc: mchehab, linux-media, linux-staging, linux-kernel, sakari.ailus, gregkh
On Tue, Jun 01, 2021 at 10:20:05PM +0800, Zheng Yongjun wrote:
> Eliminate the following coccicheck warning:
>
> drivers/staging/media/atomisp/pci/sh_css_firmware.c:369:4-10: WARNING:
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/staging/media/atomisp/pci/sh_css_firmware.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> index f4ce8ace9d50..980fc09fcc8b 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> @@ -365,8 +365,7 @@ void sh_css_unload_firmware(void)
> for (i = 0; i < sh_css_num_binaries; i++) {
> if (fw_minibuffer[i].name)
> kfree((void *)fw_minibuffer[i].name);
Change this too.
> - if (fw_minibuffer[i].buffer)
> - kvfree(fw_minibuffer[i].buffer);
> + kvfree(fw_minibuffer[i].buffer);
> }
> kfree(fw_minibuffer);
> fw_minibuffer = NULL;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* 答复: [PATCH -next] media: atomisp: Remove unneeded if-null-free check
2021-06-01 14:46 ` Dan Carpenter
@ 2021-06-02 1:32 ` zhengyongjun
0 siblings, 0 replies; 3+ messages in thread
From: zhengyongjun @ 2021-06-02 1:32 UTC (permalink / raw)
To: Dan Carpenter
Cc: mchehab, linux-media, linux-staging, linux-kernel, sakari.ailus, gregkh
Thanks for your advice, I send patch v2 now :)
-----邮件原件-----
发件人: Dan Carpenter [mailto:dan.carpenter@oracle.com]
发送时间: 2021年6月1日 22:47
收件人: zhengyongjun <zhengyongjun3@huawei.com>
抄送: mchehab@kernel.org; linux-media@vger.kernel.org; linux-staging@lists.linux.dev; linux-kernel@vger.kernel.org; sakari.ailus@linux.intel.com; gregkh@linuxfoundation.org
主题: Re: [PATCH -next] media: atomisp: Remove unneeded if-null-free check
On Tue, Jun 01, 2021 at 10:20:05PM +0800, Zheng Yongjun wrote:
> Eliminate the following coccicheck warning:
>
> drivers/staging/media/atomisp/pci/sh_css_firmware.c:369:4-10: WARNING:
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/staging/media/atomisp/pci/sh_css_firmware.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> index f4ce8ace9d50..980fc09fcc8b 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> @@ -365,8 +365,7 @@ void sh_css_unload_firmware(void)
> for (i = 0; i < sh_css_num_binaries; i++) {
> if (fw_minibuffer[i].name)
> kfree((void *)fw_minibuffer[i].name);
Change this too.
> - if (fw_minibuffer[i].buffer)
> - kvfree(fw_minibuffer[i].buffer);
> + kvfree(fw_minibuffer[i].buffer);
> }
> kfree(fw_minibuffer);
> fw_minibuffer = NULL;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-02 1:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 14:20 [PATCH -next] media: atomisp: Remove unneeded if-null-free check Zheng Yongjun
2021-06-01 14:46 ` Dan Carpenter
2021-06-02 1:32 ` 答复: " zhengyongjun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.