All of lore.kernel.org
 help / color / mirror / Atom feed
* + mm-thp-refactor-numa-fault-handling-fix.patch added to -mm tree
@ 2021-06-01 23:49 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2021-06-01 23:49 UTC (permalink / raw)
  To: borntraeger, dan.carpenter, gerald.schaefer, gor, hca, hughd,
	kirill.shutemov, mgorman, mhocko, mm-commits, shy828301,
	ying.huang, ziy


The patch titled
     Subject: mm: thp: fix a double unlock bug
has been added to the -mm tree.  Its filename is
     mm-thp-refactor-numa-fault-handling-fix.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/mm-thp-refactor-numa-fault-handling-fix.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/mm-thp-refactor-numa-fault-handling-fix.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: mm: thp: fix a double unlock bug

We're supposed to be holding the "vmf->ptl" spin_lock when we goto
out_map.  The lock is dropped after if finishes cleaning up.

Link: https://lkml.kernel.org/r/YLX8uYN01JmfLnlK@mwanda
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Mel Gorman <mgorman@suse.de>
Acked-by: Yang Shi <shy828301@gmail.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/huge_memory.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/mm/huge_memory.c~mm-thp-refactor-numa-fault-handling-fix
+++ a/mm/huge_memory.c
@@ -1465,10 +1465,8 @@ vm_fault_t do_huge_pmd_numa_page(struct
 
 	pmd = pmd_modify(oldpmd, vma->vm_page_prot);
 	page = vm_normal_page_pmd(vma, haddr, pmd);
-	if (!page) {
-		spin_unlock(vmf->ptl);
+	if (!page)
 		goto out_map;
-	}
 
 	/* See similar comment in do_numa_page for explanation */
 	if (!was_writable)
_

Patches currently in -mm which might be from dan.carpenter@oracle.com are

ocfs2-fix-snprintf-checking.patch
mm-thp-refactor-numa-fault-handling-fix.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-01 23:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 23:49 + mm-thp-refactor-numa-fault-handling-fix.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.